From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Wang Subject: Re: [PATCH v2 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator Date: Fri, 11 Aug 2017 14:13:38 +0800 Message-ID: <1502432018.19230.29.camel@mtkswgap22> References: <20170724182242.ejrobnjks3ehprpw@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170724182242.ejrobnjks3ehprpw@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, 2017-07-24 at 13:22 -0500, Rob Herring wrote: > On Tue, Jul 18, 2017 at 05:49:22PM +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > > From: Sean Wang > > > > add dt-binding document for MediaTek MT6380 PMIC > > > > Signed-off-by: Chenglin Xu > > Signed-off-by: Sean Wang > > --- > > .../bindings/regulator/mt6380-regulator.txt | 90 ++++++++++++++++++++++ > > 1 file changed, 90 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt > > > > diff --git a/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt > > new file mode 100644 > > index 0000000..2a559f0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt > > @@ -0,0 +1,90 @@ > > +MediaTek MT6380 Regulator Driver > > Bindings don't describe drivers. > will fix it. > > + > > +All voltage regulators are defined as subnodes of the regulators node. A list > > What's the regulators node a child of? > this two line i felt are a little confusion, i will change them into " all voltage regulators provided by the MT6380 PMIC are described as the subnodes of the mt6380regulators node " > > +of regulators provided by this controller are defined as subnodes of the > > +PMIC's node. Each regulator is named according to its regulator type, > > +buck- and ldo-. The definition for each of these nodes is defined > > +using the standard binding for regulators at > > +Documentation/devicetree/bindings/regulator/regulator.txt. > > + > > +The valid names for regulators are: > > +BUCK: > > + buck-core1, buck-vcore, buck-vrf > > +LDO: > > + ldo-vm ,ldo-va , ldo-vphy, ldo-vddr, ldo-vt -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html