From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Wu Subject: Re: [PATCH 7/8] memory: mtk-smi: Rearrange some function position alphabetically Date: Sat, 12 Aug 2017 17:36:08 +0800 Message-ID: <1502530568.11148.55.camel@mhfsdcap03> References: <1502445377-26936-1-git-send-email-yong.wu@mediatek.com> <1502445377-26936-8-git-send-email-yong.wu@mediatek.com> <34e9e7ec-ff9b-caf9-09ac-a0d9e9d85fa5@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <34e9e7ec-ff9b-caf9-09ac-a0d9e9d85fa5-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Robin Murphy Cc: Joerg Roedel , Rob Herring , Matthias Brugger , Will Deacon , Daniel Kurtz , Tomasz Figa , Mark Rutland , Catalin Marinas , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, honghui.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, k.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, cloud.chou-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Arvind Yadav , youlin.pei-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 2017-08-11 at 19:09 +0100, Robin Murphy wrote: > On 11/08/17 10:56, Yong Wu wrote: > > Only adjust some code position in Soc numerical order, from mt2701, > > mt2712 to mt8173. > > > > Besides, 3 minor changes: > > 1) fix a coding style issue: > > CHECK: Alignment should match open parenthesis > > + writel(reg_val, > > + common->smi_ao_base > > 2) change from readl to readl_relaxed in gen1_config_port. > > 3) change the type "larbid" from "int" to "unsigned int" to meet > > the requirement of of_property_read_u32. > > If moving existing code around is really necessary, do it as a > preliminary patch *before* any material changes (and arguably separate > even from the whitespace and comment updates) - those diffs are usually > hard to review as-is, so being able to check you get binary-identical > object files before and after is reassuring. A "cleanup" patch shouldn't > need to touch code added in the same series, and it certainly shouldn't > have significant things like the readl_relaxed() change hidden in it. OK. This patch is really not easy to read. This patch-set is mainly for supporting MT2712 IOMMU. thus, I will use a patch "readl_relaxed replace readl" instead of this one. About the cleanup patch, I can send it in future if necessary. > > Robin. > > > Signed-off-by: Yong Wu > > --- > > drivers/memory/mtk-smi.c | 105 +++++++++++++++++++++++------------------------ > > 1 file changed, 52 insertions(+), 53 deletions(-) > > [...] -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html