From: Jun Gao <jun.gao@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding
Date: Mon, 14 Aug 2017 18:05:39 +0800 [thread overview]
Message-ID: <1502705139.930.78.camel@mhfsdcap03> (raw)
In-Reply-To: <3384d424-827a-0a4b-d1d6-7d361d8c8391@gmail.com>
On Mon, 2017-08-14 at 11:36 +0200, Matthias Brugger wrote:
>
> On 08/09/2017 09:43 AM, Jun Gao wrote:
> > From: Jun Gao <jun.gao@mediatek.com>
> >
> > Add MT7622 i2c binding to binding file. Compare to MT8173 i2c
> > controller, MT7622 limit message size to 255, and not support
> > 4GB DMA mode.
> >
> > Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> > index bd5a7be..ff9ac61 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
> >
> > Required properties:
> > - compatible: value should be either of the following.
> > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
> > - "mediatek,mt6577-i2c": for i2c compatible with mt6577.
> > - "mediatek,mt6589-i2c": for i2c compatible with mt6589.
> > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
> > - "mediatek,mt8173-i2c": for i2c compatible with mt8173.
> > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> > + "mediatek,mt6577-i2c": for Mediatek MT6577
> > + "mediatek,mt6589-i2c": for Mediatek MT6589
> > + "mediatek,mt7622-i2c": for Mediatek MT7622
> > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> > + "mediatek,mt8173-i2c": for Mediatek MT8173
> > - reg: physical base address of the controller and dma base, length of memory
> > mapped region.
> > - interrupts: interrupt number to the cpu.
> >
>
> In the next series, could you please make sure not to change the indentation.
>
> Thanks a lot,
> Matthias
Please review [PATCH v2 1/2], I will not change the indentation any
more. Thanks!
Jun
next prev parent reply other threads:[~2017-08-14 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 7:43 [PATCH 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC Jun Gao
2017-08-09 7:43 ` [PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao
2017-08-14 9:36 ` Matthias Brugger
2017-08-14 10:05 ` Jun Gao [this message]
2017-08-09 7:43 ` [PATCH 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao
[not found] ` <1502264631-12572-3-git-send-email-jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-09 9:40 ` Yingjoe Chen
2017-08-09 12:58 ` Jun Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502705139.930.78.camel@mhfsdcap03 \
--to=jun.gao@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).