devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] usb: mtu3: add generic compatible string
@ 2017-08-08  5:42 Chunfeng Yun
  2017-08-08  5:42 ` [PATCH 2/4] usb: xhci-mtk: " Chunfeng Yun
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Chunfeng Yun @ 2017-08-08  5:42 UTC (permalink / raw)
  To: Mathias Nyman, Felipe Balbi
  Cc: Greg Kroah-Hartman, Matthias Brugger, Rob Herring, Mark Rutland,
	Ian Campbell, Chunfeng Yun, linux-kernel, linux-arm-kernel,
	linux-usb, linux-mediatek, devicetree

The mtu3 driver is a generic driver for MediaTek usb3 DRD IP, add
a generic compatible to avoid confusion when support new SoCs but
use a compatible with specific SoC's name "mt8173".

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/mtu3/mtu3_plat.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c
index 0d3ebb3..088e3e6 100644
--- a/drivers/usb/mtu3/mtu3_plat.c
+++ b/drivers/usb/mtu3/mtu3_plat.c
@@ -500,6 +500,7 @@ static int __maybe_unused mtu3_resume(struct device *dev)
 
 static const struct of_device_id mtu3_of_match[] = {
 	{.compatible = "mediatek,mt8173-mtu3",},
+	{.compatible = "mediatek,mtu3",},
 	{},
 };
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/4] usb: xhci-mtk: add generic compatible string
  2017-08-08  5:42 [PATCH 1/4] usb: mtu3: add generic compatible string Chunfeng Yun
@ 2017-08-08  5:42 ` Chunfeng Yun
  2017-08-08  5:42 ` [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file Chunfeng Yun
       [not found] ` <8f0cb0047b2aa195d818ad686cbbceabb3ad91a0.1502170518.git.chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
  2 siblings, 0 replies; 10+ messages in thread
From: Chunfeng Yun @ 2017-08-08  5:42 UTC (permalink / raw)
  To: Mathias Nyman, Felipe Balbi
  Cc: Greg Kroah-Hartman, Matthias Brugger, Rob Herring, Mark Rutland,
	Ian Campbell, Chunfeng Yun, linux-kernel, linux-arm-kernel,
	linux-usb, linux-mediatek, devicetree

The xhci-mtk driver is a generic driver for MediaTek xHCI IP, add
a generic compatible to avoid confusion when support new SoCs but
use a compatible with specific SoC's name "mt8173".

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/host/xhci-mtk.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 67d5dc7..d2934b9 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -795,6 +795,7 @@ static int __maybe_unused xhci_mtk_resume(struct device *dev)
 #ifdef CONFIG_OF
 static const struct of_device_id mtk_xhci_of_match[] = {
 	{ .compatible = "mediatek,mt8173-xhci"},
+	{ .compatible = "mediatek,xhci-mtk"},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, mtk_xhci_of_match);
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file
  2017-08-08  5:42 [PATCH 1/4] usb: mtu3: add generic compatible string Chunfeng Yun
  2017-08-08  5:42 ` [PATCH 2/4] usb: xhci-mtk: " Chunfeng Yun
@ 2017-08-08  5:42 ` Chunfeng Yun
       [not found]   ` <121eaec8845c62383701d4fdfe9649335937f025.1502170518.git.chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
       [not found] ` <8f0cb0047b2aa195d818ad686cbbceabb3ad91a0.1502170518.git.chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
  2 siblings, 1 reply; 10+ messages in thread
From: Chunfeng Yun @ 2017-08-08  5:42 UTC (permalink / raw)
  To: Mathias Nyman, Felipe Balbi
  Cc: Greg Kroah-Hartman, Matthias Brugger, Rob Herring, Mark Rutland,
	Ian Campbell, Chunfeng Yun, linux-kernel, linux-arm-kernel,
	linux-usb, linux-mediatek, devicetree

The mt8173-mtu3.txt actually holds the bindings for all mediatek
SoCs with usb3 DRD IP, so add a generic compatible and change the
name to mtu3.txt.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 .../bindings/usb/{mt8173-mtu3.txt => mtu3.txt}     |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mtu3.txt} (95%)

diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mtu3.txt
similarity index 95%
rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
rename to Documentation/devicetree/bindings/usb/mtu3.txt
index 1d7c3bc..832741d 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+++ b/Documentation/devicetree/bindings/usb/mtu3.txt
@@ -1,7 +1,9 @@
 The device node for Mediatek USB3.0 DRD controller
 
 Required properties:
- - compatible : should be "mediatek,mt8173-mtu3"
+ - compatible : should be one of
+	"mediatek,mt8173-mtu3" (deprecated, use "mediatek,mtu3" instead),
+	"mediatek,mtu3"
  - reg : specifies physical base address and size of the registers
  - reg-names: should be "mac" for device IP and "ippc" for IP port control
  - interrupts : interrupt used by the device IP
@@ -44,7 +46,7 @@ Optional properties:
 Sub-nodes:
 The xhci should be added as subnode to mtu3 as shown in the following example
 if host mode is enabled. The DT binding details of xhci can be found in:
-Documentation/devicetree/bindings/usb/mt8173-xhci.txt
+Documentation/devicetree/bindings/usb/xhci-mtk.txt
 
 Example:
 ssusb: usb@11271000 {
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file
       [not found] ` <8f0cb0047b2aa195d818ad686cbbceabb3ad91a0.1502170518.git.chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2017-08-08  5:42   ` Chunfeng Yun
       [not found]     ` <ed176bd0af123ad6a94982c628bb70a6a3bf7515.1502170518.git.chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
  0 siblings, 1 reply; 10+ messages in thread
From: Chunfeng Yun @ 2017-08-08  5:42 UTC (permalink / raw)
  To: Mathias Nyman, Felipe Balbi
  Cc: Greg Kroah-Hartman, Matthias Brugger, Rob Herring, Mark Rutland,
	Ian Campbell, Chunfeng Yun, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

The mt8173-xhci.txt actually holds the bindings for all mediatek
SoCs with xHCI controller, so add a generic compatible and change
the name to xhci-mtk.txt to reflect that.

Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 .../bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
 rename Documentation/devicetree/bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} (92%)

diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
similarity index 92%
rename from Documentation/devicetree/bindings/usb/mt8173-xhci.txt
rename to Documentation/devicetree/bindings/usb/xhci-mtk.txt
index 0acfc8a..1ce77c7 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
@@ -11,7 +11,9 @@ into two parts.
 ------------------------------------------------------------------------
 
 Required properties:
- - compatible : should contain "mediatek,mt8173-xhci"
+ - compatible : should be one of
+	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),
+	"mediatek,xhci-mtk"
  - reg : specifies physical base address and size of the registers
  - reg-names: should be "mac" for xHCI MAC and "ippc" for IP port control
  - interrupts : interrupt used by the controller
@@ -68,10 +70,12 @@ usb30: usb@11270000 {
 
 In the case, xhci is added as subnode to mtu3. An example and the DT binding
 details of mtu3 can be found in:
-Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+Documentation/devicetree/bindings/usb/mtu3.txt
 
 Required properties:
- - compatible : should contain "mediatek,mt8173-xhci"
+ - compatible : should be one of
+	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),
+	"mediatek,xhci-mtk"
  - reg : specifies physical base address and size of the registers
  - reg-names: should be "mac" for xHCI MAC
  - interrupts : interrupt used by the host controller
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file
       [not found]   ` <121eaec8845c62383701d4fdfe9649335937f025.1502170518.git.chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2017-08-11  2:54     ` Rob Herring
  2017-08-11  7:00       ` Chunfeng Yun
  0 siblings, 1 reply; 10+ messages in thread
From: Rob Herring @ 2017-08-11  2:54 UTC (permalink / raw)
  To: Chunfeng Yun
  Cc: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Matthias Brugger,
	Mark Rutland, Ian Campbell, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Tue, Aug 08, 2017 at 01:42:51PM +0800, Chunfeng Yun wrote:
> The mt8173-mtu3.txt actually holds the bindings for all mediatek
> SoCs with usb3 DRD IP, so add a generic compatible and change the
> name to mtu3.txt.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
>  .../bindings/usb/{mt8173-mtu3.txt => mtu3.txt}     |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>  rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mtu3.txt} (95%)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mtu3.txt
> similarity index 95%
> rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> rename to Documentation/devicetree/bindings/usb/mtu3.txt
> index 1d7c3bc..832741d 100644
> --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> +++ b/Documentation/devicetree/bindings/usb/mtu3.txt

mediatek,mtu3.txt

> @@ -1,7 +1,9 @@
>  The device node for Mediatek USB3.0 DRD controller
>  
>  Required properties:
> - - compatible : should be "mediatek,mt8173-mtu3"
> + - compatible : should be one of
> +	"mediatek,mt8173-mtu3" (deprecated, use "mediatek,mtu3" instead),

NAK. You can add generic compatibles, but you need SoC specific ones in 
addition.

> +	"mediatek,mtu3"
>   - reg : specifies physical base address and size of the registers
>   - reg-names: should be "mac" for device IP and "ippc" for IP port control
>   - interrupts : interrupt used by the device IP
> @@ -44,7 +46,7 @@ Optional properties:
>  Sub-nodes:
>  The xhci should be added as subnode to mtu3 as shown in the following example
>  if host mode is enabled. The DT binding details of xhci can be found in:
> -Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> +Documentation/devicetree/bindings/usb/xhci-mtk.txt

This should be in the patch that renames this file.

>  
>  Example:
>  ssusb: usb@11271000 {
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file
       [not found]     ` <ed176bd0af123ad6a94982c628bb70a6a3bf7515.1502170518.git.chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2017-08-11  2:56       ` Rob Herring
  2017-08-11  7:01         ` Chunfeng Yun
  0 siblings, 1 reply; 10+ messages in thread
From: Rob Herring @ 2017-08-11  2:56 UTC (permalink / raw)
  To: Chunfeng Yun
  Cc: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Matthias Brugger,
	Mark Rutland, Ian Campbell, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Tue, Aug 08, 2017 at 01:42:52PM +0800, Chunfeng Yun wrote:
> The mt8173-xhci.txt actually holds the bindings for all mediatek
> SoCs with xHCI controller, so add a generic compatible and change
> the name to xhci-mtk.txt to reflect that.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
>  .../bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} |   10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>  rename Documentation/devicetree/bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} (92%)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
> similarity index 92%
> rename from Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> rename to Documentation/devicetree/bindings/usb/xhci-mtk.txt

mediatek,mtk-xhci.txt

> index 0acfc8a..1ce77c7 100644
> --- a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
> @@ -11,7 +11,9 @@ into two parts.
>  ------------------------------------------------------------------------
>  
>  Required properties:
> - - compatible : should contain "mediatek,mt8173-xhci"
> + - compatible : should be one of
> +	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),

NAK for same reason.

> +	"mediatek,xhci-mtk"

mediatek,mtk-xhci would be more in line with conventions.

>   - reg : specifies physical base address and size of the registers
>   - reg-names: should be "mac" for xHCI MAC and "ippc" for IP port control
>   - interrupts : interrupt used by the controller
> @@ -68,10 +70,12 @@ usb30: usb@11270000 {
>  
>  In the case, xhci is added as subnode to mtu3. An example and the DT binding
>  details of mtu3 can be found in:
> -Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> +Documentation/devicetree/bindings/usb/mtu3.txt
>  
>  Required properties:
> - - compatible : should contain "mediatek,mt8173-xhci"
> + - compatible : should be one of
> +	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),
> +	"mediatek,xhci-mtk"
>   - reg : specifies physical base address and size of the registers
>   - reg-names: should be "mac" for xHCI MAC
>   - interrupts : interrupt used by the host controller
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file
  2017-08-11  2:54     ` Rob Herring
@ 2017-08-11  7:00       ` Chunfeng Yun
  2017-08-14 11:23         ` Matthias Brugger
  0 siblings, 1 reply; 10+ messages in thread
From: Chunfeng Yun @ 2017-08-11  7:00 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Matthias Brugger,
	Mark Rutland, Ian Campbell, linux-kernel, linux-arm-kernel,
	linux-usb, linux-mediatek, devicetree

On Thu, 2017-08-10 at 21:54 -0500, Rob Herring wrote:
> On Tue, Aug 08, 2017 at 01:42:51PM +0800, Chunfeng Yun wrote:
> > The mt8173-mtu3.txt actually holds the bindings for all mediatek
> > SoCs with usb3 DRD IP, so add a generic compatible and change the
> > name to mtu3.txt.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  .../bindings/usb/{mt8173-mtu3.txt => mtu3.txt}     |    6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >  rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mtu3.txt} (95%)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mtu3.txt
> > similarity index 95%
> > rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > rename to Documentation/devicetree/bindings/usb/mtu3.txt
> > index 1d7c3bc..832741d 100644
> > --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > +++ b/Documentation/devicetree/bindings/usb/mtu3.txt
> 
> mediatek,mtu3.txt
Ok
> 
> > @@ -1,7 +1,9 @@
> >  The device node for Mediatek USB3.0 DRD controller
> >  
> >  Required properties:
> > - - compatible : should be "mediatek,mt8173-mtu3"
> > + - compatible : should be one of
> > +	"mediatek,mt8173-mtu3" (deprecated, use "mediatek,mtu3" instead),
> 
> NAK. You can add generic compatibles, but you need SoC specific ones in 
> addition.
It's for backward compatibility

> 
> > +	"mediatek,mtu3"
Is it appropriate if changed to "mediatek,generic-mtu3"?

> >   - reg : specifies physical base address and size of the registers
> >   - reg-names: should be "mac" for device IP and "ippc" for IP port control
> >   - interrupts : interrupt used by the device IP
> > @@ -44,7 +46,7 @@ Optional properties:
> >  Sub-nodes:
> >  The xhci should be added as subnode to mtu3 as shown in the following example
> >  if host mode is enabled. The DT binding details of xhci can be found in:
> > -Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > +Documentation/devicetree/bindings/usb/xhci-mtk.txt
> 
> This should be in the patch that renames this file.
Ok
> 
> >  
> >  Example:
> >  ssusb: usb@11271000 {
> > -- 
> > 1.7.9.5
> > 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file
  2017-08-11  2:56       ` Rob Herring
@ 2017-08-11  7:01         ` Chunfeng Yun
  0 siblings, 0 replies; 10+ messages in thread
From: Chunfeng Yun @ 2017-08-11  7:01 UTC (permalink / raw)
  To: Rob Herring
  Cc: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Matthias Brugger,
	Mark Rutland, Ian Campbell, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Thu, 2017-08-10 at 21:56 -0500, Rob Herring wrote:
> On Tue, Aug 08, 2017 at 01:42:52PM +0800, Chunfeng Yun wrote:
> > The mt8173-xhci.txt actually holds the bindings for all mediatek
> > SoCs with xHCI controller, so add a generic compatible and change
> > the name to xhci-mtk.txt to reflect that.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> >  .../bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} |   10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >  rename Documentation/devicetree/bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} (92%)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
> > similarity index 92%
> > rename from Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > rename to Documentation/devicetree/bindings/usb/xhci-mtk.txt
> 
> mediatek,mtk-xhci.txt
Ok
> 
> > index 0acfc8a..1ce77c7 100644
> > --- a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > +++ b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
> > @@ -11,7 +11,9 @@ into two parts.
> >  ------------------------------------------------------------------------
> >  
> >  Required properties:
> > - - compatible : should contain "mediatek,mt8173-xhci"
> > + - compatible : should be one of
> > +	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),
> 
> NAK for same reason.
It's backward compatible
> 
> > +	"mediatek,xhci-mtk"
> 
> mediatek,mtk-xhci would be more in line with conventions.
Ok
> 
> >   - reg : specifies physical base address and size of the registers
> >   - reg-names: should be "mac" for xHCI MAC and "ippc" for IP port control
> >   - interrupts : interrupt used by the controller
> > @@ -68,10 +70,12 @@ usb30: usb@11270000 {
> >  
> >  In the case, xhci is added as subnode to mtu3. An example and the DT binding
> >  details of mtu3 can be found in:
> > -Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > +Documentation/devicetree/bindings/usb/mtu3.txt
> >  
> >  Required properties:
> > - - compatible : should contain "mediatek,mt8173-xhci"
> > + - compatible : should be one of
> > +	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),
> > +	"mediatek,xhci-mtk"
> >   - reg : specifies physical base address and size of the registers
> >   - reg-names: should be "mac" for xHCI MAC
> >   - interrupts : interrupt used by the host controller
> > -- 
> > 1.7.9.5
> > 


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file
  2017-08-11  7:00       ` Chunfeng Yun
@ 2017-08-14 11:23         ` Matthias Brugger
       [not found]           ` <3623aff5-ec37-3209-f6d7-9eaf17096afa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 10+ messages in thread
From: Matthias Brugger @ 2017-08-14 11:23 UTC (permalink / raw)
  To: Chunfeng Yun, Rob Herring
  Cc: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Mark Rutland,
	Ian Campbell, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA



On 08/11/2017 09:00 AM, Chunfeng Yun wrote:
> On Thu, 2017-08-10 at 21:54 -0500, Rob Herring wrote:
>> On Tue, Aug 08, 2017 at 01:42:51PM +0800, Chunfeng Yun wrote:
>>> The mt8173-mtu3.txt actually holds the bindings for all mediatek
>>> SoCs with usb3 DRD IP, so add a generic compatible and change the
>>> name to mtu3.txt.
>>>
>>> Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>>> ---
>>>   .../bindings/usb/{mt8173-mtu3.txt => mtu3.txt}     |    6 ++++--
>>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>>   rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mtu3.txt} (95%)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mtu3.txt
>>> similarity index 95%
>>> rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
>>> rename to Documentation/devicetree/bindings/usb/mtu3.txt
>>> index 1d7c3bc..832741d 100644
>>> --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
>>> +++ b/Documentation/devicetree/bindings/usb/mtu3.txt
>>
>> mediatek,mtu3.txt
> Ok
>>
>>> @@ -1,7 +1,9 @@
>>>   The device node for Mediatek USB3.0 DRD controller
>>>   
>>>   Required properties:
>>> - - compatible : should be "mediatek,mt8173-mtu3"
>>> + - compatible : should be one of
>>> +	"mediatek,mt8173-mtu3" (deprecated, use "mediatek,mtu3" instead),
>>
>> NAK. You can add generic compatibles, but you need SoC specific ones in
>> addition.
> It's for backward compatibility
> 

I think backwards compatibility should be in the driver but not in the binding 
description. Apart from that device tree files will need to provide a SoC 
specific binding apart from the generic one, for example:

"mediatek,mt8173-mtu3", "mediatek,mtu3": for mt8173
"mediatek,mt7623-mtu3", "mediatek,mtu3": for mt6723

This is needed to cover possible bugs/features that can be found in the future 
for a specific SoC. The driver can match just against the generic binding and 
will only implement a match against the SoC specific one if a bug/feature is 
present.

Makes sense?

Regards,
Matthias
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file
       [not found]           ` <3623aff5-ec37-3209-f6d7-9eaf17096afa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-08-15  2:22             ` Chunfeng Yun
  0 siblings, 0 replies; 10+ messages in thread
From: Chunfeng Yun @ 2017-08-15  2:22 UTC (permalink / raw)
  To: Matthias Brugger
  Cc: Rob Herring, Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman,
	Mark Rutland, Ian Campbell, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Mon, 2017-08-14 at 13:23 +0200, Matthias Brugger wrote:
> 
> On 08/11/2017 09:00 AM, Chunfeng Yun wrote:
> > On Thu, 2017-08-10 at 21:54 -0500, Rob Herring wrote:
> >> On Tue, Aug 08, 2017 at 01:42:51PM +0800, Chunfeng Yun wrote:
> >>> The mt8173-mtu3.txt actually holds the bindings for all mediatek
> >>> SoCs with usb3 DRD IP, so add a generic compatible and change the
> >>> name to mtu3.txt.
> >>>
> >>> Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> >>> ---
> >>>   .../bindings/usb/{mt8173-mtu3.txt => mtu3.txt}     |    6 ++++--
> >>>   1 file changed, 4 insertions(+), 2 deletions(-)
> >>>   rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mtu3.txt} (95%)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mtu3.txt
> >>> similarity index 95%
> >>> rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> >>> rename to Documentation/devicetree/bindings/usb/mtu3.txt
> >>> index 1d7c3bc..832741d 100644
> >>> --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> >>> +++ b/Documentation/devicetree/bindings/usb/mtu3.txt
> >>
> >> mediatek,mtu3.txt
> > Ok
> >>
> >>> @@ -1,7 +1,9 @@
> >>>   The device node for Mediatek USB3.0 DRD controller
> >>>   
> >>>   Required properties:
> >>> - - compatible : should be "mediatek,mt8173-mtu3"
> >>> + - compatible : should be one of
> >>> +	"mediatek,mt8173-mtu3" (deprecated, use "mediatek,mtu3" instead),
> >>
> >> NAK. You can add generic compatibles, but you need SoC specific ones in
> >> addition.
> > It's for backward compatibility
> > 
> 
> I think backwards compatibility should be in the driver but not in the binding 
> description. Apart from that device tree files will need to provide a SoC 
> specific binding apart from the generic one, for example:
> 
> "mediatek,mt8173-mtu3", "mediatek,mtu3": for mt8173
> "mediatek,mt7623-mtu3", "mediatek,mtu3": for mt6723
> 
> This is needed to cover possible bugs/features that can be found in the future 
> for a specific SoC. The driver can match just against the generic binding and 
> will only implement a match against the SoC specific one if a bug/feature is 
> present.
> 
> Makes sense?
Got it, thanks a lot
> 
> Regards,
> Matthias


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-08-15  2:22 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-08  5:42 [PATCH 1/4] usb: mtu3: add generic compatible string Chunfeng Yun
2017-08-08  5:42 ` [PATCH 2/4] usb: xhci-mtk: " Chunfeng Yun
2017-08-08  5:42 ` [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file Chunfeng Yun
     [not found]   ` <121eaec8845c62383701d4fdfe9649335937f025.1502170518.git.chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-11  2:54     ` Rob Herring
2017-08-11  7:00       ` Chunfeng Yun
2017-08-14 11:23         ` Matthias Brugger
     [not found]           ` <3623aff5-ec37-3209-f6d7-9eaf17096afa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-15  2:22             ` Chunfeng Yun
     [not found] ` <8f0cb0047b2aa195d818ad686cbbceabb3ad91a0.1502170518.git.chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-08  5:42   ` [PATCH 4/4] dt-bindings: mt8173-xhci: " Chunfeng Yun
     [not found]     ` <ed176bd0af123ad6a94982c628bb70a6a3bf7515.1502170518.git.chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-11  2:56       ` Rob Herring
2017-08-11  7:01         ` Chunfeng Yun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).