From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
Date: Tue, 15 Aug 2017 14:48:41 +0800
Message-ID: <1502779721.2591.4.camel@intel.com>
References: <20170809220257.4234-1-code@mmayer.net>
         <20170809220257.4234-3-code@mmayer.net> <1502777298.2591.1.camel@intel.com>
         <95da51df3cadbb05f721f2e5b8d59f8d@milecki.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Return-path: <linux-pm-owner@vger.kernel.org>
In-Reply-To: <95da51df3cadbb05f721f2e5b8d59f8d@milecki.pl>
Sender: linux-pm-owner@vger.kernel.org
To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>
Cc: Markus Mayer <code@mmayer.net>, Eduardo Valentin <edubezval@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Doug Berger <opendmb@gmail.com>, Brian Norris <computersforpeace@gmail.com>, Gregory Fong <gregory.0xf0@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>, Power Management List <linux-pm@vger.kernel.org>, Device Tree List <devicetree@vger.kernel.org>, ARM Kernel List <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>Markus
List-Id: devicetree@vger.kernel.org

On Tue, 2017-08-15 at 08:42 +0200, Rafał Miłecki wrote:
> On 2017-08-15 08:08, Zhang Rui wrote:
> > 
> > > 
> > > diff --git a/drivers/thermal/broadcom/Kconfig
> > > b/drivers/thermal/broadcom/Kconfig
> > > index 42c098e..c106a15 100644
> > > --- a/drivers/thermal/broadcom/Kconfig
> > > +++ b/drivers/thermal/broadcom/Kconfig
> > > @@ -6,6 +6,13 @@ config BCM2835_THERMAL
> > >  	help
> > >  	  Support for thermal sensors on Broadcom bcm2835 SoCs.
> > >  
> > > +config BRCMSTB_THERMAL
> > > +	tristate "Broadcom STB AVS TMON thermal driver"
> > > +	depends on ARCH_BRCMSTB || COMPILE_TEST
> > > +	help
> > > +	  Enable this driver if you have a Broadcom STB SoC and
> > > would like
> > > +	  thermal framework support.
> > > +
> > I don't understand why I got the following checkpatch warning
> > 
> > WARNING: please write a paragraph that describes the config symbol
> > fully
> > #73: FILE: drivers/thermal/broadcom/Kconfig:9:
> > +config BRCMSTB_THERMAL
> > 
> > I didn't see this for other Kconfig changes.
> It's because your help message is only 2 lines long (instead of 3).
> 
> Some (many?) maintainers aren't pedantic about that, a common sense 
> should
> be applied ;)

thanks for explaining.
Patch 1 and 2 queued for next merge window.

-rui