From: Sean Wang <sean.wang@mediatek.com>
To: Jun Gao <jun.gao@mediatek.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding
Date: Wed, 16 Aug 2017 10:20:23 +0800 [thread overview]
Message-ID: <1502850023.19230.42.camel@mtkswgap22> (raw)
In-Reply-To: <1502802495-5064-2-git-send-email-jun.gao@mediatek.com>
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote:
> From: Jun Gao <jun.gao@mediatek.com>
>
> Add MT7622 i2c binding to binding file and change the compatible
> information formats of all SoCs to the same.
>
> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> index bd5a7be..71fc0b3 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
>
> Required properties:
> - compatible: value should be either of the following.
> - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
> - "mediatek,mt6577-i2c": for i2c compatible with mt6577.
> - "mediatek,mt6589-i2c": for i2c compatible with mt6589.
> - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
> - "mediatek,mt8173-i2c": for i2c compatible with mt8173.
> + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> + "mediatek,mt6577-i2c": for Mediatek MT6577
> + "mediatek,mt6589-i2c": for Mediatek MT6589
> + "mediatek,mt7622-i2c": for Mediatek MT7622
> + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> + "mediatek,mt8173-i2c": for Mediatek MT8173
> - reg: physical base address of the controller and dma base, length of memory
> mapped region.
> - interrupts: interrupt number to the cpu.
Hi, Jun
the patch for new soc support and clean-ups should better be in separate
patch following previous Matthias suggestion.
http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009740.html
And also spelling for Mediatek should be corrected using MediaTek.
Sean
next prev parent reply other threads:[~2017-08-16 2:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 13:08 [PATCH v3 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC Jun Gao
[not found] ` <1502802495-5064-1-git-send-email-jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-15 13:08 ` [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao
2017-08-16 2:20 ` Sean Wang [this message]
2017-08-15 13:08 ` [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao
[not found] ` <1502802495-5064-3-git-send-email-jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-16 3:08 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502850023.19230.42.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=jun.gao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).