From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for X-Gene QMTM UIO driver Date: Tue, 18 Nov 2014 14:10:35 +0100 Message-ID: <1503477.DVdkExccIe@wuerfel> References: <1416220572-13381-1-git-send-email-ankit.jindal@linaro.org> <2279061.naADrHDgyn@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ankit Jindal Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Varka Bhadram , Russell King - ARM Linux , Greg Kroah-Hartman , Anup Patel , Guenter Roeck , "patches-qTEPVZfXA3Y@public.gmane.org" , Rob Herring , "Hans J. Koch" , Tushar Jagad , Kumar Gala , Andreas =?ISO-8859-1?Q?F=E4rber?= List-Id: devicetree@vger.kernel.org On Tuesday 18 November 2014 14:59:54 Ankit Jindal wrote: > On 17 November 2014 16:47, Arnd Bergmann wrote: > > On Monday 17 November 2014 16:06:11 Ankit Jindal wrote: > >> + > >> + qmtm1_uio: qmtm_uio@1f200000 { > >> + compatible = "apm,xgene-qmtm"; > >> + status = "disabled"; > >> + reg = <0x0 0x1f200000 0x0 0x10000>, > >> + <0x0 0x1b000000 0x0 0x400000>; > >> + reg-names = "csr", "fabric"; > >> + qpool-memory = <&qmtm1_uio_qpool>; > >> + clocks = <&qmtm1clk 0>; > >> + num-queues = <0x400>; > >> + devid = <1>; > >> + }; > >> + > > > > To make my previous review comments clearer: > > > > NAK > > > > Do not create device nodes that are meant for a specific use case in > > software and that are not usable for the common case. I don't think > > it makes any sense to keep on submitting a UIO driver for this until > > we have a proper network driver that uses this so we can make sure we > > have a working binding. > > The dataplane frameworks like OpenDataPlane etc, need to have access > to complete subsystem from the user space. Hence, we would like to > have this driver and some other UIO drivers to be the part of kernel > to have data plane frameworks working on our platform. Please work with the people that do the in-kernel QMTM driver to come up with a common binding then. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html