From: Eugeniy Paltsev <Eugeniy.Paltsev-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
To: Vineet Gupta
<Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
"linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"mark.rutland-5wv7dgnIgG8@public.gmane.org"
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Alexey Brodkin
<Alexey.Brodkin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 4/5] ARC: AXS103: DTS: Set cpu frequency explicitly via dts
Date: Wed, 23 Aug 2017 11:24:15 +0000 [thread overview]
Message-ID: <1503487454.2586.58.camel@synopsys.com> (raw)
In-Reply-To: <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
On Tue, 2017-08-22 at 14:40 -0700, Vineet Gupta wrote:
> On 08/14/2017 09:12 AM, Eugeniy Paltsev wrote:
> > Set cpu frequency explicitly via "cpu-freq" param in cpu 0 node
> > in device tree.
> >
> > We add "cpu-freq" only to cpu 0 as all cpus are clocking from same
> > clock source (same pll in our case).
> >
> > We override cpus node in skeleton as we don't need this change for
> > nsim.
>
> Given that you added a generic feature as part of 1/5 - do other
> platforms
> abilis/nps need corresponding fixups as this one !
Actually no.
If cpu 0 node don't have "cpu-freq" property we simply print cpu
frequency and don't try to change it.
So we can left other dts untouched.
> >
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> > ---
> > arch/arc/boot/dts/axc003.dtsi | 13 +++++++++++++
> > arch/arc/boot/dts/axc003_idu.dtsi | 35
> > +++++++++++++++++++++++++++++++++++
> > 2 files changed, 48 insertions(+)
> >
> > diff --git a/arch/arc/boot/dts/axc003.dtsi
> > b/arch/arc/boot/dts/axc003.dtsi
> > index dca7e39..7c7411c 100644
> > --- a/arch/arc/boot/dts/axc003.dtsi
> > +++ b/arch/arc/boot/dts/axc003.dtsi
> > @@ -17,6 +17,19 @@
> > #address-cells = <2>;
> > #size-cells = <2>;
> >
> > + cpus {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + cpu@0 {
> > + device_type = "cpu";
> > + compatible = "snps,archs38";
> > + reg = <0>;
> > + cpu-freq = <100000000>;
> > + clocks = <&core_clk>;
> > + };
> > + };
> > +
> > cpu_card {
> > compatible = "simple-bus";
> > #address-cells = <1>;
> > diff --git a/arch/arc/boot/dts/axc003_idu.dtsi
> > b/arch/arc/boot/dts/axc003_idu.dtsi
> > index 5b56bef..44bc01e 100644
> > --- a/arch/arc/boot/dts/axc003_idu.dtsi
> > +++ b/arch/arc/boot/dts/axc003_idu.dtsi
> > @@ -17,6 +17,41 @@
> > #address-cells = <2>;
> > #size-cells = <2>;
> >
> > + cpus {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + /*
> > + * "cpu-freq" was added only to cpu 0 as all cpus
> > are clocking
> > + * from same clock source (same pll (core_clk) in
> > our case).
> > + */
> > + cpu@0 {
> > + device_type = "cpu";
> > + compatible = "snps,archs38";
> > + reg = <0>;
> > + cpu-freq = <100000000>;
> > + clocks = <&core_clk>;
> > + };
> > + cpu@1 {
> > + device_type = "cpu";
> > + compatible = "snps,archs38";
> > + reg = <1>;
> > + clocks = <&core_clk>;
> > + };
> > + cpu@2 {
> > + device_type = "cpu";
> > + compatible = "snps,archs38";
> > + reg = <2>;
> > + clocks = <&core_clk>;
> > + };
> > + cpu@3 {
> > + device_type = "cpu";
> > + compatible = "snps,archs38";
> > + reg = <3>;
> > + clocks = <&core_clk>;
> > + };
> > + };
> > +
> > cpu_card {
> > compatible = "simple-bus";
> > #address-cells = <1>;
>
>
--
Eugeniy Paltsev
next prev parent reply other threads:[~2017-08-23 11:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 16:12 [PATCH 0/5] Updates to arc clock tree managment Eugeniy Paltsev
2017-08-14 16:12 ` [PATCH 1/5] ARC: set and print cpu frequency at boot time Eugeniy Paltsev
2017-08-14 16:12 ` [PATCH 2/5] ARC: AXS103: Get rid of platform specific cpu clock configuration Eugeniy Paltsev
2017-08-22 20:39 ` Vineet Gupta
2017-08-14 16:12 ` [PATCH 3/5] ARC: AXS103: DTS: Add core pll node to manage cpu frequency Eugeniy Paltsev
[not found] ` <20170814161213.17522-4-Eugeniy.Paltsev-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-08-22 20:40 ` Vineet Gupta
2017-08-22 20:45 ` Vineet Gupta
[not found] ` <9624a76d-a31f-10fc-aec5-5ffa1d437c3d-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-08-23 12:18 ` Eugeniy Paltsev
2017-08-14 16:12 ` [PATCH 4/5] ARC: AXS103: DTS: Set cpu frequency explicitly via dts Eugeniy Paltsev
[not found] ` <20170814161213.17522-5-Eugeniy.Paltsev-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-08-22 21:40 ` Vineet Gupta
[not found] ` <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-08-23 11:24 ` Eugeniy Paltsev [this message]
[not found] ` <1503487454.2586.58.camel-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-08-23 16:39 ` Vineet Gupta
2017-08-14 16:12 ` [PATCH 5/5] ARC: AXS103: use cpu-freq param instead of /cpu_card/core_clk Eugeniy Paltsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503487454.2586.58.camel@synopsys.com \
--to=eugeniy.paltsev-hkixbcoqz3hwk0htik3j/w@public.gmane.org \
--cc=Alexey.Brodkin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).