devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Reid <preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
To: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	jdelvare-IBi9RG/b67k@public.gmane.org,
	jglauber-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
	david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
	peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org,
	preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org,
	benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v11 06/10] i2c: mux: pca954x: Return error if irq_create_mapping fails
Date: Thu, 24 Aug 2017 17:31:06 +0800	[thread overview]
Message-ID: <1503567070-115646-7-git-send-email-preid@electromag.com.au> (raw)
In-Reply-To: <1503567070-115646-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>

irq_create_mapping can return an error, report error to log and return.
Cleanup will occur in the probe function when an error is returned.

Suggested-by: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
Acked-by: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
Signed-off-by: Phil Reid <preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
---
 drivers/i2c/muxes/i2c-mux-pca954x.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
index 5ec5020..fb725de 100644
--- a/drivers/i2c/muxes/i2c-mux-pca954x.c
+++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
@@ -277,6 +277,10 @@ static int pca954x_irq_setup(struct i2c_mux_core *muxc)
 
 	for (c = 0; c < data->chip->nchans; c++) {
 		irq = irq_create_mapping(data->irq, c);
+		if (!irq) {
+			dev_err(&client->dev, "failed irq create map\n");
+			return -EINVAL;
+		}
 		irq_set_chip_data(irq, data);
 		irq_set_chip_and_handler(irq, &pca954x_irq_chip,
 			handle_simple_irq);
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-08-24  9:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24  9:31 [PATCH v11 00/10] Add sbs-manager with smbalert support Phil Reid
2017-08-24  9:31 ` [PATCH v11 01/10] i2c: i2c-smbus: Use threaded irq for smbalert Phil Reid
2017-08-24  9:31 ` [PATCH v11 03/10] i2c: i2c-smbus: add of_i2c_setup_smbus_alert Phil Reid
2017-08-24  9:31 ` [PATCH v11 05/10] i2c: mux: pca954x: call request irq after adding mux segments Phil Reid
2017-08-24  9:31 ` [PATCH v11 07/10] Documentation: Add sbs-manager device tree node documentation Phil Reid
     [not found] ` <1503567070-115646-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-08-24  9:31   ` [PATCH v11 02/10] i2c: i2c-smbus: Move i2c_setup_smbus_alert from i2c-smbus to i2c-core-smbus Phil Reid
     [not found]     ` <1503567070-115646-3-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-10-29 15:44       ` Wolfram Sang
2017-10-30  4:23         ` Phil Reid
     [not found]           ` <1397131b-c22d-9872-dbe0-9b691553cb9e-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-11-06 21:36             ` Wolfram Sang
2017-11-07  1:16               ` Phil Reid
2017-11-07  7:22                 ` Wolfram Sang
2017-11-17 12:15                   ` Phil Reid
2017-08-24  9:31   ` [PATCH v11 04/10] i2c: core: call of_i2c_setup_smbus_alert in i2c_register_adapter Phil Reid
2017-08-24  9:31   ` Phil Reid [this message]
2017-08-24  9:31   ` [PATCH v11 08/10] power: Adds support for Smart Battery System Manager Phil Reid
2017-08-24  9:31 ` [PATCH v11 09/10] power: supply: sbs-manager: Add alert callback and battery change notification Phil Reid
2017-08-24  9:31 ` [PATCH v11 10/10] power: supply: sbs-battery: move gpio present detect to sbs_get_property Phil Reid
2017-09-28  7:38 ` [PATCH v11 00/10] Add sbs-manager with smbalert support Phil Reid
     [not found]   ` <66235a12-a209-be89-5bfd-dc69b769cab9-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-10-28 22:55     ` Wolfram Sang
2017-10-29 14:37       ` Sebastian Reichel
2017-10-29 15:05         ` Wolfram Sang
2017-11-01 22:52       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503567070-115646-7-git-send-email-preid@electromag.com.au \
    --to=preid-qgqnfa1juf/o2in0hyhwsidd74u8msao@public.gmane.org \
    --cc=benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jdelvare-IBi9RG/b67k@public.gmane.org \
    --cc=jglauber-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).