devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH] arm: dts: am33xx: Add spi alias to match SOC schematics
@ 2017-09-11  6:30 sunil.m-fINqtvHxh+hg9hUCZPvPmw
       [not found] ` <1505111416-21594-1-git-send-email-sunil.m-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: sunil.m-fINqtvHxh+hg9hUCZPvPmw @ 2017-09-11  6:30 UTC (permalink / raw)
  To: bcousson-rdvid1DuHRBWk0Htik3J/w, tony-4v6yS6AI5VpBDgjK7y7TUQ,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw
  Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Suniel Mahesh,
	Karthik Tummala

From: Suniel Mahesh <sunil.m-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>

Linux bus numbers should match the numbers defined by the chip
manufacturer. This patch add's spi aliases to acheive that bus
naming convention.

Signed-off-by: Suniel Mahesh <sunil.m-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>
Signed-off-by: Karthik Tummala <karthik-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>
Tested-by: Karthik Tummala <karthik-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>
---
Note:
- Patch was compile tested and built(ARCH=arm) on next-20170911.
- Patch was hardware tested on AM335x (McSPI controller) with
  spi flash chips.
- No build/run-time issues reported.
- At present bus numbers are represented as spi1 and spi2 in sysfs
  instead of spi0 and spi1, as defined in SOC schematics.
- The commit:
"spi: Pick spi bus number from Linux idr or spi alias"
(SHA1:9b61e302210eba55768962f2f11e96bb508c2408)
has introduced bus numbering which happens dynamically either
via Linux IDR or spi alias for master drivers.
- The commit:
"spi: omap: Allocate bus number from spi framework"
(SHA1:b590782afe0a99fca84f451252ed7e2d64b2f155)
is now using spi framework to allocate bus numbers.
---
 arch/arm/boot/dts/am33xx.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 7d7ca05..e58fab8 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -36,6 +36,8 @@
 		phy1 = &usb1_phy;
 		ethernet0 = &cpsw_emac0;
 		ethernet1 = &cpsw_emac1;
+		spi0 = &spi0;
+		spi1 = &spi1;
 	};
 
 	cpus {
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RESEND PATCH] arm: dts: am33xx: Add spi alias to match SOC schematics
       [not found] ` <1505111416-21594-1-git-send-email-sunil.m-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>
@ 2017-09-19 17:53   ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2017-09-19 17:53 UTC (permalink / raw)
  To: sunil.m-fINqtvHxh+hg9hUCZPvPmw
  Cc: bcousson-rdvid1DuHRBWk0Htik3J/w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	mark.rutland-5wv7dgnIgG8, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
	linux-omap-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Karthik Tummala

* sunil.m-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org <sunil.m-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org> [170910 23:31]:
> From: Suniel Mahesh <sunil.m-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>
> 
> Linux bus numbers should match the numbers defined by the chip
> manufacturer. This patch add's spi aliases to acheive that bus
> naming convention.

OK applying into omap-for-v4.14/fixes to follow what we do
already for am4372 and dra7.

Regards,

Tony

> Signed-off-by: Suniel Mahesh <sunil.m-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Karthik Tummala <karthik-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>
> Tested-by: Karthik Tummala <karthik-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>
> ---
> Note:
> - Patch was compile tested and built(ARCH=arm) on next-20170911.
> - Patch was hardware tested on AM335x (McSPI controller) with
>   spi flash chips.
> - No build/run-time issues reported.
> - At present bus numbers are represented as spi1 and spi2 in sysfs
>   instead of spi0 and spi1, as defined in SOC schematics.
> - The commit:
> "spi: Pick spi bus number from Linux idr or spi alias"
> (SHA1:9b61e302210eba55768962f2f11e96bb508c2408)
> has introduced bus numbering which happens dynamically either
> via Linux IDR or spi alias for master drivers.
> - The commit:
> "spi: omap: Allocate bus number from spi framework"
> (SHA1:b590782afe0a99fca84f451252ed7e2d64b2f155)
> is now using spi framework to allocate bus numbers.
> ---
>  arch/arm/boot/dts/am33xx.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 7d7ca05..e58fab8 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -36,6 +36,8 @@
>  		phy1 = &usb1_phy;
>  		ethernet0 = &cpsw_emac0;
>  		ethernet1 = &cpsw_emac1;
> +		spi0 = &spi0;
> +		spi1 = &spi1;
>  	};
>  
>  	cpus {
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-19 17:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-11  6:30 [RESEND PATCH] arm: dts: am33xx: Add spi alias to match SOC schematics sunil.m-fINqtvHxh+hg9hUCZPvPmw
     [not found] ` <1505111416-21594-1-git-send-email-sunil.m-fINqtvHxh+hg9hUCZPvPmw@public.gmane.org>
2017-09-19 17:53   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).