From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH v2] ARC: reset: introduce AXS10x reset driver Date: Mon, 18 Sep 2017 14:07:21 +0200 Message-ID: <1505736441.9807.8.camel@pengutronix.de> References: <20170914142842.12225-1-Eugeniy.Paltsev@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170914142842.12225-1-Eugeniy.Paltsev@synopsys.com> Sender: linux-kernel-owner@vger.kernel.org To: Eugeniy Paltsev Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org On Thu, 2017-09-14 at 17:28 +0300, Eugeniy Paltsev wrote: > ARC AXS10x boards support custom IP-block which allows to control > reset signals of selected peripherals. For example DW GMAC, etc... > This block is controlled via memory-mapped register (AKA CREG) which > represents up-to 32 reset lines. This regiter is self-clearing so we > don't need to deassert line after reset. > > As of today only the following lines are used: >  - DW GMAC - line 5 > > > Signed-off-by: Eugeniy Paltsev > --- > Changes v1 -> v2: >   * The creg reset register is self-clearing so we don't need to clear it >     manually. Fixed it. >   * Use reset callback instead of assert/deassert pair. >   * Rename reset node in documentation to "reset-controller" for consistency >     with the other bindings. >   * Use devm_reset_controller_register instead of reset_controller_register > > NOTE: >     This driver couldn't be replaced by reset-simple driver as we mustn't >     read from reset register or clear it. Thanks, I've applied this patch to the reset/next branch. regards Philipp