* [PATCH 0/2] ARM64: Add Vega S96 board support
@ 2017-09-19 12:05 Neil Armstrong
[not found] ` <1505822748-23431-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Neil Armstrong @ 2017-09-19 12:05 UTC (permalink / raw)
To: khilman-rdvid1DuHRBWk0Htik3J/w, carlo-KA+7E9HrN00dnm+yROfE0A
Cc: Neil Armstrong, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
balbes-150-o+MxOtu4lMCHXe+LvDLADg
This patchset adds support for the Tronsmart Vega S96 TV Box based
on the Q200 Amlogic Reference design.
Neil Armstrong (2):
ARM64: dts: meson-gxm: Add Vega S96 board
dt-bindings: arm: amlogic: Add Tronsmart Vega S96 binding
Documentation/devicetree/bindings/arm/amlogic.txt | 1 +
arch/arm64/boot/dts/amlogic/Makefile | 1 +
arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 ++++++++++++++++++++++
3 files changed, 41 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread[parent not found: <1505822748-23431-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>]
* [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board [not found] ` <1505822748-23431-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2017-09-19 12:05 ` Neil Armstrong [not found] ` <1505822748-23431-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Neil Armstrong @ 2017-09-19 12:05 UTC (permalink / raw) To: khilman-rdvid1DuHRBWk0Htik3J/w, carlo-KA+7E9HrN00dnm+yROfE0A Cc: Neil Armstrong, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, balbes-150-o+MxOtu4lMCHXe+LvDLADg, support-QbXJUBtoW2jby3iVrkZq2A The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design. Cc: support-QbXJUBtoW2jby3iVrkZq2A@public.gmane.org Signed-off-by: Oleg <balbes-150-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> --- arch/arm64/boot/dts/amlogic/Makefile | 1 + arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 ++++++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile index 7a9f48c..a6c4a06 100644 --- a/arch/arm64/boot/dts/amlogic/Makefile +++ b/arch/arm64/boot/dts/amlogic/Makefile @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb always := $(dtb-y) subdir-y := $(dts-dirs) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts new file mode 100644 index 0000000..ba74240 --- /dev/null +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts @@ -0,0 +1,39 @@ +/* + * Copyright (c) 2017 BayLibre, SAS. + * Author: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> + * Copyright (c) 2017 Oleg <balbes-150-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> + * + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) + */ + +/dts-v1/; + +#include "meson-gxm.dtsi" +#include "meson-gx-p23x-q20x.dtsi" + +/ { + compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson-gxm"; + model = "Tronsmart Vega S96"; + +}; + +ðmac { + pinctrl-0 = <ð_pins>; + pinctrl-names = "default"; + + /* Select external PHY by default */ + phy-handle = <&external_phy>; + + amlogic,tx-delay-ns = <2>; + + /* External PHY is in RGMII */ + phy-mode = "rgmii"; +}; + +&external_mdio { + external_phy: ethernet-phy@0 { + compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22"; + reg = <0>; + max-speed = <1000>; + }; +}; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 12+ messages in thread
[parent not found: <1505822748-23431-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board [not found] ` <1505822748-23431-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2017-09-19 15:01 ` Jerome Brunet 2017-09-19 18:12 ` Oleg 2017-09-19 17:51 ` Martin Blumenstingl 1 sibling, 1 reply; 12+ messages in thread From: Jerome Brunet @ 2017-09-19 15:01 UTC (permalink / raw) To: Neil Armstrong, khilman-rdvid1DuHRBWk0Htik3J/w, carlo-KA+7E9HrN00dnm+yROfE0A Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, balbes-150-o+MxOtu4lMCHXe+LvDLADg, support-QbXJUBtoW2jby3iVrkZq2A On Tue, 2017-09-19 at 14:05 +0200, Neil Armstrong wrote: > The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design. > > Cc: support-QbXJUBtoW2jby3iVrkZq2A@public.gmane.org > Signed-off-by: Oleg <balbes-150-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> Does Oleg have a surname ? :) > Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 > ++++++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile > b/arch/arm64/boot/dts/amlogic/Makefile > index 7a9f48c..a6c4a06 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb > > always := $(dtb-y) > subdir-y := $(dts-dirs) > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > new file mode 100644 > index 0000000..ba74240 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > @@ -0,0 +1,39 @@ > +/* > + * Copyright (c) 2017 BayLibre, SAS. > + * Author: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> > + * Copyright (c) 2017 Oleg <balbes-150-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> > + * > + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + */ > + > +/dts-v1/; > + > +#include "meson-gxm.dtsi" > +#include "meson-gx-p23x-q20x.dtsi" > + > +/ { > + compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson- > gxm"; > + model = "Tronsmart Vega S96"; > + > +}; > + > +ðmac { > + pinctrl-0 = <ð_pins>; > + pinctrl-names = "default"; > + > + /* Select external PHY by default */ > + phy-handle = <&external_phy>; > + > + amlogic,tx-delay-ns = <2>; > + > + /* External PHY is in RGMII */ > + phy-mode = "rgmii"; > +}; > + > +&external_mdio { > + external_phy: ethernet-phy@0 { > + compatible = "ethernet-phy-id001c.c916", "ethernet-phy- > ieee802.3-c22"; > + reg = <0>; > + max-speed = <1000>; I don't think this max-speed property is necessary > + }; > +}; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board 2017-09-19 15:01 ` Jerome Brunet @ 2017-09-19 18:12 ` Oleg [not found] ` <a79c801a-c6bc-87d6-34f5-1a52f77704c6-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> 0 siblings, 1 reply; 12+ messages in thread From: Oleg @ 2017-09-19 18:12 UTC (permalink / raw) To: Jerome Brunet, Neil Armstrong, khilman, carlo Cc: devicetree, support, linux-kernel, linux-arm-kernel, linux-amlogic > Does Oleg have a surname ? :) Yes, there is Ivanov :) >> + reg = <0>; >> + max-speed = <1000>; > I don't think this max-speed property is necessary > >> + }; >> +}; I will try to test and write the result. ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <a79c801a-c6bc-87d6-34f5-1a52f77704c6-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org>]
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board [not found] ` <a79c801a-c6bc-87d6-34f5-1a52f77704c6-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> @ 2017-09-20 8:28 ` Neil Armstrong 2017-09-20 10:47 ` Oleg 2017-09-27 12:30 ` Oleg 0 siblings, 2 replies; 12+ messages in thread From: Neil Armstrong @ 2017-09-20 8:28 UTC (permalink / raw) To: Oleg, Jerome Brunet, khilman-rdvid1DuHRBWk0Htik3J/w, carlo-KA+7E9HrN00dnm+yROfE0A Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, support-QbXJUBtoW2jby3iVrkZq2A On 09/19/2017 08:12 PM, Oleg wrote: > > >> Does Oleg have a surname ? :) > Yes, there is Ivanov :) Ok, then can I replace the Signed-off-bys with "Signed-off-by: Oleg Ivanov <balbes-150-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org>" ? > > > >>> + reg = <0>; >>> + max-speed = <1000>; >> I don't think this max-speed property is necessary >> >>> + }; >>> +}; > > I will try to test and write the result. Great, thanks ! Neil -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board 2017-09-20 8:28 ` Neil Armstrong @ 2017-09-20 10:47 ` Oleg 2017-09-27 12:30 ` Oleg 1 sibling, 0 replies; 12+ messages in thread From: Oleg @ 2017-09-20 10:47 UTC (permalink / raw) To: Neil Armstrong, Jerome Brunet, khilman, carlo Cc: devicetree, support, linux-kernel, linux-arm-kernel, linux-amlogic > Ok, then can I replace the Signed-off-bys with "Signed-off-by: Oleg Ivanov <balbes-150@yandex.ru>" ? > Yes, that's right. Thanks for the patch. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board 2017-09-20 8:28 ` Neil Armstrong 2017-09-20 10:47 ` Oleg @ 2017-09-27 12:30 ` Oleg 1 sibling, 0 replies; 12+ messages in thread From: Oleg @ 2017-09-27 12:30 UTC (permalink / raw) To: Neil Armstrong, Jerome Brunet, khilman, carlo Cc: devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, support >>>> + reg = <0>; >>>> + max-speed = <1000>; >>> I don't think this max-speed property is necessary >>> >>>> + }; >>>> +}; >> I will try to test and write the result. > Great, thanks ! > > Neil I removed two strings and checked on Vega s96, the wired network works fine. +&external_mdio { + external_phy: ethernet-phy@0 { + /* Realtek RTL8211F (0x001cc916) */ + reg = <0>; + }; +}; ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board [not found] ` <1505822748-23431-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 2017-09-19 15:01 ` Jerome Brunet @ 2017-09-19 17:51 ` Martin Blumenstingl 2017-09-20 8:36 ` Neil Armstrong 1 sibling, 1 reply; 12+ messages in thread From: Martin Blumenstingl @ 2017-09-19 17:51 UTC (permalink / raw) To: Neil Armstrong Cc: khilman-rdvid1DuHRBWk0Htik3J/w, carlo-KA+7E9HrN00dnm+yROfE0A, devicetree-u79uwXL29TY76Z2rM5mHXA, balbes-150-o+MxOtu4lMCHXe+LvDLADg, support-QbXJUBtoW2jby3iVrkZq2A, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Hi Neil, On Tue, Sep 19, 2017 at 2:05 PM, Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> wrote: > The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design. > > Cc: support-QbXJUBtoW2jby3iVrkZq2A@public.gmane.org > Signed-off-by: Oleg <balbes-150-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> > Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 ++++++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 7a9f48c..a6c4a06 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb > > always := $(dtb-y) > subdir-y := $(dts-dirs) > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > new file mode 100644 > index 0000000..ba74240 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > @@ -0,0 +1,39 @@ > +/* > + * Copyright (c) 2017 BayLibre, SAS. > + * Author: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> > + * Copyright (c) 2017 Oleg <balbes-150-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> > + * > + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + */ > + > +/dts-v1/; > + > +#include "meson-gxm.dtsi" > +#include "meson-gx-p23x-q20x.dtsi" > + > +/ { > + compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson-gxm"; > + model = "Tronsmart Vega S96"; > + > +}; > + > +ðmac { > + pinctrl-0 = <ð_pins>; > + pinctrl-names = "default"; > + > + /* Select external PHY by default */ > + phy-handle = <&external_phy>; > + > + amlogic,tx-delay-ns = <2>; > + > + /* External PHY is in RGMII */ > + phy-mode = "rgmii"; > +}; > + > +&external_mdio { > + external_phy: ethernet-phy@0 { > + compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22"; some time ago I thought it was smart to add a compatible string with the PHY ID. this was until I figured out that it should only be done if the PHY reports an invalid ID: [0] that's why most .dts files that I've touched skip the "compatible" property and use a comment like "/* Realtek RTL8211F (0x001cc916) */" instead > + reg = <0>; > + max-speed = <1000>; > + }; > +}; > -- > 1.9.1 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic Regards, Martin [0] https://github.com/torvalds/linux/commit/7630ea4bda18df2ee1c64dfdca1724a9cc32f920 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board 2017-09-19 17:51 ` Martin Blumenstingl @ 2017-09-20 8:36 ` Neil Armstrong 0 siblings, 0 replies; 12+ messages in thread From: Neil Armstrong @ 2017-09-20 8:36 UTC (permalink / raw) To: Martin Blumenstingl Cc: khilman, carlo, devicetree, balbes-150, support, linux-kernel, linux-amlogic, linux-arm-kernel On 09/19/2017 07:51 PM, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, Sep 19, 2017 at 2:05 PM, Neil Armstrong <narmstrong@baylibre.com> wrote: >> The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design. >> >> Cc: support@tronsmart.com >> Signed-off-by: Oleg <balbes-150@yandex.ru> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> arch/arm64/boot/dts/amlogic/Makefile | 1 + >> arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 ++++++++++++++++++++++ >> 2 files changed, 40 insertions(+) >> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts >> >> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile >> index 7a9f48c..a6c4a06 100644 >> --- a/arch/arm64/boot/dts/amlogic/Makefile >> +++ b/arch/arm64/boot/dts/amlogic/Makefile >> @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb >> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb >> >> always := $(dtb-y) >> subdir-y := $(dts-dirs) >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts >> new file mode 100644 >> index 0000000..ba74240 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts >> @@ -0,0 +1,39 @@ >> +/* >> + * Copyright (c) 2017 BayLibre, SAS. >> + * Author: Neil Armstrong <narmstrong@baylibre.com> >> + * Copyright (c) 2017 Oleg <balbes-150@yandex.ru> >> + * >> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> + */ >> + >> +/dts-v1/; >> + >> +#include "meson-gxm.dtsi" >> +#include "meson-gx-p23x-q20x.dtsi" >> + >> +/ { >> + compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson-gxm"; >> + model = "Tronsmart Vega S96"; >> + >> +}; >> + >> +ðmac { >> + pinctrl-0 = <ð_pins>; >> + pinctrl-names = "default"; >> + >> + /* Select external PHY by default */ >> + phy-handle = <&external_phy>; >> + >> + amlogic,tx-delay-ns = <2>; >> + >> + /* External PHY is in RGMII */ >> + phy-mode = "rgmii"; >> +}; >> + >> +&external_mdio { >> + external_phy: ethernet-phy@0 { >> + compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22"; > some time ago I thought it was smart to add a compatible string with the PHY ID. > this was until I figured out that it should only be done if the PHY > reports an invalid ID: [0] > that's why most .dts files that I've touched skip the "compatible" > property and use a comment like "/* Realtek RTL8211F (0x001cc916) */" > instead Done, thanks ! Neil > >> + reg = <0>; >> + max-speed = <1000>; >> + }; >> +}; >> -- >> 1.9.1 >> >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic > > > Regards, > Martin > > > [0] https://github.com/torvalds/linux/commit/7630ea4bda18df2ee1c64dfdca1724a9cc32f920 > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] dt-bindings: arm: amlogic: Add Tronsmart Vega S96 binding 2017-09-19 12:05 [PATCH 0/2] ARM64: Add Vega S96 board support Neil Armstrong [not found] ` <1505822748-23431-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2017-09-19 12:05 ` Neil Armstrong [not found] ` <1505822748-23431-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 2017-09-19 15:03 ` [PATCH 0/2] ARM64: Add Vega S96 board support Jerome Brunet 2 siblings, 1 reply; 12+ messages in thread From: Neil Armstrong @ 2017-09-19 12:05 UTC (permalink / raw) To: khilman, carlo Cc: Neil Armstrong, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, balbes-150, support Cc: support@tronsmart.com Signed-off-by: Oleg <balbes-150@yandex.ru> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- Documentation/devicetree/bindings/arm/amlogic.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt index 4e4bc0b..d6163ac 100644 --- a/Documentation/devicetree/bindings/arm/amlogic.txt +++ b/Documentation/devicetree/bindings/arm/amlogic.txt @@ -73,6 +73,7 @@ Board compatible values (alphabetically, grouped by SoC): - "amlogic,q201" (Meson gxm s912) - "kingnovel,r-box-pro" (Meson gxm S912) - "nexbox,a1" (Meson gxm s912) + - "tronsmart,vega-s96" (Meson gxm s912) Amlogic Meson Firmware registers Interface ------------------------------------------ -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
[parent not found: <1505822748-23431-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH 2/2] dt-bindings: arm: amlogic: Add Tronsmart Vega S96 binding [not found] ` <1505822748-23431-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2017-09-21 23:41 ` Rob Herring 0 siblings, 0 replies; 12+ messages in thread From: Rob Herring @ 2017-09-21 23:41 UTC (permalink / raw) To: Neil Armstrong Cc: khilman-rdvid1DuHRBWk0Htik3J/w, carlo-KA+7E9HrN00dnm+yROfE0A, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, balbes-150-o+MxOtu4lMCHXe+LvDLADg, support-QbXJUBtoW2jby3iVrkZq2A On Tue, Sep 19, 2017 at 02:05:48PM +0200, Neil Armstrong wrote: > Cc: support-QbXJUBtoW2jby3iVrkZq2A@public.gmane.org > Signed-off-by: Oleg <balbes-150-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> > Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> > --- > Documentation/devicetree/bindings/arm/amlogic.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] ARM64: Add Vega S96 board support 2017-09-19 12:05 [PATCH 0/2] ARM64: Add Vega S96 board support Neil Armstrong [not found] ` <1505822748-23431-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 2017-09-19 12:05 ` [PATCH 2/2] dt-bindings: arm: amlogic: Add Tronsmart Vega S96 binding Neil Armstrong @ 2017-09-19 15:03 ` Jerome Brunet 2 siblings, 0 replies; 12+ messages in thread From: Jerome Brunet @ 2017-09-19 15:03 UTC (permalink / raw) To: Neil Armstrong, khilman, carlo Cc: devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, balbes-150 On Tue, 2017-09-19 at 14:05 +0200, Neil Armstrong wrote: > This patchset adds support for the Tronsmart Vega S96 TV Box based > on the Q200 Amlogic Reference design. > > Neil Armstrong (2): > ARM64: dts: meson-gxm: Add Vega S96 board > dt-bindings: arm: amlogic: Add Tronsmart Vega S96 binding > > Documentation/devicetree/bindings/arm/amlogic.txt | 1 + > arch/arm64/boot/dts/amlogic/Makefile | 1 + > arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 > ++++++++++++++++++++++ > 3 files changed, 41 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > Apart from the 2 comments on patch 1, Series looks good to me With this fixed, feel free to add Acked-by: Jerome Brunet <jbrunet@baylibre.com> ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-09-27 12:30 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-19 12:05 [PATCH 0/2] ARM64: Add Vega S96 board support Neil Armstrong
[not found] ` <1505822748-23431-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-09-19 12:05 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add Vega S96 board Neil Armstrong
[not found] ` <1505822748-23431-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-09-19 15:01 ` Jerome Brunet
2017-09-19 18:12 ` Oleg
[not found] ` <a79c801a-c6bc-87d6-34f5-1a52f77704c6-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org>
2017-09-20 8:28 ` Neil Armstrong
2017-09-20 10:47 ` Oleg
2017-09-27 12:30 ` Oleg
2017-09-19 17:51 ` Martin Blumenstingl
2017-09-20 8:36 ` Neil Armstrong
2017-09-19 12:05 ` [PATCH 2/2] dt-bindings: arm: amlogic: Add Tronsmart Vega S96 binding Neil Armstrong
[not found] ` <1505822748-23431-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-09-21 23:41 ` Rob Herring
2017-09-19 15:03 ` [PATCH 0/2] ARM64: Add Vega S96 board support Jerome Brunet
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).