From: Zhiyong Tao <zhiyong.tao@mediatek.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
hongkun.cao@mediatek.com, srv_heupstream@mediatek.com,
Hongzhou Yang <hongzhou.yang@mediatek.com>,
Biao Huang <biao.huang@mediatek.com>,
Erin Lo <erin.lo@mediatek.com>,
Liguo Zhang <liguo.zhang@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
YT Shen <yt.shen@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Joe.C" <yingjoe.chen@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] arm64: dts: mt2712: add pintcrl device node.
Date: Thu, 21 Sep 2017 16:13:12 +0800 [thread overview]
Message-ID: <1505981592.22452.7.camel@mhfsdcap03> (raw)
In-Reply-To: <CACRpkdZHyXec+L8ueRHOs=9TLT1Arqe3KeQpRZ6D0K1Ag1c+Zw@mail.gmail.com>
On Tue, 2017-08-22 at 15:04 +0200, Linus Walleij wrote:
> On Mon, Aug 14, 2017 at 5:23 PM, Matthias Brugger
> <matthias.bgg@gmail.com> wrote:
> > On 07/31/2017 10:22 AM, Zhiyong Tao wrote:
> >>
> >> The commit includes two change:
> >> 1)add pintcrl device node for mt2712.
> >> 2)add pinfunc file for mt2712.
> >>
> >> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> >> ---
> >> arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h | 1014
> >> +++++++++++++++++++++++++
> >
> >
> > Shouldn't this file be in include/dt-bindings/pinctrl?
>
> Only if it is also #included in the driver.
>
> Yours,
> Linus Walleij
==>
Thanks for your comment.
We see our some ICs(mt7623) which move the file to
"include/dt-bindings/pinctrl". other ICs(mt2701) which is put in
"arch/arm64/boot/dts/mediatek".
In mt2712, mt2712-pinfunc.h is only include by dts file. It won't be
included by driver. So which is better? "arch/arm64/boot/dts/mediatek/"
or "include/dt-bindings/pinctrl".
Thanks.
next prev parent reply other threads:[~2017-09-21 8:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 8:22 [PATCH 0/3] PINCTRL: Mediatek pinctrl driver for mt2712 Zhiyong Tao
2017-07-31 8:22 ` [PATCH 1/3] dt-bindings: pinctrl: mt2712: add binding document Zhiyong Tao
2017-08-03 23:40 ` Rob Herring
[not found] ` <1501489333-23145-2-git-send-email-zhiyong.tao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-07 12:07 ` Linus Walleij
2017-07-31 8:22 ` [PATCH 2/3] arm64: dts: mt2712: add pintcrl device node Zhiyong Tao
[not found] ` <1501489333-23145-3-git-send-email-zhiyong.tao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-07 12:09 ` Linus Walleij
2017-08-14 15:23 ` Matthias Brugger
2017-08-22 13:04 ` Linus Walleij
2017-09-21 8:13 ` Zhiyong Tao [this message]
2017-09-21 12:17 ` Linus Walleij
2017-09-22 1:31 ` Zhiyong Tao
2017-07-31 8:22 ` [PATCH 3/3] pinctrl: add mt2712 pinctrl driver Zhiyong Tao
2017-08-01 9:14 ` Yingjoe Chen
2017-08-02 6:03 ` Zhiyong Tao
2017-08-03 2:00 ` Yingjoe Chen
2017-09-21 8:49 ` Zhiyong Tao
[not found] ` <1501489333-23145-1-git-send-email-zhiyong.tao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-01 8:44 ` [PATCH 0/3] PINCTRL: Mediatek pinctrl driver for mt2712 Yingjoe Chen
2017-08-02 2:58 ` Zhiyong Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505981592.22452.7.camel@mhfsdcap03 \
--to=zhiyong.tao@mediatek.com \
--cc=biao.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=erin.lo@mediatek.com \
--cc=hongkun.cao@mediatek.com \
--cc=hongzhou.yang@mediatek.com \
--cc=liguo.zhang@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox