* [PATCH] Documentation: DT bindings: Add chip compatible string for audio codec.
@ 2017-09-23 18:15 Shreeya Patel
2017-09-25 15:57 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Shreeya Patel @ 2017-09-23 18:15 UTC (permalink / raw)
To: lgirdwood, broonie, robh+dt, mark.rutland, baohua, alsa-devel,
devicetree, linux-arm-kernel, linux-kernel, gregkh,
outreachy-kernel
Cc: Shreeya Patel
This patch adds chip compatible string to remove the warnings
generated by checkpatch that -DT compatible string
"toshiba,apb-dummy-codec" appears un-documented.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
---
Documentation/devicetree/bindings/sound/sirf-audio-codec.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt b/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
index 062f5ec..a61560b 100644
--- a/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
+++ b/Documentation/devicetree/bindings/sound/sirf-audio-codec.txt
@@ -3,6 +3,7 @@ SiRF internal audio CODEC
Required properties:
- compatible : "sirf,atlas6-audio-codec" or "sirf,prima2-audio-codec"
+ "toshiba,apb-dummy-codec"
- reg : the register address of the device.
@@ -11,7 +12,7 @@ Required properties:
Example:
audiocodec: audiocodec@b0040000 {
- compatible = "sirf,atlas6-audio-codec";
+ compatible = "sirf,atlas6-audio-codec", "toshiba,apb-dummy-codec";
reg = <0xb0040000 0x10000>;
clocks = <&clks 27>;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Documentation: DT bindings: Add chip compatible string for audio codec.
2017-09-23 18:15 [PATCH] Documentation: DT bindings: Add chip compatible string for audio codec Shreeya Patel
@ 2017-09-25 15:57 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2017-09-25 15:57 UTC (permalink / raw)
To: Shreeya Patel
Cc: lgirdwood, robh+dt, mark.rutland, baohua, alsa-devel, devicetree,
linux-arm-kernel, linux-kernel, gregkh, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Sat, Sep 23, 2017 at 11:45:23PM +0530, Shreeya Patel wrote:
> This patch adds chip compatible string to remove the warnings
> generated by checkpatch that -DT compatible string
> "toshiba,apb-dummy-codec" appears un-documented.
What is this device and why does it make sense to be covered with this
compatible string? The -dummy-codec makes it seem like something that
has no place in a DT at all.
Please use subject lines matching the style for the subsystem. This
makes it easier for people to identify relevant patches.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-25 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-23 18:15 [PATCH] Documentation: DT bindings: Add chip compatible string for audio codec Shreeya Patel
2017-09-25 15:57 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).