devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	devicetree@vger.kernel.org, Erin Lo <erin.lo@mediatek.com>,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto nodes
Date: Tue, 26 Sep 2017 18:17:05 +0800	[thread overview]
Message-ID: <1506421025.5626.6.camel@mtksdaap41> (raw)
In-Reply-To: <93734b87262a8305b67e989777dfa1297d66cee4.1506390597.git.ryder.lee@mediatek.com>

On Tue, 2017-09-26 at 10:02 +0800, Ryder Lee wrote:
> This patch updates pio, usb and crypto nodes to make them be consistent
> with the binding documents.
> 
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
>  arch/arm/boot/dts/mt7623.dtsi | 52 ++++++++++++++++++++++---------------------
>  1 file changed, 27 insertions(+), 25 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
> index 381843e..9ec3767 100644
> --- a/arch/arm/boot/dts/mt7623.dtsi
> +++ b/arch/arm/boot/dts/mt7623.dtsi
> @@ -226,21 +226,6 @@
>  		#reset-cells = <1>;
>  	};
>  
> -	pio: pinctrl@10005000 {
> -		compatible = "mediatek,mt7623-pinctrl",
> -			     "mediatek,mt2701-pinctrl";
> -		reg = <0 0x1000b000 0 0x1000>;
> -		mediatek,pctl-regmap = <&syscfg_pctl_a>;
> -		pins-are-numbered;
> -		gpio-controller;
> -		#gpio-cells = <2>;
> -		interrupt-controller;
> -		interrupt-parent = <&gic>;
> -		#interrupt-cells = <2>;
> -		interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>,
> -			     <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;
> -	};
> -
>  	syscfg_pctl_a: syscfg@10005000 {
>  		compatible = "mediatek,mt7623-pctl-a-syscfg", "syscon";
>  		reg = <0 0x10005000 0 0x1000>;


Hi Ryder,

pio node is special, it have 2 registers space.
The address 10005000 is for PIO, it was accesed through syscfg_pctl_a
regmap. The other one, 0x1000b000, is for EINT.

So,I think using address @10005000 is correct.

Joe.C

  reply	other threads:[~2017-09-26 10:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26  2:02 [PATCH v2 00/10] update MT7623 and MT2701 dts Ryder Lee
2017-09-26  2:02 ` [PATCH v2 03/10] arm: dts: mt2701: add display subsystem related nodes Ryder Lee
2017-09-26  2:02 ` [PATCH v2 04/10] arm: dts: mediatek: update audio node for mt2701 and mt7623 Ryder Lee
     [not found] ` <cover.1506390597.git.ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-09-26  2:02   ` [PATCH v2 01/10] arm: dts: mt2701: add pwm backlight device node Ryder Lee
2017-09-26  2:02   ` [PATCH v2 02/10] arm: dts: mt2701: enable display pwm backlight Ryder Lee
2017-09-26  2:02   ` [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto nodes Ryder Lee
2017-09-26 10:17     ` Yingjoe Chen [this message]
2017-09-27  3:22       ` Ryder Lee
2017-09-26  2:02   ` [PATCH v2 06/10] arm: dts: mt7623: add subsystem clock controller nodes Ryder Lee
2017-09-26  2:02 ` [PATCH v2 07/10] arm: dts: mt7623: add iommmu and jpecdec nodes Ryder Lee
2017-09-26  2:02 ` [PATCH v2 08/10] arm: dts: mt7623: add display subsystem related nodes Ryder Lee
2017-09-26  2:03 ` [PATCH v2 09/10] arm: dts: mt7623: enable bananapi-r2 display function Ryder Lee
2017-09-26  2:03 ` [PATCH v2 10/10] arm: dts: mt7623: add PCIe related nodes Ryder Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506421025.5626.6.camel@mtksdaap41 \
    --to=yingjoe.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=erin.lo@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=ryder.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).