[PATCH] dt-bindings: fsl-imx-drm: Remove incorrect "@di0" usage

[PATCH] dt-bindings: fsl-imx-drm: Remove incorrect "@di0" usage

[Marco Franchi]

Improve the binding example by removing the '@di0' notation, which
fixes the following build warning:

Warning (unit_address_vs_reg): Node /display@di0 has a unit name, but 
no reg property

Signed-off-by: Marco Franchi <marco.franchi-3arQi8VN3Tc@public.gmane.org>
---
 Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt b/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
index f798547..44814f0 100644
--- a/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
+++ b/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
@@ -129,7 +129,7 @@ Optional properties:
 
 example:
 
-display@di0 {
+display-di0 {
 	compatible = "fsl,imx-parallel-display";
 	edid = [edid-data];
 	interface-pix-fmt = "rgb24";
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: fsl-imx-drm: Remove incorrect "@di0" usage

[Philipp Zabel]

Hi Marco,

On Fri, 2017-09-22 at 15:05 -0300, Marco Franchi wrote:
> Improve the binding example by removing the '@di0' notation, which
> fixes the following build warning:
> 
> Warning (unit_address_vs_reg): Node /display@di0 has a unit name, but 
> no reg property
> 
> Signed-off-by: Marco Franchi <marco.franchi-3arQi8VN3Tc@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl-imx-
> drm.txt b/Documentation/devicetree/bindings/display/imx/fsl-imx-
> drm.txt
> index f798547..44814f0 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
> +++ b/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
> @@ -129,7 +129,7 @@ Optional properties:
>  
>  example:
>  
> -display@di0 {
> +display-di0 {
>  	compatible = "fsl,imx-parallel-display";
>  	edid = [edid-data];
>  	interface-pix-fmt = "rgb24";

Thank you for the patch. We certainly should get rid of the @di0
notation. Since these nodes mostly describe the DISP0 and DISP1 pin
groups controlled by the IOMUXC, I'd prefer to rename this to

-display@di0 {
+disp0 {

instead, if that is fine with you.

I'd also like to move the disp0/disp1 nodes into the SoC dtsi files to
avoid having to duplicate port@0 all over the place.

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: fsl-imx-drm: Remove incorrect "@di0" usage

[Marco Frank]

[-- Attachment #1.1: Type: text/plain, Size: 1669 bytes --]

Hi Philipp,

2017-10-02 9:27 GMT-03:00 Philipp Zabel <p.zabel@pengutronix.de>:

> Hi Marco,
>
> On Fri, 2017-09-22 at 15:05 -0300, Marco Franchi wrote:
> > Improve the binding example by removing the '@di0' notation, which
> > fixes the following build warning:
> >
> > Warning (unit_address_vs_reg): Node /display@di0 has a unit name, but
> > no reg property
> >
> > Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/imx/fsl-imx-
> > drm.txt b/Documentation/devicetree/bindings/display/imx/fsl-imx-
> > drm.txt
> > index f798547..44814f0 100644
> > --- a/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
> > +++ b/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
> > @@ -129,7 +129,7 @@ Optional properties:
> >
> >  example:
> >
> > -display@di0 {
> > +display-di0 {
> >       compatible = "fsl,imx-parallel-display";
> >       edid = [edid-data];
> >       interface-pix-fmt = "rgb24";
>
> Thank you for the patch. We certainly should get rid of the @di0
> notation. Since these nodes mostly describe the DISP0 and DISP1 pin
> groups controlled by the IOMUXC, I'd prefer to rename this to
>
> -display@di0 {
> +disp0 {
>
> instead, if that is fine with you.
>
Its sounds good to me. Can you change this or do you prefer I send a v2?

>
> I'd also like to move the disp0/disp1 nodes into the SoC dtsi files to
> avoid having to duplicate port@0 all over the place.
>
I agree and I can help with this too.

>
> regards
> Philipp
>
Best

Marco

[-- Attachment #1.2: Type: text/html, Size: 2719 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel