From: Andrew Jeffery <andrew@aj.id.au>
To: Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: "Russell King" <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Rick Altherr" <raltherr@google.com>,
"Brendan Higgins" <brendanhiggins@google.com>,
"Cédric Le Goater" <clg@kaod.org>,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH 1/8] ARM: dts: aspeed: Move pinctrl subnodes to improve readability
Date: Wed, 04 Oct 2017 14:00:22 +1030 [thread overview]
Message-ID: <1507087822.5452.1.camel@aj.id.au> (raw)
In-Reply-To: <20170928075149.8154-2-joel@jms.id.au>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Thu, 2017-09-28 at 17:21 +0930, Joel Stanley wrote:
> > From: Andrew Jeffery <andrew@aj.id.au>
>
> Moving the subnodes out of the pinctrl node declaration to a reference
> allows easier access to the remaining parts of the devicetree.
>
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > Reviewed-by: Xo Wang <xow@google.com>
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-g4.dtsi | 1483 ++++++++++++++++++------------------
> arch/arm/boot/dts/aspeed-g5.dtsi | 1549 +++++++++++++++++++-------------------
> 2 files changed, 1518 insertions(+), 1514 deletions(-)
I hate the way the diff came out for the g5, it's almost impossible to
read. Also not sure how useful it is to ack my own patch, but given the
rebasing it has suffered:
Acked-by: Andrew Jeffery <andrew@aj.id.au>
Cheers,
Andrew
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-10-04 3:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 7:51 [PATCH 0/8] ARM: dts: aspeed: Device tree updates Joel Stanley
2017-09-28 7:51 ` [PATCH 1/8] ARM: dts: aspeed: Move pinctrl subnodes to improve readability Joel Stanley
2017-10-04 3:30 ` Andrew Jeffery [this message]
2017-09-28 7:51 ` [PATCH 2/8] ARM: dts: aspeed: Reorder ADC node Joel Stanley
[not found] ` <20170928075149.8154-3-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-10-04 3:35 ` Andrew Jeffery
2017-10-04 5:13 ` Joel Stanley
[not found] ` <CACPK8XfENyKdcV1ZgPrf-Kv+H5BsyQcaCX9ha_gNgD3gcuBUwg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-04 5:21 ` Andrew Jeffery
2017-09-28 7:51 ` [PATCH 3/8] ARM: dts: aspeed: Add I2C buses Joel Stanley
2017-09-28 18:35 ` Brendan Higgins
[not found] ` <CAFd5g46LrdCkPq-dZyrA3Nnw28=r-sCsPvp5bWngYUF=3RmDYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-04 4:36 ` Andrew Jeffery
[not found] ` <20170928075149.8154-4-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-10-04 4:41 ` Andrew Jeffery
[not found] ` <20170928075149.8154-1-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-09-28 7:51 ` [PATCH 4/8] ARM: dts: aspeed-romulus: Add I2C devices Joel Stanley
[not found] ` <20170928075149.8154-5-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-09-28 18:36 ` Brendan Higgins
2017-10-04 5:02 ` Andrew Jeffery
[not found] ` <1507093339.5452.13.camel-zrmu5oMJ5Fs@public.gmane.org>
2017-10-04 5:24 ` Joel Stanley
2017-09-28 7:51 ` [PATCH 5/8] ARM: dts: aspeed-palmetto: " Joel Stanley
2017-09-28 18:36 ` Brendan Higgins
[not found] ` <20170928075149.8154-6-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-10-04 5:08 ` Andrew Jeffery
2017-09-28 7:51 ` [PATCH 6/8] ARM: dts: aspeed-ast2500: " Joel Stanley
[not found] ` <20170928075149.8154-7-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-09-28 18:37 ` Brendan Higgins
2017-10-04 5:12 ` Andrew Jeffery
2017-09-28 7:51 ` [PATCH 7/8] ARM: dts: aspeed: Add aliases for UARTs Joel Stanley
[not found] ` <20170928075149.8154-8-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-10-04 5:13 ` Andrew Jeffery
2017-09-28 7:51 ` [PATCH 8/8] ARM: dts: aspeed: Clean up UART nodes Joel Stanley
[not found] ` <20170928075149.8154-9-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2017-10-04 5:28 ` Andrew Jeffery
[not found] ` <1507094931.5452.20.camel-zrmu5oMJ5Fs@public.gmane.org>
2017-10-04 6:00 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507087822.5452.1.camel@aj.id.au \
--to=andrew@aj.id.au \
--cc=brendanhiggins@google.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=raltherr@google.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).