From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chaotian Jing Subject: Re: [PATCH v3 01/12] mmc: mediatek: add support of mt2701/mt2712 Date: Tue, 10 Oct 2017 15:35:51 +0800 Message-ID: <1507620951.19789.7.camel@mhfsdcap03> References: <1507604480-23246-1-git-send-email-chaotian.jing@mediatek.com> <1507604480-23246-2-git-send-email-chaotian.jing@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ulf Hansson Cc: Rob Herring , Mark Rutland , Matthias Brugger , Catalin Marinas , Will Deacon , yong mao , Linus Walleij , Heiner Kallweit , Phong LE , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , srv_heupstream List-Id: devicetree@vger.kernel.org On Tue, 2017-10-10 at 09:26 +0200, Ulf Hansson wrote: > [...] > > > + > > +static const struct of_device_id msdc_of_ids[] = { > > + { .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat}, > > + { .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat}, > > + { .compatible = "mediatek,mt2701-mmc", .data = &mt2701_compat}, > > + { .compatible = "mediatek,mt2712-mmc", .data = &mt2712_compat}, > > + {} > > +}; > > +MODULE_DEVICE_TABLE(of, msdc_of_ids); > > As already stated in the other reply. These new compatible changes > needs to be discussed and acked before the driver starts using them. > > In other words, make patch3 to precede this one. but, then there will have a probe issue as mentioned in previous mail list. that's why I separate the binding file changes to 2 patches. > > [...] > > Kind regards > Uffe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html