From: Chaotian Jing <chaotian.jing-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
yong mao <yong.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Heiner Kallweit
<hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Phong LE <ple-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
srv_heupstream
<srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v3 01/12] mmc: mediatek: add support of mt2701/mt2712
Date: Tue, 10 Oct 2017 16:22:28 +0800 [thread overview]
Message-ID: <1507623748.19789.10.camel@mhfsdcap03> (raw)
In-Reply-To: <CAPDyKFppTCdaMizSGTjrfgsbMuHCsNi+knHVf9ibxgrAQ0GD2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, 2017-10-10 at 10:09 +0200, Ulf Hansson wrote:
> On 10 October 2017 at 09:35, Chaotian Jing <chaotian.jing-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
> > On Tue, 2017-10-10 at 09:26 +0200, Ulf Hansson wrote:
> >> [...]
> >>
> >> > +
> >> > +static const struct of_device_id msdc_of_ids[] = {
> >> > + { .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat},
> >> > + { .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat},
> >> > + { .compatible = "mediatek,mt2701-mmc", .data = &mt2701_compat},
> >> > + { .compatible = "mediatek,mt2712-mmc", .data = &mt2712_compat},
> >> > + {}
> >> > +};
> >> > +MODULE_DEVICE_TABLE(of, msdc_of_ids);
> >>
> >> As already stated in the other reply. These new compatible changes
> >> needs to be discussed and acked before the driver starts using them.
> >>
> >> In other words, make patch3 to precede this one.
> > but, then there will have a probe issue as mentioned in previous mail
> > list. that's why I separate the binding file changes to 2 patches.
>
> That sounds seriously wrong. Aren't the bindings backwards compatible?
>
> Kind regards
> Uffe
As Matthias mentioned before:
"
>> NAK, this has to be:
>> You have to add the fallback compatible ("mediatek,mt8135-mmc") to
the binding
>> description as otherwise the driver does not get probed.
>>
>> Regards,
>> Matthias
"
the original compatible in driver is "mediatek,mt8135-mmc", so that if
drop "mediatek,mt8135-mmc" in bindings file(User may refer it and drop
"mediatek,mt8135-mmc" in their DTS), the driver will not get probed.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-10 8:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 3:01 [PATCH v3 00/13] mmc: mediatek: add support of mt2701/mt2712 Chaotian Jing
2017-10-10 3:01 ` [PATCH v3 01/12] " Chaotian Jing
2017-10-10 7:26 ` Ulf Hansson
[not found] ` <CAPDyKFrqv5tt8Exq1msUBbMEROam2c+YnStazsf5SPj-NLrGSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-10 7:35 ` Chaotian Jing
2017-10-10 8:09 ` Ulf Hansson
[not found] ` <CAPDyKFppTCdaMizSGTjrfgsbMuHCsNi+knHVf9ibxgrAQ0GD2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-10 8:22 ` Chaotian Jing [this message]
2017-10-10 8:32 ` Matthias Brugger
2017-10-10 8:50 ` Chaotian Jing
2017-10-10 3:01 ` [PATCH v3 03/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes Chaotian Jing
2017-10-10 3:01 ` [PATCH v3 04/12] mmc: mediatek: make hs400_tune_response only for mt8173 Chaotian Jing
2017-10-10 8:33 ` Matthias Brugger
2017-10-10 3:01 ` [PATCH v3 05/12] mmc: mediatek: add pad_tune0 support Chaotian Jing
2017-10-10 3:01 ` [PATCH v3 06/12] mmc: mediatek: add async fifo and data tune support Chaotian Jing
[not found] ` <1507604480-23246-1-git-send-email-chaotian.jing-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-10 3:01 ` [PATCH v3 02/12] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings Chaotian Jing
2017-10-10 3:01 ` [PATCH v3 07/12] mmc: mediatek: add busy_check support Chaotian Jing
2017-10-10 3:01 ` [PATCH v3 10/12] mmc: mediatek: add latch-ck support Chaotian Jing
2017-10-10 3:01 ` [PATCH v3 08/12] mmc: mediatek: add stop_clk fix and enhance_rx support Chaotian Jing
2017-10-10 3:01 ` [PATCH v3 09/12] mmc: mediatek: add support of source_cg clock Chaotian Jing
2017-10-10 3:01 ` [PATCH v3 11/12] mmc: mediatek: improve eMMC hs400 mode read performance Chaotian Jing
2017-10-10 3:01 ` [PATCH v3 12/12] mmc: mediatek: perfer to use rise edge latching for cmd line Chaotian Jing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507623748.19789.10.camel@mhfsdcap03 \
--to=chaotian.jing-nus5lvnupcjwk0htik3j/w@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ple-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
--cc=yong.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).