From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Fabio Estevam <fabio.estevam@nxp.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: "Lothar Waßmann" <LW@KARO-electronics.de>
Subject: [PATCHv3 05/12] ARM: dts: imx6-tx6: improve ethernet related pinctrl setup
Date: Tue, 17 Oct 2017 11:17:56 +0200 [thread overview]
Message-ID: <1508231883-12067-6-git-send-email-LW@KARO-electronics.de> (raw)
In-Reply-To: <1508231883-12067-1-git-send-email-LW@KARO-electronics.de>
Remove the PHY INT and RESET pins from hog section and put them into
their own pinctrl nodes referenced by the appropriate driver nodes.
Also, the MDIO pins are required for probing the Ethernet PHY, so they
must be configured by the FEC driver, not by the PHY driver. Move the
corresponding pinctrl settings from the PHY subnode to the FEC node.
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
index a50bf71..f2cd3e7 100644
--- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
@@ -1,5 +1,5 @@
/*
- * Copyright 2014-2016 Lothar Waßmann <LW@KARO-electronics.de>
+ * Copyright 2014-2017 Lothar Waßmann <LW@KARO-electronics.de>
*
* This file is dual-licensed: you can use it either under the terms
* of the GPL or the X11 license, at your option. Note that this dual
@@ -241,7 +241,7 @@
&fec {
pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_enet>;
+ pinctrl-0 = <&pinctrl_enet &pinctrl_enet_mdio &pinctrl_etnphy_rst>;
clocks = <&clks IMX6QDL_CLK_ENET>,
<&clks IMX6QDL_CLK_ENET>,
<&clks IMX6QDL_CLK_ENET_REF>,
@@ -261,8 +261,9 @@
compatible = "ethernet-phy-ieee802.3-c22";
reg = <0>;
pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_enet_mdio>;
- interrupts-extended = <&gpio7 1 IRQ_TYPE_EDGE_FALLING>;
+ pinctrl-0 = <&pinctrl_etnphy_int>;
+ interrupt-parent = <&gpio7>;
+ interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
};
};
};
@@ -334,8 +335,6 @@
pinctrl_hog: hoggrp {
fsl,pins = <
- MX6QDL_PAD_SD3_DAT2__GPIO7_IO06 0x1b0b1 /* ETN PHY RESET */
- MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x1b0b1 /* ETN PHY INT */
MX6QDL_PAD_EIM_A25__GPIO5_IO02 0x1b0b1 /* PWR BTN */
>;
};
@@ -453,12 +452,24 @@
>;
};
+ pinctrl_etnphy_int: etnphy-intgrp {
+ fsl,pins = <
+ MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x1b0b1 /* ETN PHY INT */
+ >;
+ };
+
pinctrl_etnphy_power: etnphy-pwrgrp {
fsl,pins = <
MX6QDL_PAD_EIM_D20__GPIO3_IO20 0x1b0b1 /* ETN PHY POWER */
>;
};
+ pinctrl_etnphy_rst: etnphy-rstgrp {
+ fsl,pins = <
+ MX6QDL_PAD_SD3_DAT2__GPIO7_IO06 0x1b0b1 /* ETN PHY RESET */
+ >;
+ };
+
pinctrl_flexcan1: flexcan1grp {
fsl,pins = <
MX6QDL_PAD_GPIO_7__FLEXCAN1_TX 0x1b0b0
--
2.1.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-10-17 9:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 8:53 [PATCHv2 00/12] ARM: dts: imx6: Update dts files for the Ka-Ro TX6 module series Lothar Waßmann
2017-10-17 8:53 ` [PATCH 01/12] ARM: dts: imx6-tx6: update model property to match current module HW revision Lothar Waßmann
2017-10-17 8:53 ` [PATCH 02/12] ARM: dts: imx6-tx6: remove obsolete eeti,egalax_ts Lothar Waßmann
2017-10-17 8:53 ` [PATCH 03/12] ARM: dts: imx6-tx6: remove obsolete ipu1 alias Lothar Waßmann
[not found] ` <1508230414-8090-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2017-10-17 8:53 ` [PATCH 04/12] ARM: dts: imx6-tx6: add trickle-charge config for DS1339 Lothar Waßmann
2017-10-17 8:53 ` [PATCH 09/12] ARM: dts: imx6-tx6: move display configuration to .dtsi file Lothar Waßmann
2017-10-17 8:53 ` [PATCH 05/12] ARM: dts: imx6-tx6: improve ethernet related pinctrl setup Lothar Waßmann
2017-10-17 8:53 ` [PATCH 06/12] ARM: dts: imx6-tx6: specify ethernet phy reset post-delay Lothar Waßmann
2017-10-17 8:53 ` [PATCH 07/12] ARM: dts: imx6-tx6: convert to using simple-audio-card Lothar Waßmann
2017-10-17 8:53 ` [PATCH 08/12] ARM: dts: imx6-tx6: add support for I2C bus recovery Lothar Waßmann
2017-10-17 8:53 ` [PATCH 10/12] ARM: dts: imx6-tx6: add a .dtsi file for the MB7 baseboard Lothar Waßmann
2017-10-17 8:53 ` [PATCH 11/12] ARM: dts: imx: add support for TX6QP Lothar Waßmann
2017-10-17 8:53 ` [PATCH 12/12] ARM: dts: imx: add support for TX6 modules on MB7 baseboard Lothar Waßmann
2017-10-17 9:17 ` [PATCHv3 00/12] ARM: dts: imx6: Update dts files for the Ka-Ro TX6 module series Lothar Waßmann
2017-10-17 9:17 ` [PATCHv3 01/12] ARM: dts: imx6-tx6: update model property to match current module HW revision Lothar Waßmann
2017-10-17 9:17 ` [PATCHv3 02/12] ARM: dts: imx6-tx6: remove obsolete eeti,egalax_ts Lothar Waßmann
2017-10-17 9:17 ` [PATCHv3 03/12] ARM: dts: imx6-tx6: remove obsolete ipu1 alias Lothar Waßmann
2017-10-17 9:17 ` [PATCHv3 04/12] ARM: dts: imx6-tx6: add trickle-charge config for DS1339 Lothar Waßmann
2017-10-17 9:17 ` Lothar Waßmann [this message]
2017-10-17 9:17 ` [PATCHv3 06/12] ARM: dts: imx6-tx6: specify ethernet phy reset post-delay Lothar Waßmann
2017-10-17 9:17 ` [PATCHv3 08/12] ARM: dts: imx6-tx6: add support for I2C bus recovery Lothar Waßmann
2017-10-17 9:18 ` [PATCHv3 10/12] ARM: dts: imx6-tx6: add a .dtsi file for the MB7 baseboard Lothar Waßmann
2017-10-17 9:18 ` [PATCHv3 11/12] ARM: dts: imx: add support for TX6QP Lothar Waßmann
2017-10-17 9:18 ` [PATCHv3 12/12] ARM: dts: imx: add support for TX6 modules on MB7 baseboard Lothar Waßmann
[not found] ` <1508231883-12067-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2017-10-17 9:17 ` [PATCHv3 07/12] ARM: dts: imx6-tx6: convert to using simple-audio-card Lothar Waßmann
2017-10-17 9:18 ` [PATCHv3 09/12] ARM: dts: imx6-tx6: move display configuration to .dtsi file Lothar Waßmann
2017-10-18 3:06 ` [PATCHv3 00/12] ARM: dts: imx6: Update dts files for the Ka-Ro TX6 module series Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508231883-12067-6-git-send-email-LW@KARO-electronics.de \
--to=lw@karo-electronics.de \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).