From: Lucas Stach <l.stach@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: devicetree@vger.kernel.org, kernel@pengutronix.de,
dri-devel@lists.freedesktop.org, patchwork-lst@pengutronix.de
Subject: Re: [PATCH v2] drm: panel: simple: add Toshiba LT089AC19000
Date: Thu, 19 Oct 2017 10:27:19 +0200 [thread overview]
Message-ID: <1508401639.11773.5.camel@pengutronix.de> (raw)
In-Reply-To: <20171019081757.GB4459@ulmo>
Am Donnerstag, den 19.10.2017, 10:17 +0200 schrieb Thierry Reding:
> On Wed, Oct 18, 2017 at 07:22:40PM +0200, Lucas Stach wrote:
> > Only exposes a single mode and not a complete display timing, as
> > the datasheet is rather vague about the minimum/maximum values.
> >
> > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> > v2:
> > - fix display size in documentation
> > - add bus flags
> > ---
> > .../display/panel/toshiba,lt089ac29000.txt | 8 +++++++
> > drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++
> > 2 files changed, 35 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/panel/toshiba,lt089ac29000.txt
>
> Separate patches are preferred for bindings and driver.
This is news to me. At least in simple-panel land, I've always only
split out additions of new vendor prefixes and kept the bindings
together with the driver.
I'll change that in the future if you prefer otherwise.
> Also, please try
> to stick to the "drm/panel: " prefix for panel patches (and "drm/panel:
> simple: " for panel-simple), which makes it easier for me to spot these
> patches in patchwork.
Yeah, sorry about that.
> Both of the above aren't blockers, so applied to drm-misc-next.
Thanks,
Lucas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-10-19 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 17:22 [PATCH v2] drm: panel: simple: add Toshiba LT089AC19000 Lucas Stach
[not found] ` <20171018172240.8772-1-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-10-19 8:17 ` Thierry Reding
2017-10-19 8:27 ` Lucas Stach [this message]
2017-10-19 8:32 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508401639.11773.5.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=patchwork-lst@pengutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).