From: Ryder Lee <ryder.lee@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: ulrich.hecht+renesas@gmail.com,
laurent.pinchart@ideasonboard.com, ck.hu@mediatek.com,
p.zabel@pengutronix.de, airlied@linux.ie, robh+dt@kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
Matthias Brugger <mbrugger@suse.com>,
catalin.marinas@arm.com, will.deacon@arm.com,
linux@armlinux.org.uk, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC resend 1/4] dt-bindings: display: mediatek: add drm binding
Date: Thu, 19 Oct 2017 20:19:26 +0800 [thread overview]
Message-ID: <1508415566.5287.10.camel@mtkswgap22> (raw)
In-Reply-To: <20171019112610.13645-2-mbrugger@suse.com>
Hi Matthias,
Should I base on your changes and resend this patch series
https://patchwork.kernel.org/patch/9980061/ ?
I add a similar node - display_components, but your approach is better
than mine.
Thanks.
On Thu, 2017-10-19 at 13:26 +0200, Matthias Brugger wrote:
> DRM subysystem and clock driver shared the same compatible mmsys.
> This stopped does not work, as only the first driver for a compatible
> gets probed. We change the comaptible to the new DRM identifier to fix
> this.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index 383183a89164..6db652463e64 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -27,6 +27,7 @@ Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt.
>
> Required properties (all function blocks):
> - compatible: "mediatek,<chip>-disp-<function>", one of
> + "mediatek,<chip>-dispsys" - central component for the DRM system
> "mediatek,<chip>-disp-ovl" - overlay (4 layers, blending, csc)
> "mediatek,<chip>-disp-rdma" - read DMA / line buffer
> "mediatek,<chip>-disp-wdma" - write DMA
> @@ -71,6 +72,11 @@ mmsys: clock-controller@14000000 {
> #clock-cells = <1>;
> };
>
> +dispsys: display-system {
> + compatible = "mediatek,mt2701-dispsys";
> + mediatek,mmsys = <&mmsys>;
> +}
> +
> ovl0: ovl@1400c000 {
> compatible = "mediatek,mt8173-disp-ovl";
> reg = <0 0x1400c000 0 0x1000>;
next prev parent reply other threads:[~2017-10-19 12:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 11:26 [RFC resend] arm64: mt8173: Fix Acer Chromebooks mmsys probe problem Matthias Brugger
2017-10-19 11:26 ` [RFC resend 1/4] dt-bindings: display: mediatek: add drm binding Matthias Brugger
2017-10-19 12:19 ` Ryder Lee [this message]
2017-10-19 14:36 ` Matthias Brugger
[not found] ` <20171019112610.13645-2-mbrugger-IBi9RG/b67k@public.gmane.org>
2017-10-19 12:38 ` Philipp Zabel
2017-10-19 12:53 ` Laurent Pinchart
2017-10-19 13:06 ` Philipp Zabel
[not found] ` <1508418397.7665.18.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-10-19 15:11 ` Matthias Brugger
2017-10-19 11:26 ` [RFC resend 2/4] drm/mediatek: Add new compatible to probe multimedia subsystem Matthias Brugger
2017-10-19 11:26 ` [RFC resend 3/4] arm64: dts: mt8173: Fix drm subsystem Matthias Brugger
[not found] ` <20171019112610.13645-4-mbrugger-IBi9RG/b67k@public.gmane.org>
2017-10-19 12:38 ` Philipp Zabel
2017-10-20 9:16 ` CK Hu
2017-10-20 12:49 ` Matthias Brugger
2017-10-19 11:26 ` [RFC resend 4/4] arm: dts: mt2701: " Matthias Brugger
2017-10-19 13:01 ` [RFC resend] arm64: mt8173: Fix Acer Chromebooks mmsys probe problem Philipp Zabel
2017-10-19 13:39 ` Laurent Pinchart
2017-10-19 14:54 ` Philipp Zabel
2017-10-23 1:42 ` CK Hu
[not found] ` <1508424856.7665.22.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-10-23 10:23 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508415566.5287.10.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=airlied@linux.ie \
--cc=catalin.marinas@arm.com \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mbrugger@suse.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).