[PATCH] of: overlay: make pr_err() string unique

[PATCH] of: overlay: make pr_err() string unique

[frowand.list]

From: Frank Rowand <frank.rowand@sony.com>

The same error string occurs in drivers/of/resolver.c.  Change
the error here to more precisely describe this case, and avoid
the possible confusion of looking in the wrong source location
to understand the cause of an error.

Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---

And yes, I was looking in the wrong file and not understanding
how this error could have been triggered by the example
provided.  :-)

 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index f5fce0fea40b..c150abb9049d 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -598,7 +598,7 @@ static int init_overlay_changeset(struct overlay_changeset *ovcs,
 		fragment->target = of_find_node_by_path("/__symbols__");
 
 		if (!fragment->target) {
-			pr_err("no symbols in root of device tree.\n");
+			pr_err("symbols in overlay, but not in live tree\n");
 			ret = -EINVAL;
 			goto err_free_fragments;
 		}
-- 
Frank Rowand <frank.rowand@sony.com>

Re: [PATCH] of: overlay: make pr_err() string unique

[Rob Herring]

On Thu, Oct 19, 2017 at 4:38 PM,  <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> From: Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>
>
> The same error string occurs in drivers/of/resolver.c.  Change
> the error here to more precisely describe this case, and avoid
> the possible confusion of looking in the wrong source location
> to understand the cause of an error.
>
> Signed-off-by: Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>
> ---
>
> And yes, I was looking in the wrong file and not understanding
> how this error could have been triggered by the example
> provided.  :-)
>
>  drivers/of/overlay.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html