* [PATCH v2] ata: fixes kernel crash while tracing ata_eh_link_autopsy event
@ 2017-11-02 11:01 Rameshwar Prasad Sahu
2017-11-03 13:28 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Rameshwar Prasad Sahu @ 2017-11-02 11:01 UTC (permalink / raw)
To: olof, tj, arnd
Cc: linux-scsi, linux-ide, devicetree, linux-arm-kernel, mlangsdo,
jcm, patches, Rameshwar Prasad Sahu
When tracing ata link error event, the kernel crashes when the disk is
removed due to NULL pointer access by trace_ata_eh_link_autopsy API.
This occurs as the dev is NULL when the disk disappeared. This patch
fixes this crash by calling trace_ata_eh_link_autopsy only if "dev"
is not NULL.
v2 changes:
Removed direct passing "link" pointer instead of "dev" in trace API.
Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
---
drivers/ata/libata-eh.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index e4effef..ea20e0e 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2264,8 +2264,8 @@ static void ata_eh_link_autopsy(struct ata_link *link)
if (dev->flags & ATA_DFLAG_DUBIOUS_XFER)
eflags |= ATA_EFLAG_DUBIOUS_XFER;
ehc->i.action |= ata_eh_speed_down(dev, eflags, all_err_mask);
+ trace_ata_eh_link_autopsy(dev, ehc->i.action, all_err_mask);
}
- trace_ata_eh_link_autopsy(dev, ehc->i.action, all_err_mask);
DPRINTK("EXIT\n");
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ata: fixes kernel crash while tracing ata_eh_link_autopsy event
2017-11-02 11:01 [PATCH v2] ata: fixes kernel crash while tracing ata_eh_link_autopsy event Rameshwar Prasad Sahu
@ 2017-11-03 13:28 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2017-11-03 13:28 UTC (permalink / raw)
To: Rameshwar Prasad Sahu
Cc: olof, arnd, linux-scsi, linux-ide, devicetree, linux-arm-kernel,
mlangsdo, jcm, patches
On Thu, Nov 02, 2017 at 04:31:07PM +0530, Rameshwar Prasad Sahu wrote:
> When tracing ata link error event, the kernel crashes when the disk is
> removed due to NULL pointer access by trace_ata_eh_link_autopsy API.
> This occurs as the dev is NULL when the disk disappeared. This patch
> fixes this crash by calling trace_ata_eh_link_autopsy only if "dev"
> is not NULL.
>
> v2 changes:
> Removed direct passing "link" pointer instead of "dev" in trace API.
>
> Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
Applied to libata/for-4.15.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-03 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-02 11:01 [PATCH v2] ata: fixes kernel crash while tracing ata_eh_link_autopsy event Rameshwar Prasad Sahu
2017-11-03 13:28 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).