From: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: "Andrew F. Davis" <afd-l0cyMroinI0@public.gmane.org>,
"Liam Girdwood"
<lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Mark Brown" <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Benoît Cousson"
<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Tony Lindgren" <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
"Shawn Guo" <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Sascha Hauer" <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/9] ARM: dts: am335x-pepper: Fix the audio CODEC's reset pin
Date: Thu, 09 Nov 2017 15:25:21 +0100 [thread overview]
Message-ID: <1510237521.7659.11.camel@pengutronix.de> (raw)
In-Reply-To: <20171108212505.28320-5-afd-l0cyMroinI0@public.gmane.org>
On Wed, 2017-11-08 at 15:25 -0600, Andrew F. Davis wrote:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpio", fix this here.
>
> Fixes: 4341881d0562 ("ARM: dts: Add devicetree for Gumstix Pepper board")
>
> Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
> ---
> arch/arm/boot/dts/am335x-pepper.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts
> index 03c7d77023c6..d652abd76333 100644
> --- a/arch/arm/boot/dts/am335x-pepper.dts
> +++ b/arch/arm/boot/dts/am335x-pepper.dts
> @@ -139,7 +139,7 @@
> &audio_codec {
> status = "okay";
>
> - gpio-reset = <&gpio1 16 GPIO_ACTIVE_LOW>;
> + reset-gpio = <&gpio1 16 GPIO_ACTIVE_LOW>;
This potentially breaks audio on am335x-pepper until the driver patches
are applied, same for the other device trees. To make this bisectable,
add support for the new property name to the driver before changing the
device trees.
regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-09 14:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 21:24 [PATCH 0/9] Remove use of "gpio-reset" from DT Andrew F. Davis
2017-11-08 21:24 ` [PATCH 1/9] ASoC: tlv320aic31xx: Fix typo in DT binding documentation Andrew F. Davis
[not found] ` <20171108212505.28320-2-afd-l0cyMroinI0@public.gmane.org>
2017-11-09 14:25 ` Philipp Zabel
2017-11-09 16:28 ` Andrew F. Davis
[not found] ` <20171108212505.28320-1-afd-l0cyMroinI0@public.gmane.org>
2017-11-08 21:24 ` [PATCH 2/9] ASoC: tlv320aic3x: " Andrew F. Davis
[not found] ` <20171108212505.28320-3-afd-l0cyMroinI0@public.gmane.org>
2017-11-09 20:26 ` [alsa-devel] " Benoît Thébaudeau
2017-11-09 20:42 ` Andrew F. Davis
2017-11-08 21:24 ` [PATCH 3/9] ASoC: cs42l56: bindings: sound: Fix reset GPIO name in example DT binding Andrew F. Davis
[not found] ` <20171108212505.28320-4-afd-l0cyMroinI0@public.gmane.org>
2017-11-13 21:20 ` Rob Herring
2017-11-08 21:25 ` [PATCH 4/9] ARM: dts: am335x-pepper: Fix the audio CODEC's reset pin Andrew F. Davis
[not found] ` <20171108212505.28320-5-afd-l0cyMroinI0@public.gmane.org>
2017-11-09 14:25 ` Philipp Zabel [this message]
2017-11-09 16:40 ` Andrew F. Davis
2017-11-08 21:25 ` [PATCH 5/9] ARM: dts: imx6: RDU2: " Andrew F. Davis
2017-11-08 21:25 ` [PATCH 6/9] ARM: dts: imx: " Andrew F. Davis
2017-11-08 21:25 ` [PATCH 7/9] ARM: dts: omap3-n900: " Andrew F. Davis
2017-11-08 21:25 ` [PATCH 8/9] ASoC: tlv320aic31xx: Fix the reset GPIO OF name Andrew F. Davis
[not found] ` <20171108212505.28320-9-afd-l0cyMroinI0@public.gmane.org>
2017-11-08 21:36 ` Mark Brown
[not found] ` <20171108213639.iymb7wuyjpuirbdu-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-08 21:53 ` Andrew F. Davis
[not found] ` <80169c43-ad7f-d89c-61bf-5ca054aacda5-l0cyMroinI0@public.gmane.org>
2017-11-08 22:18 ` Mark Brown
[not found] ` <20171108221814.m6j3dgrlqpy4htxf-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-08 23:25 ` Andrew F. Davis
[not found] ` <1374534b-ac17-82ef-7b3b-3c6e4d4c5cc9-l0cyMroinI0@public.gmane.org>
2017-11-09 13:22 ` Mark Brown
2017-11-08 21:25 ` [PATCH 9/9] ASoC: tlv320aic3x: " Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510237521.7659.11.camel@pengutronix.de \
--to=p.zabel-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=afd-l0cyMroinI0@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).