[PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

[PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

[Yong Deng]

Add binding documentation for Allwinner V3s CSI.

Signed-off-by: Yong Deng <yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org>
---
 .../devicetree/bindings/media/sun6i-csi.txt        | 51 ++++++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt

diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt b/Documentation/devicetree/bindings/media/sun6i-csi.txt
new file mode 100644
index 0000000..f3916a2
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt
@@ -0,0 +1,51 @@
+Allwinner V3s Camera Sensor Interface
+------------------------------
+
+Required properties:
+  - compatible: value must be "allwinner,sun8i-v3s-csi"
+  - reg: base address and size of the memory-mapped region.
+  - interrupts: interrupt associated to this IP
+  - clocks: phandles to the clocks feeding the CSI
+    * bus: the CSI interface clock
+    * mod: the CSI module clock
+    * ram: the CSI DRAM clock
+  - clock-names: the clock names mentioned above
+  - resets: phandles to the reset line driving the CSI
+
+- ports: A ports node with endpoint definitions as defined in
+  Documentation/devicetree/bindings/media/video-interfaces.txt.
+  Currently, the driver only support the parallel interface. So, a single port
+  node with one endpoint and parallel bus is supported.
+
+Example:
+
+	csi1: csi@01cb4000 {
+		compatible = "allwinner,sun8i-v3s-csi";
+		reg = <0x01cb4000 0x1000>;
+		interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&ccu CLK_BUS_CSI>,
+			 <&ccu CLK_CSI1_SCLK>,
+			 <&ccu CLK_DRAM_CSI>;
+		clock-names = "bus", "mod", "ram";
+		resets = <&ccu RST_BUS_CSI>;
+
+		port {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			/* Parallel bus endpoint */
+			csi1_ep: endpoint {
+				remote-endpoint = <&adv7611_ep>;
+				bus-width = <16>;
+				data-shift = <0>;
+
+				/* If hsync-active/vsync-active are missing,
+				   embedded BT.656 sync is used */
+				hsync-active = <0>; /* Active low */
+				vsync-active = <0>; /* Active low */
+				data-active = <1>;  /* Active high */
+				pclk-sample = <1>;  /* Rising */
+			};
+		};
+	};
+
-- 
1.8.3.1

Re: [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

[Chen-Yu Tsai]

On Mon, Nov 13, 2017 at 3:32 PM, Yong Deng <yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org> wrote:
> Add binding documentation for Allwinner V3s CSI.
>
> Signed-off-by: Yong Deng <yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org>
> ---
>  .../devicetree/bindings/media/sun6i-csi.txt        | 51 ++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt
>
> diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt b/Documentation/devicetree/bindings/media/sun6i-csi.txt
> new file mode 100644
> index 0000000..f3916a2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt
> @@ -0,0 +1,51 @@
> +Allwinner V3s Camera Sensor Interface
> +------------------------------
> +
> +Required properties:
> +  - compatible: value must be "allwinner,sun8i-v3s-csi"
> +  - reg: base address and size of the memory-mapped region.
> +  - interrupts: interrupt associated to this IP
> +  - clocks: phandles to the clocks feeding the CSI
> +    * bus: the CSI interface clock
> +    * mod: the CSI module clock
> +    * ram: the CSI DRAM clock
> +  - clock-names: the clock names mentioned above
> +  - resets: phandles to the reset line driving the CSI
> +
> +- ports: A ports node with endpoint definitions as defined in
> +  Documentation/devicetree/bindings/media/video-interfaces.txt.
> +  Currently, the driver only support the parallel interface. So, a single port
> +  node with one endpoint and parallel bus is supported.
> +
> +Example:
> +
> +       csi1: csi@01cb4000 {

Drop the leading zero in the address part.

> +               compatible = "allwinner,sun8i-v3s-csi";
> +               reg = <0x01cb4000 0x1000>;
> +               interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> +               clocks = <&ccu CLK_BUS_CSI>,
> +                        <&ccu CLK_CSI1_SCLK>,

CSI also has an MCLK. Do you need that one?

ChenYu

> +                        <&ccu CLK_DRAM_CSI>;
> +               clock-names = "bus", "mod", "ram";
> +               resets = <&ccu RST_BUS_CSI>;
> +
> +               port {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +
> +                       /* Parallel bus endpoint */
> +                       csi1_ep: endpoint {
> +                               remote-endpoint = <&adv7611_ep>;
> +                               bus-width = <16>;
> +                               data-shift = <0>;
> +
> +                               /* If hsync-active/vsync-active are missing,
> +                                  embedded BT.656 sync is used */
> +                               hsync-active = <0>; /* Active low */
> +                               vsync-active = <0>; /* Active low */
> +                               data-active = <1>;  /* Active high */
> +                               pclk-sample = <1>;  /* Rising */
> +                       };
> +               };
> +       };
> +
> --
> 1.8.3.1
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
> For more options, visit https://groups.google.com/d/optout.

Re: [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

[Yong]

On Mon, 18 Dec 2017 16:35:51 +0800
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> wrote:

> On Mon, Nov 13, 2017 at 3:32 PM, Yong Deng <yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org> wrote:
> > Add binding documentation for Allwinner V3s CSI.
> >
> > Signed-off-by: Yong Deng <yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org>
> > ---
> >  .../devicetree/bindings/media/sun6i-csi.txt        | 51 ++++++++++++++++++++++
> >  1 file changed, 51 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt
> >
> > diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt b/Documentation/devicetree/bindings/media/sun6i-csi.txt
> > new file mode 100644
> > index 0000000..f3916a2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt
> > @@ -0,0 +1,51 @@
> > +Allwinner V3s Camera Sensor Interface
> > +------------------------------
> > +
> > +Required properties:
> > +  - compatible: value must be "allwinner,sun8i-v3s-csi"
> > +  - reg: base address and size of the memory-mapped region.
> > +  - interrupts: interrupt associated to this IP
> > +  - clocks: phandles to the clocks feeding the CSI
> > +    * bus: the CSI interface clock
> > +    * mod: the CSI module clock
> > +    * ram: the CSI DRAM clock
> > +  - clock-names: the clock names mentioned above
> > +  - resets: phandles to the reset line driving the CSI
> > +
> > +- ports: A ports node with endpoint definitions as defined in
> > +  Documentation/devicetree/bindings/media/video-interfaces.txt.
> > +  Currently, the driver only support the parallel interface. So, a single port
> > +  node with one endpoint and parallel bus is supported.
> > +
> > +Example:
> > +
> > +       csi1: csi@01cb4000 {
> 
> Drop the leading zero in the address part.

OK.

> 
> > +               compatible = "allwinner,sun8i-v3s-csi";
> > +               reg = <0x01cb4000 0x1000>;
> > +               interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> > +               clocks = <&ccu CLK_BUS_CSI>,
> > +                        <&ccu CLK_CSI1_SCLK>,
> 
> CSI also has an MCLK. Do you need that one?

MCLK is not needed if the front end is not a sensor (like adv7611).
I will add it as an option.

> 
> ChenYu
> 
> > +                        <&ccu CLK_DRAM_CSI>;
> > +               clock-names = "bus", "mod", "ram";
> > +               resets = <&ccu RST_BUS_CSI>;
> > +
> > +               port {
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +
> > +                       /* Parallel bus endpoint */
> > +                       csi1_ep: endpoint {
> > +                               remote-endpoint = <&adv7611_ep>;
> > +                               bus-width = <16>;
> > +                               data-shift = <0>;
> > +
> > +                               /* If hsync-active/vsync-active are missing,
> > +                                  embedded BT.656 sync is used */
> > +                               hsync-active = <0>; /* Active low */
> > +                               vsync-active = <0>; /* Active low */
> > +                               data-active = <1>;  /* Active high */
> > +                               pclk-sample = <1>;  /* Rising */
> > +                       };
> > +               };
> > +       };
> > +
> > --
> > 1.8.3.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
> > For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
> For more options, visit https://groups.google.com/d/optout.


Thanks,
Yong

Re: [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi,

On Mon, Dec 18, 2017 at 04:49:21PM +0800, Yong wrote:
> > > +               compatible = "allwinner,sun8i-v3s-csi";
> > > +               reg = <0x01cb4000 0x1000>;
> > > +               interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> > > +               clocks = <&ccu CLK_BUS_CSI>,
> > > +                        <&ccu CLK_CSI1_SCLK>,
> > 
> > CSI also has an MCLK. Do you need that one?
> 
> MCLK is not needed if the front end is not a sensor (like adv7611).
> I will add it as an option.

I guess this should always be needed then. And the driver will make
the decision to enable it or not.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

[Yong]

Hi,

On Mon, 18 Dec 2017 10:24:37 +0100
Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> Hi,
> 
> On Mon, Dec 18, 2017 at 04:49:21PM +0800, Yong wrote:
> > > > +               compatible = "allwinner,sun8i-v3s-csi";
> > > > +               reg = <0x01cb4000 0x1000>;
> > > > +               interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> > > > +               clocks = <&ccu CLK_BUS_CSI>,
> > > > +                        <&ccu CLK_CSI1_SCLK>,
> > > 
> > > CSI also has an MCLK. Do you need that one?
> > 
> > MCLK is not needed if the front end is not a sensor (like adv7611).
> > I will add it as an option.
> 
> I guess this should always be needed then. And the driver will make
> the decision to enable it or not.

But how the driver to know if it should be enabled?
I think MCLK should be added in DT just if the subdev need it.

> 
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com


Thanks,
Yong

Re: [linux-sunxi] [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

[Chen-Yu Tsai]

On Mon, Dec 18, 2017 at 5:43 PM, Yong <yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org> wrote:
> Hi,
>
> On Mon, 18 Dec 2017 10:24:37 +0100
> Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
>
>> Hi,
>>
>> On Mon, Dec 18, 2017 at 04:49:21PM +0800, Yong wrote:
>> > > > +               compatible = "allwinner,sun8i-v3s-csi";
>> > > > +               reg = <0x01cb4000 0x1000>;
>> > > > +               interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
>> > > > +               clocks = <&ccu CLK_BUS_CSI>,
>> > > > +                        <&ccu CLK_CSI1_SCLK>,
>> > >
>> > > CSI also has an MCLK. Do you need that one?
>> >
>> > MCLK is not needed if the front end is not a sensor (like adv7611).
>> > I will add it as an option.
>>
>> I guess this should always be needed then. And the driver will make
>> the decision to enable it or not.
>
> But how the driver to know if it should be enabled?
> I think MCLK should be added in DT just if the subdev need it.

Looking around the docs, there doesn't seem to be anything related
to MCLK within the CSI section.

Furthermore, camera sensor bindings, such as for the OV5640, in fact
do have a property for a reference clock, which is called XCLK or
XVCLK.

Since the clock is already exported from the CCU, I suppose it's
just a matter of referencing the clock from the camera node, with
the proper pinctrl for that pin.

So to summarize, just ignore my comment about the missing MCLK. :)

ChenYu
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html