From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: thierry.reding@gmail.com, jonathanh@nvidia.com,
robh+dt@kernel.org, frowand.list@gmail.com, bhelgaas@google.com,
rjw@rjwysocki.net, tglx@linutronix.de
Cc: vidyas@nvidia.com, kthota@nvidia.com,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
Manikanta Maddireddy <mmaddireddy@nvidia.com>
Subject: [PATCH 09/10] PCI: tegra: Broadcast PME_turn_Off message before link goes to L2
Date: Fri, 24 Nov 2017 21:23:19 +0530 [thread overview]
Message-ID: <1511538800-8275-10-git-send-email-mmaddireddy@nvidia.com> (raw)
In-Reply-To: <1511538800-8275-1-git-send-email-mmaddireddy@nvidia.com>
Per PCIe r3.0, sec 5.3.3.2.1, PCIe root port shoould broadcast PME_turn_Off
message before PCIe link goes to L2. PME_turn_Off broadcast mechanism is
implemented in AFI module. Each Tegra PCIe root port has its own
PME_turn_Off and PME_TO_Ack bitmap in AFI_PME register, program this
register to broadcast PME_turn_Off message.
Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
---
drivers/pci/host/pci-tegra.c | 76 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 76 insertions(+)
diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
index 2ff1ac3aefc1..af999c650941 100644
--- a/drivers/pci/host/pci-tegra.c
+++ b/drivers/pci/host/pci-tegra.c
@@ -155,6 +155,8 @@
#define AFI_INTR_EN_FPCI_TIMEOUT (1 << 7)
#define AFI_INTR_EN_PRSNT_SENSE (1 << 8)
+#define AFI_PCIE_PME 0xf0
+
#define AFI_PCIE_CONFIG 0x0f8
#define AFI_PCIE_CONFIG_PCIE_DISABLE(x) (1 << ((x) + 1))
#define AFI_PCIE_CONFIG_PCIE_DISABLE_ALL 0xe
@@ -315,6 +317,7 @@
#define PADS_REFCLK_CFG_DRVI_SHIFT 12 /* 15:12 */
#define LINK_RETRAIN_TIMEOUT 100000
+#define PME_ACK_TIMEOUT 10000
struct tegra_msi {
struct msi_controller chip;
@@ -1483,6 +1486,76 @@ static int tegra_pcie_put_resources(struct tegra_pcie *pcie)
return 0;
}
+static inline u32 get_pme_turnoff_bitmap(struct tegra_pcie_port *port)
+{
+ struct device *dev = port->pcie->dev;
+ struct device_node *np = dev->of_node;
+ int ret = 0;
+
+ switch (port->index) {
+ case 0:
+ ret = 0;
+ case 1:
+ ret = 8;
+ case 2:
+ if (of_device_is_compatible(np, "nvidia,tegra30-pcie"))
+ ret = 16;
+ else
+ ret = 12;
+ }
+ return ret;
+}
+
+static inline u32 get_pme_ack_bitmap(struct tegra_pcie_port *port)
+{
+ struct device *dev = port->pcie->dev;
+ struct device_node *np = dev->of_node;
+ int ret = 0;
+
+ switch (port->index) {
+ case 0:
+ ret = 5;
+ case 1:
+ ret = 10;
+ case 2:
+ if (of_device_is_compatible(np, "nvidia,tegra30-pcie"))
+ ret = 18;
+ else
+ ret = 14;
+ }
+ return ret;
+}
+
+static void tegra_pcie_pme_turnoff(struct tegra_pcie_port *port)
+{
+ struct tegra_pcie *pcie = port->pcie;
+ ktime_t deadline;
+ unsigned int data;
+
+ data = afi_readl(pcie, AFI_PCIE_PME);
+ data |= (0x1 << get_pme_turnoff_bitmap(port));
+ afi_writel(pcie, data, AFI_PCIE_PME);
+
+ deadline = ktime_add_us(ktime_get(), PME_ACK_TIMEOUT);
+ do {
+ data = afi_readl(pcie, AFI_PCIE_PME);
+ data &= (0x1 << get_pme_ack_bitmap(port));
+ udelay(1);
+ if (ktime_after(ktime_get(), deadline))
+ break;
+ } while (!data);
+
+ if (data)
+ dev_err(pcie->dev, "PME Ack is not receieved on port: %d\n",
+ port->index);
+
+ usleep_range(10000, 11000);
+
+ data = afi_readl(pcie, AFI_PCIE_PME);
+ data &= ~(0x1 << get_pme_turnoff_bitmap(port));
+ afi_writel(pcie, data, AFI_PCIE_PME);
+}
+
static int tegra_msi_alloc(struct tegra_msi *chip)
{
int msi;
@@ -2808,6 +2881,7 @@ static int tegra_pcie_remove(struct platform_device *pdev)
{
struct tegra_pcie *pcie = platform_get_drvdata(pdev);
struct pci_host_bridge *host = pci_host_bridge_from_priv(pcie);
+ struct tegra_pcie_port *port, *tmp;
if (IS_ENABLED(CONFIG_DEBUG_FS))
tegra_pcie_debugfs_exit(pcie);
@@ -2815,6 +2889,8 @@ static int tegra_pcie_remove(struct platform_device *pdev)
pci_remove_root_bus(host->bus);
if (IS_ENABLED(CONFIG_PCI_MSI))
tegra_pcie_disable_msi(pcie);
+ list_for_each_entry_safe(port, tmp, &pcie->ports, list)
+ tegra_pcie_pme_turnoff(port);
tegra_pcie_disable_ports(pcie);
tegra_pcie_free_resources(pcie);
tegra_pcie_disable_controller(pcie);
--
2.1.4
prev parent reply other threads:[~2017-11-24 15:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 15:53 [PATCH 00/10] Add loadable kernel module and power management support Manikanta Maddireddy
[not found] ` <1511538800-8275-1-git-send-email-mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-11-24 15:53 ` [PATCH 01/10] genirq: Export irq_set_msi_desc() Manikanta Maddireddy
2017-11-24 23:55 ` Thomas Gleixner
2017-11-25 19:41 ` Manikanta Maddireddy
[not found] ` <600a7b65-670e-b164-913c-99e18ae593d2-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-11-28 10:00 ` Marc Zyngier
2017-11-28 17:19 ` Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 02/10] of: Export of_pci_range_to_resource() Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 03/10] PM / QoS: Fix device resume latency for non PM QoS devices Manikanta Maddireddy
2017-11-24 16:50 ` Rafael J. Wysocki
[not found] ` <CAJZ5v0ghcwSHdrbZd_=XA=tHz7=aTUVd66dHkMYRNyXpnqP84w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-24 20:39 ` Thierry Reding
2017-11-25 0:02 ` Rafael J. Wysocki
[not found] ` <CAJZ5v0h1EdMV5u-5noMv_1_OpS13nH2NW_6Aua9+LMoWH0tL2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-25 19:46 ` Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 06/10] PCI: Export pci_flags Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 08/10] PCI: tegra: Add loadable kernel module support Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 10/10] PCI: tegra: Add power management support Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 04/10] ARM: tegra: EXPORT tegra_cpuidle_pcie_irqs_in_use() Manikanta Maddireddy
2017-11-30 12:41 ` Lorenzo Pieralisi
2017-11-30 18:46 ` Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 05/10] PCI: Export pci_find_host_bridge() Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 07/10] PCI: tegra: free resources on probe failure Manikanta Maddireddy
2017-11-24 15:53 ` Manikanta Maddireddy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511538800-8275-10-git-send-email-mmaddireddy@nvidia.com \
--to=mmaddireddy@nvidia.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).