[PATCH v3 1/3] Add HS-USB device tree support for R8A7791/Koelsch/Henninger board

[PATCH v3 1/3] Add HS-USB device tree support for R8A7791/Koelsch/Henninger board

[Sergei Shtylyov]

Hello.

   Here's the set of 3 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20141007-v3.17' tag. Here we add the HS-USB device tree support
on the R8A7791/Koelsch/Henninger reference boards. The patchset requires the
USB PHY driver (already merged by Kishon and Greg) and the generic PHY support
patches for the HS-USB driver posted by Yoshihiro Shimoda in order to work...

[1/3] ARM: shmobile: r8a7791: add HS-USB device node
[2/3] ARM: shmobile: koelsch: enable HS-USB
[3/3] ARM: shmobile: henninger: enable HS-USB

WBR, Sergei

[PATCH v3 1/3] ARM: shmobile: r8a7791: add HS-USB device node

[Sergei Shtylyov]

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Define the R8A7791 generic part of the HS-USB device node. It is up to the board
file to enable the device.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
[Sergei: fixed summary, added changelog]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
Changes in version 2:
- uppercased "arm" in the summary;
- added changelog.

 arch/arm/boot/dts/r8a7791.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi
+++ renesas/arch/arm/boot/dts/r8a7791.dtsi
@@ -637,6 +637,17 @@
 		status = "disabled";
 	};
 
+	hsusb: usb@e6590000 {
+		compatible = "renesas,usbhs-r8a7791";
+		reg = <0 0xe6590000 0 0x100>;
+		interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp7_clks R8A7791_CLK_HSUSB>;
+		renesas,buswait = <4>;
+		phys = <&usb0 1>;
+		phy-names = "usb";
+		status = "disabled";
+	};
+
 	usbphy: usb-phy@e6590100 {
 		compatible = "renesas,usb-phy-r8a7791";
 		reg = <0 0xe6590100 0 0x100>;

[PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB

[Sergei Shtylyov]

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI
and HS-USB drivers are enabled but they should be just ignored.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
[Sergei: added pin function/group and prop, moved device node, fixed summary,
added changelog]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
Changes in version 3:
- added pinctrl-related properties;
- moved the HS-USB node to precede the USB PHY node;
- uppercased "arm" in the summary;
- added changelog.

 arch/arm/boot/dts/r8a7791-koelsch.dts |    7 +++++++
 1 file changed, 7 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -464,6 +464,13 @@
 	pinctrl-names = "default";
 };
 
+&hsusb {
+	status = "okay";
+	pinctrl-0 = <&usb0_pins>;
+	pinctrl-names = "default";
+	renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>;
+};
+
 &usbphy {
 	status = "okay";
 };

Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

On Wed, Oct 08, 2014 at 10:02:44PM +0400, Sergei Shtylyov wrote:
> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> 
> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
> should check when probing (which is the ID output from MAX3355 OTG chip).
> 
> Note that there will be pinctrl-related error messages if both internal PCI
> and HS-USB drivers are enabled but they should be just ignored.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> [Sergei: added pin function/group and prop, moved device node, fixed summary,
> added changelog]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> 
> ---
> Changes in version 3:
> - added pinctrl-related properties;

did you miss pinctrl here ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB

[Sergei Shtylyov]

Hello.

On 10/08/2014 10:05 PM, Felipe Balbi wrote:

>> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

>> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
>> should check when probing (which is the ID output from MAX3355 OTG chip).

>> Note that there will be pinctrl-related error messages if both internal PCI
>> and HS-USB drivers are enabled but they should be just ignored.

>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> [Sergei: added pin function/group and prop, moved device node, fixed summary,
>> added changelog]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> ---
>> Changes in version 3:
>> - added pinctrl-related properties;

> did you miss pinctrl here ?

     No, AFAICS. Or what do you mean?

WBR, Sergei

Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

On Wed, Oct 08, 2014 at 10:07:50PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 10/08/2014 10:05 PM, Felipe Balbi wrote:
> 
> >>From: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> 
> >>Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
> >>should check when probing (which is the ID output from MAX3355 OTG chip).
> 
> >>Note that there will be pinctrl-related error messages if both internal PCI
> >>and HS-USB drivers are enabled but they should be just ignored.
> 
> >>Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> >>[Sergei: added pin function/group and prop, moved device node, fixed summary,
> >>added changelog]
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> 
> >>---
> >>Changes in version 3:
> >>- added pinctrl-related properties;
> 
> >did you miss pinctrl here ?
> 
>     No, AFAICS. Or what do you mean?

usb0_pins doesn't appear to be defined anywhere.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB

[Sergei Shtylyov]

On 10/08/2014 10:08 PM, Felipe Balbi wrote:

>>>> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

>>>> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
>>>> should check when probing (which is the ID output from MAX3355 OTG chip).

>>>> Note that there will be pinctrl-related error messages if both internal PCI
>>>> and HS-USB drivers are enabled but they should be just ignored.

>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>> [Sergei: added pin function/group and prop, moved device node, fixed summary,
>>>> added changelog]
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>>>> ---
>>>> Changes in version 3:
>>>> - added pinctrl-related properties;

>>> did you miss pinctrl here ?

>>      No, AFAICS. Or what do you mean?

> usb0_pins doesn't appear to be defined anywhere.

    They are defined in the same file, just not in this patch. If you're 
looking at some of the USB trees or Linus' tree, the corresponding patch just 
hasn't hit them yet, it's in renesas.git ATM.

WBR, Sergei

Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

On Wed, Oct 08, 2014 at 10:11:59PM +0400, Sergei Shtylyov wrote:
> On 10/08/2014 10:08 PM, Felipe Balbi wrote:
> 
> >>>>From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> >>>>Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
> >>>>should check when probing (which is the ID output from MAX3355 OTG chip).
> 
> >>>>Note that there will be pinctrl-related error messages if both internal PCI
> >>>>and HS-USB drivers are enabled but they should be just ignored.
> 
> >>>>Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >>>>[Sergei: added pin function/group and prop, moved device node, fixed summary,
> >>>>added changelog]
> >>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >>>>---
> >>>>Changes in version 3:
> >>>>- added pinctrl-related properties;
> 
> >>>did you miss pinctrl here ?
> 
> >>     No, AFAICS. Or what do you mean?
> 
> >usb0_pins doesn't appear to be defined anywhere.
> 
>    They are defined in the same file, just not in this patch. If you're
> looking at some of the USB trees or Linus' tree, the corresponding patch
> just hasn't hit them yet, it's in renesas.git ATM.

oh, alright then. :-)

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB

[Yoshihiro Shimoda]

Hello.

(2014/10/09 3:02), Sergei Shtylyov wrote:
> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
> should check when probing (which is the ID output from MAX3355 OTG chip).
> 
> Note that there will be pinctrl-related error messages if both internal PCI
> and HS-USB drivers are enabled but they should be just ignored.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> [Sergei: added pin function/group and prop, moved device node, fixed summary,
> added changelog]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
> Changes in version 3:
> - added pinctrl-related properties;
> - moved the HS-USB node to precede the USB PHY node;
> - uppercased "arm" in the summary;
> - added changelog.
> 
>  arch/arm/boot/dts/r8a7791-koelsch.dts |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -464,6 +464,13 @@
>  	pinctrl-names = "default";
>  };
>  
> +&hsusb {
> +	status = "okay";
> +	pinctrl-0 = <&usb0_pins>;
> +	pinctrl-names = "default";

Perhaps I don't understand the pinctrl world yet, but I have a question.

In r8a7791, the USB0_PWEN is GP7_23 and the USB0_OVC is GP7_24. And,
the "usb0_pins" is related to these USB0 pins. But, as you know,
the koelsch has a OTG ID pin and it connects to GP5_31 via MAX3355 chip.
So, would you tell me why koelsch needs the pinctrl?

Best regards,
Yoshihiro Shimoda

> +	renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>;
> +};
> +
>  &usbphy {
>  	status = "okay";
>  };
> 

Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB

[Sergei Shtylyov]

Hello.

On 10/09/2014 05:07 AM, Yoshihiro Shimoda wrote:

>> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
>> should check when probing (which is the ID output from MAX3355 OTG chip).

>> Note that there will be pinctrl-related error messages if both internal PCI
>> and HS-USB drivers are enabled but they should be just ignored.

>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> [Sergei: added pin function/group and prop, moved device node, fixed summary,
>> added changelog]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> ---
>> Changes in version 3:
>> - added pinctrl-related properties;
>> - moved the HS-USB node to precede the USB PHY node;
>> - uppercased "arm" in the summary;
>> - added changelog.

>>   arch/arm/boot/dts/r8a7791-koelsch.dts |    7 +++++++
>>   1 file changed, 7 insertions(+)

>> Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts
>> +++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
>> @@ -464,6 +464,13 @@
>>   	pinctrl-names = "default";
>>   };
>>
>> +&hsusb {
>> +	status = "okay";
>> +	pinctrl-0 = <&usb0_pins>;
>> +	pinctrl-names = "default";

> Perhaps I don't understand the pinctrl world yet, but I have a question.

> In r8a7791, the USB0_PWEN is GP7_23 and the USB0_OVC is GP7_24. And,
> the "usb0_pins" is related to these USB0 pins. But, as you know,
> the koelsch has a OTG ID pin and it connects to GP5_31 via MAX3355 chip.

    The GPIO pins are not requested via pinctrl.

> So, would you tell me why koelsch needs the pinctrl?

    Because at least USB0_OVC/VBUS is used by HS-USB. I decided not to modify 
the R8A7791 PFC driver in order to create a group consisting of that signal 
alone (like on R8A7790), because we don't need to read GP7_23 on these boards, 
unlike Lager.

> Best regards,
> Yoshihiro Shimoda

WBR, Sergei

Re: [PATCH v3 2/3] ARM: shmobile: koelsch: enable HS-USB

[Yoshihiro Shimoda]

Hello.

(2014/10/09 21:51), Sergei Shtylyov wrote:
> Hello.
> 
> On 10/09/2014 05:07 AM, Yoshihiro Shimoda wrote:
> 
>>> Enable HS-USB device for the Koelsch board, defining the GPIO that the driver
>>> should check when probing (which is the ID output from MAX3355 OTG chip).
> 
>>> Note that there will be pinctrl-related error messages if both internal PCI
>>> and HS-USB drivers are enabled but they should be just ignored.
> 
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
>>> [Sergei: added pin function/group and prop, moved device node, fixed summary,
>>> added changelog]
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> 
>>> ---
>>> Changes in version 3:
>>> - added pinctrl-related properties;
>>> - moved the HS-USB node to precede the USB PHY node;
>>> - uppercased "arm" in the summary;
>>> - added changelog.
> 
>>>   arch/arm/boot/dts/r8a7791-koelsch.dts |    7 +++++++
>>>   1 file changed, 7 insertions(+)
> 
>>> Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
>>> ===================================================================
>>> --- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts
>>> +++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
>>> @@ -464,6 +464,13 @@
>>>       pinctrl-names = "default";
>>>   };
>>>
>>> +&hsusb {
>>> +    status = "okay";
>>> +    pinctrl-0 = <&usb0_pins>;
>>> +    pinctrl-names = "default";
> 
>> Perhaps I don't understand the pinctrl world yet, but I have a question.
> 
>> In r8a7791, the USB0_PWEN is GP7_23 and the USB0_OVC is GP7_24. And,
>> the "usb0_pins" is related to these USB0 pins. But, as you know,
>> the koelsch has a OTG ID pin and it connects to GP5_31 via MAX3355 chip.
> 
>    The GPIO pins are not requested via pinctrl.
> 
>> So, would you tell me why koelsch needs the pinctrl?
> 
>    Because at least USB0_OVC/VBUS is used by HS-USB. I decided not to modify the R8A7791 PFC driver in order to create a group consisting of that signal alone (like on R8A7790), because we don't need to read GP7_23 on these boards, unlike Lager.

Thank you very much for the reply.
Finally I understood why it needs the princtrl.
(I didn't know the HS-USB will use the USB0_OVC/VBUS for detecting VBUS...)

Best regards,
Yoshihiro Shimoda

>> Best regards,
>> Yoshihiro Shimoda
> 
> WBR, Sergei
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 3/3] ARM: shmobile: henninger: enable HS-USB

[Sergei Shtylyov]

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Enable HS-USB device for the Henninger board, defining the GPIO that the driver
should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI
and HS-USB drivers are enabled but they should be just ignored.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
[Sergei: added pin function/group and prop, moved device node, fixed summary,
added changelog]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
Changes in version 2:
- added pinctrl-related properties;
- moved the HS-USB node to precede the USB PHY node;
- uppercased "arm" in the summary;
- added changelog.

 arch/arm/boot/dts/r8a7791-henninger.dts |    7 +++++++
 1 file changed, 7 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts
+++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts
@@ -272,6 +272,13 @@
 	pinctrl-names = "default";
 };
 
+&hsusb {
+	status = "okay";
+	pinctrl-0 = <&usb0_pins>;
+	pinctrl-names = "default";
+	renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>;
+};
+
 &usbphy {
 	status = "okay";
 };

Re: [PATCH v3 1/3] Add HS-USB device tree support for R8A7791/Koelsch/Henninger board

[Sergei Shtylyov]

Oops, this should have been [PATCH v 0/3]... :-/

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/3] Add HS-USB device tree support for R8A7791/Koelsch/Henninger board

[Yoshihiro Shimoda]

Hi Simon-san,

(2014/10/09 2:59), Sergei Shtylyov wrote:
> Hello.
> 
>    Here's the set of 3 patches against Simon Horman's 'renesas.git' repo,
> 'renesas-devel-20141007-v3.17' tag. Here we add the HS-USB device tree support
> on the R8A7791/Koelsch/Henninger reference boards. The patchset requires the
> USB PHY driver (already merged by Kishon and Greg) and the generic PHY support
> patches for the HS-USB driver posted by Yoshihiro Shimoda in order to work...
> 
> [1/3] ARM: shmobile: r8a7791: add HS-USB device node
> [2/3] ARM: shmobile: koelsch: enable HS-USB
> [3/3] ARM: shmobile: henninger: enable HS-USB

I will also rebase this patch set.

Best regards,
Yoshihiro Shimoda

> WBR, Sergei
>