From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Wang Subject: Re: [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC Date: Fri, 1 Dec 2017 10:23:11 +0800 Message-ID: <1512094991.28444.11.camel@mtkswgap22> References: <3e2c72d18bbe6d7c762fd820195f0fa0b5a45bbf.1511949769.git.sean.wang@mediatek.com> <20171201020604.etfzccuwomxgcwmg@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171201020604.etfzccuwomxgcwmg@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, 2017-11-30 at 20:06 -0600, Rob Herring wrote: > On Wed, Nov 29, 2017 at 06:10:35PM +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > > From: Sean Wang > > > > Add the devicetree binding for MT7623 SoC using MT2701 as the fallback. > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Signed-off-by: Sean Wang > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > index 72d2a73..1732588 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > @@ -12,6 +12,8 @@ Required properties: > > "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > > "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > > "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > > + "mediatek,mt7623-mmc", > > + "mediatek,mt2701-mmc": for mmc host ip compatible with mt7623 > > Those should be on 1 line ideally. > > BTW, I find "for mmc host ip compatible with mt7623" to be mostly > redundant. > Either way, > > Acked-by: Rob Herring > > okay, thanks for your careful guide These will be fixed with "mediatek,mt7623-mmc", "mediatek,mt2701-mmc": for MT7623 SoC in the next version Sean > > - reg: physical base address of the controller and length > > - interrupts: Should contain MSDC interrupt number > > - clocks: Should contain phandle for the clock feeding the MMC controller > > -- > > 2.7.4 > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html