[PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled

[PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>

As the 'reg' property is mandatory in the subnodes, improve the
example by adding the unit address to the sysled node.

This prevents the following build warning with W=1:

Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name

Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
---
 Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/mc13xxx.txt b/Documentation/devicetree/bindings/mfd/mc13xxx.txt
index ac235fe..8261ea7 100644
--- a/Documentation/devicetree/bindings/mfd/mc13xxx.txt
+++ b/Documentation/devicetree/bindings/mfd/mc13xxx.txt
@@ -130,7 +130,7 @@ ecspi@70010000 { /* ECSPI1 */
 			#size-cells = <0>;
 			led-control = <0x000 0x000 0x0e0 0x000>;
 
-			sysled {
+			sysled@3 {
 				reg = <3>;
 				label = "system:red:live";
 				linux,default-trigger = "heartbeat";
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled

[Lee Jones]

On Fri, 01 Dec 2017, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> 
> As the 'reg' property is mandatory in the subnodes, improve the
> example by adding the unit address to the sysled node.
> 
> This prevents the following build warning with W=1:
> 
> Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name
> 
> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Why do I have 2 identical patches in my inbox?

> diff --git a/Documentation/devicetree/bindings/mfd/mc13xxx.txt b/Documentation/devicetree/bindings/mfd/mc13xxx.txt
> index ac235fe..8261ea7 100644
> --- a/Documentation/devicetree/bindings/mfd/mc13xxx.txt
> +++ b/Documentation/devicetree/bindings/mfd/mc13xxx.txt
> @@ -130,7 +130,7 @@ ecspi@70010000 { /* ECSPI1 */
>  			#size-cells = <0>;
>  			led-control = <0x000 0x000 0x0e0 0x000>;
>  
> -			sysled {
> +			sysled@3 {
>  				reg = <3>;
>  				label = "system:red:live";
>  				linux,default-trigger = "heartbeat";

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled

[Fabio Estevam]

On Mon, Dec 4, 2017 at 7:07 AM, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> On Fri, 01 Dec 2017, Fabio Estevam wrote:
>
>> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>>
>> As the 'reg' property is mandatory in the subnodes, improve the
>> example by adding the unit address to the sysled node.
>>
>> This prevents the following build warning with W=1:
>>
>> Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>> ---
>>  Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Why do I have 2 identical patches in my inbox?

There was a typo in the mailing list address in the first one, sorry.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled

[Rob Herring]

On Fri, Dec 01, 2017 at 07:51:26PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> 
> As the 'reg' property is mandatory in the subnodes, improve the
> example by adding the unit address to the sysled node.
> 
> This prevents the following build warning with W=1:
> 
> Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name

Even if the doc file could compile, looks like the name was sysled not 
sysled0.

> 
> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

In any case,

Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled

[Fabio Estevam]

Hi Rob,

On Mon, Dec 4, 2017 at 7:53 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Fri, Dec 01, 2017 at 07:51:26PM -0200, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>>
>> As the 'reg' property is mandatory in the subnodes, improve the
>> example by adding the unit address to the sysled node.
>>
>> This prevents the following build warning with W=1:
>>
>> Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name
>
> Even if the doc file could compile, looks like the name was sysled not
> sysled0.

The sysled0 name I got from arch/arm/boot/dts/imx51-zii-rdu1.dts,
where I fixed the real warning:

https://www.spinics.net/lists/arm-kernel/msg620322.html


>>
>> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
>> ---
>>  Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> In any case,
>
> Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Thanks
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: mfd: mc13xxx: Add the unit address to sysled

[Lee Jones]

On Fri, 01 Dec 2017, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> 
> As the 'reg' property is mandatory in the subnodes, improve the
> example by adding the unit address to the sysled node.
> 
> This prevents the following build warning with W=1:
> 
> Node /soc/aips@70000000/spba@70000000/ecspi@70010000/pmic@0/leds/sysled0 has a reg or ranges property, but no unit name
> 
> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mfd/mc13xxx.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html