[PATCH] dt-bindings: fsl,imx-gpcv2: Fix the unit address

[PATCH] dt-bindings: fsl,imx-gpcv2: Fix the unit address

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>

In the provided example the unit address does not match the 'reg' value.

Fix the unit address.

Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
---
 Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
index 02f45c6..19e1819 100644
--- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
+++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
@@ -44,7 +44,7 @@ Example:
 			#address-cells = <1>;
 			#size-cells = <0>;
 
-			pgc_pcie_phy: power-domain@3 {
+			pgc_pcie_phy: power-domain@IMX7_POWER_DOMAIN_PCIE_PHY {
 				#power-domain-cells = <0>;
 
 				reg = <IMX7_POWER_DOMAIN_PCIE_PHY>;
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: fsl,imx-gpcv2: Fix the unit address

[Rob Herring]

On Fri, Dec 15, 2017 at 12:51:36AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> 
> In the provided example the unit address does not match the 'reg' value.
> 
> Fix the unit address.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> index 02f45c6..19e1819 100644
> --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
> @@ -44,7 +44,7 @@ Example:
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  
> -			pgc_pcie_phy: power-domain@3 {
> +			pgc_pcie_phy: power-domain@IMX7_POWER_DOMAIN_PCIE_PHY {

That's ugly.

Defines in reg is not something we should use generally, IMO. There are 
a few exceptions for flags.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: fsl,imx-gpcv2: Fix the unit address

[Fabio Estevam]

On Sat, Dec 16, 2017 at 3:53 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:

> That's ugly.
>
> Defines in reg is not something we should use generally, IMO. There are
> a few exceptions for flags.

Sounds good. Just sent a v2 without the defines.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html