* [PATCH] dt-bindings: fsl,imx-gpcv2: Fix the unit address
@ 2017-12-15 2:51 Fabio Estevam
[not found] ` <1513306296-17667-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2017-12-15 2:51 UTC (permalink / raw)
To: shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w,
devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
Fabio Estevam
From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
In the provided example the unit address does not match the 'reg' value.
Fix the unit address.
Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>
---
Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
index 02f45c6..19e1819 100644
--- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
+++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt
@@ -44,7 +44,7 @@ Example:
#address-cells = <1>;
#size-cells = <0>;
- pgc_pcie_phy: power-domain@3 {
+ pgc_pcie_phy: power-domain@IMX7_POWER_DOMAIN_PCIE_PHY {
#power-domain-cells = <0>;
reg = <IMX7_POWER_DOMAIN_PCIE_PHY>;
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1513306296-17667-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] dt-bindings: fsl,imx-gpcv2: Fix the unit address [not found] ` <1513306296-17667-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2017-12-16 17:53 ` Rob Herring 2017-12-16 18:06 ` Fabio Estevam 0 siblings, 1 reply; 3+ messages in thread From: Rob Herring @ 2017-12-16 17:53 UTC (permalink / raw) To: Fabio Estevam Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A, andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w, devicetree-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam On Fri, Dec 15, 2017 at 12:51:36AM -0200, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org> > > In the provided example the unit address does not match the 'reg' value. > > Fix the unit address. > > Signed-off-by: Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org> > --- > Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt > index 02f45c6..19e1819 100644 > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.txt > @@ -44,7 +44,7 @@ Example: > #address-cells = <1>; > #size-cells = <0>; > > - pgc_pcie_phy: power-domain@3 { > + pgc_pcie_phy: power-domain@IMX7_POWER_DOMAIN_PCIE_PHY { That's ugly. Defines in reg is not something we should use generally, IMO. There are a few exceptions for flags. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: fsl,imx-gpcv2: Fix the unit address 2017-12-16 17:53 ` Rob Herring @ 2017-12-16 18:06 ` Fabio Estevam 0 siblings, 0 replies; 3+ messages in thread From: Fabio Estevam @ 2017-12-16 18:06 UTC (permalink / raw) To: Rob Herring Cc: Shawn Guo, Andrey Smirnov, devicetree-u79uwXL29TY76Z2rM5mHXA, Fabio Estevam On Sat, Dec 16, 2017 at 3:53 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > That's ugly. > > Defines in reg is not something we should use generally, IMO. There are > a few exceptions for flags. Sounds good. Just sent a v2 without the defines. Thanks -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-16 18:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-15 2:51 [PATCH] dt-bindings: fsl,imx-gpcv2: Fix the unit address Fabio Estevam
[not found] ` <1513306296-17667-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-16 17:53 ` Rob Herring
2017-12-16 18:06 ` Fabio Estevam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).