Devicetree
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Chris Healy <Chris.Healy@zii.aero>,
	devicetree@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/2] media: coda: Add i.MX51 (CodaHx4) support
Date: Fri, 15 Dec 2017 15:59:05 +0100	[thread overview]
Message-ID: <1513349945.7518.10.camel@pengutronix.de> (raw)
In-Reply-To: <e26f7f6a-afa6-c55c-d94e-095df27c19ae@xs4all.nl>

Hi Hans,

On Fri, 2017-12-15 at 15:22 +0100, Hans Verkuil wrote:
> Hi Philipp,
> 
> On 13/12/17 15:09, Philipp Zabel wrote:
> > Add support for the CodaHx4 VPU used on i.MX51.
> > 
> > Decoding h.264, MPEG-4, and MPEG-2 video works, as well as encoding
> > h.264. MPEG-4 encoding is not enabled, it currently produces visual
> > artifacts.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >  drivers/media/platform/coda/coda-bit.c    | 45 ++++++++++++++++++++++---------
> >  drivers/media/platform/coda/coda-common.c | 44 +++++++++++++++++++++++++++---
> >  drivers/media/platform/coda/coda.h        |  1 +
> >  3 files changed, 74 insertions(+), 16 deletions(-)
> > 
> 
> <snip>
> 
> > +	[CODA_IMX51] = {
> > +		.firmware     = {
> > +			"vpu_fw_imx51.bin",
> > +			"vpu/vpu_fw_imx51.bin",
> > +			"v4l-codahx4-imx51.bin"
> > +		},
> > +		.product      = CODA_HX4,
> > +		.codecs       = codahx4_codecs,
> > +		.num_codecs   = ARRAY_SIZE(codahx4_codecs),
> > +		.vdevs        = codahx4_video_devices,
> > +		.num_vdevs    = ARRAY_SIZE(codahx4_video_devices),
> > +		.workbuf_size = 128 * 1024,
> > +		.tempbuf_size = 304 * 1024,
> > +		.iram_size    = 0x14000,
> > +	},
> 
> What's the status of the firmware? Is it going to be available in some firmware
> repository? I remember when testing other imx devices that it was a bit tricky
> to get hold of the firmware. And googling v4l-codahx4-imx51.bin doesn't find
> anything other than this patch.

As far as I am aware, so far all efforts to get these firmware binaries
relicensed in a way that makes them redistributable in linux-firmware
have not succeeded.

They are distributed by NXP directly in the firmware-imx package.
The http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/ repository
contains links to the latest version:

  wget http://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-5.4.bin
  dd if=firmware-imx-5.4.bin bs=34087 skip=1 | tar xj
  cat firmware-imx-5.4/COPYING

regards
Philipp

  reply	other threads:[~2017-12-15 14:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 14:09 [PATCH 1/2] media: dt-bindings: coda: Add compatible for CodaHx4 on i.MX51 Philipp Zabel
     [not found] ` <20171213140918.22500-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-12-13 14:09   ` [PATCH 2/2] media: coda: Add i.MX51 (CodaHx4) support Philipp Zabel
     [not found]     ` <20171213140918.22500-2-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-12-15 14:22       ` Hans Verkuil
2017-12-15 14:59         ` Philipp Zabel [this message]
2017-12-13 14:21   ` [PATCH 1/2] media: dt-bindings: coda: Add compatible for CodaHx4 on i.MX51 Baruch Siach
2017-12-13 14:52     ` Philipp Zabel
2017-12-15 23:08   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513349945.7518.10.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=Chris.Healy@zii.aero \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@pengutronix.de \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox