From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A862FB609 for ; Mon, 1 Sep 2025 08:38:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756715927; cv=none; b=HUYvL5PPz3HlwFGp8hB08Zquv12dfUAc5RMx+/8+2wFxUgm8p7VeNDx1Wob5yQp5zoSmoWNNdLXpwBf6LOFK7DnTlqhbpfEe+XwWe2O0+r2KGayoCH91PbySJF9fXRHTfvdivPadTVhr5AkPWAHh0t+9x5UG29nunt8q15lnxpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756715927; c=relaxed/simple; bh=ZO87uo9IYsZLjjt/l7L32ClnCZ4s/EkhmsCq9kk/UMQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=RI//Ct6++1B+e6+x6lsApqwaTBsPOU11lNXSrmmJhxdBPKOAft/hDd327uiu9zIr1JVs4Vix7bpRV5G+Qh5i0WftxaNK7Qbn5fPWCoTQJ+M7R0/SMprENF8QX2xHA6FRu9JbgxnxifxlVzYxsFFPOvq2tYFMgXHyFBfIQ/WsmPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jy05AZlF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jy05AZlF" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5818C9ic012132 for ; Mon, 1 Sep 2025 08:38:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1J076/LQgI+3eWtUeFftMALqG6G2irnWWLjDqPX+63E=; b=jy05AZlF4U+KbBD4 TfBvoLftuB4zowARI2w17Xd4334aLgFV0N9EiseTD7BVYVyt1s2s98olfk/rRQ61 E8BHwT8h/dV70f0+LnMtzZWxg6J0NoiJzfF8H65Cd0UJUgTU9ifXOx/Ur731Sece +H39Ax6zrPz/8EE8+xbiW7RA6aWd4iWbixllIWW91gw/G1f7fNREVAH/7ea+IOlq Lzma4heZYFjyDENVOOJ5CqDN0AXAd076JioKunxRpsRwLnw9nAwM8gwNeBlIHnJ0 zA8NbzZlhvhdKiX7peQ7J8+7PD+QmQD8ATQMLkcxMMhmIRqJ4qYIUyvhBxi4Z02u F0Dwwg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48usp7uxm6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 01 Sep 2025 08:38:44 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-76e8ae86ab3so3963619b3a.1 for ; Mon, 01 Sep 2025 01:38:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756715923; x=1757320723; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1J076/LQgI+3eWtUeFftMALqG6G2irnWWLjDqPX+63E=; b=M50DK2rTYBCVGTkbs6G09UHsOcQGi74kUJ3HuFxFxb17cYmlMSzThGNDZr5Hpe+X2A bf65slcOX+Z358WLmWoowY+ajdosri4qqN16IouIct6j14c9YQKjp1INfRmJ7F42qrnn zkVaPEm4VY/2rYUk96X9K7sAQkyK/GEUfPHfI3WZ2KRF68BcqIIGwUXlhbb63tUmLlai 7bfQ2r1UHJBAbpkPU1RSF/HvPFATkGuF+uSTl3zvtvmUgH1lDEQyO6cknzOXyiqN2fnA 0i0rIV5mWlyjvW0OUV8pCAXfqmEemfl5/GUR8anzQFtHNpD5aHJ+v/dezDdo+p5zi6dk y3lg== X-Forwarded-Encrypted: i=1; AJvYcCWq9vSFICMtSW16dblueMM0fbM/nfVA9Y2XvLl9LFyLXIVfkVqC/zd5D/cc1gHpLJagG8473FSp/Zvb@vger.kernel.org X-Gm-Message-State: AOJu0YzUpYaDJ83zsVTazWqYQlWkOlNagtMMPkF1fee44b06FnoZufUp PiFqBF/xFGL6jLOUeJVmwAi/lOcvy7zUlhkuAM1juFE4YA9WnQcR4/jpbxkQz5eIBq2KYX9LQOJ P9DGlM1xELy7RMX3uMr1PHPj6G7v2aCg9sAfA5yjIAkVyXg8fWc1Z9nvd5h2OB+Is X-Gm-Gg: ASbGncvyXdMoSbsEYSxXnZ0Db7scuoMrP5ql6Qdz9GUXvELHgQDGGT8eXhD7jIorEsB bJNGajtzUe/RBXKQkIzdWk9DNGjLJLzGHMiafGyoOl4u/r7GH9WiRilGQQu+D2MJhvYLkC0zyCL pDMrMoNbfBmBz8U2g+RA+kNfrTG4Rpue1E2aU7uKxTLolmuO3BbaZsrI3DFU9Wh4msmDEhyntLe demqKEUwXvpol2gnueXQIYXGI+tIBCIvs/SBEq/fqFkxm/snl6HwWNgWrCTSVgkb4Hx/1Ha2/yU B8lpq8ON/78E435bQdtx7L8c0cns6T43/MmPSdMABa7rwyNsJDPHC8SwNxM/tVJHu8axp6+FJCP qEU0zRQ7Dg/SzY2Svwz/Y0kGrV2vjA06fPQ== X-Received: by 2002:a05:6a00:1789:b0:772:2e00:831f with SMTP id d2e1a72fcca58-7723e1f1deemr10329861b3a.4.1756715923379; Mon, 01 Sep 2025 01:38:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsvQVbqKRANvlU7zeqIf181vFzHz2jPH5oH4pRglmEHl2qc84zDD29EMGRW7zDIDTyLCRwSA== X-Received: by 2002:a05:6a00:1789:b0:772:2e00:831f with SMTP id d2e1a72fcca58-7723e1f1deemr10329810b3a.4.1756715922864; Mon, 01 Sep 2025 01:38:42 -0700 (PDT) Received: from [10.133.33.247] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7722a4beb72sm9925996b3a.61.2025.09.01.01.38.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Sep 2025 01:38:42 -0700 (PDT) Message-ID: <15147896-1378-4a3d-85ba-4258046f9e31@oss.qualcomm.com> Date: Mon, 1 Sep 2025 16:38:39 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] coresight-tnoc: Add runtime PM support for Interconnect TNOC From: yuanfang zhang To: Suzuki K Poulose , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexander Shishkin Cc: kernel@oss.qualcomm.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250831-itnoc-v4-0-f0fb0ef822a5@oss.qualcomm.com> <20250831-itnoc-v4-3-f0fb0ef822a5@oss.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAzNCBTYWx0ZWRfXxSyClg4PQQZf T4PeMsdNIcXU9bFGDSEx8+dAg3cdOq/Td3df8XEIrQS/hkWAcn0D/oeOQtED0hO6juLoGotBCbc VZtRGipif9h3lEPkPNdRA4lpDH64PoAv6UpjH84dDge+hptC+oxX7I849SCcC2GC2Vll6eJsPHe 7rrmdSmnGvgpTBImDm8NKviS/mbDUBJB5x73CjqLzIm1OBy19lSrzcxqUF1kzQAS0oksIQxFeYK VzoytX6WCmoBJiWc3ltQwAkdYW/HJGlNmaiKv0o5t69LC9LRHnB5xp7ib90FRp6ksbOeBX/zpYD hPK3rQJx2NAoSnNVfsMdeO7mgSlxC96Fbm7xvamxWbXp5D4T5S2Zc/bpEsvS0em5M5Y1ntihbf7 auO8aH+M X-Authority-Analysis: v=2.4 cv=e6wGSbp/ c=1 sm=1 tr=0 ts=68b55b94 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=7CQSdrXTAAAA:8 a=ZZ2O94ThGh-PlZ2E-5gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-GUID: nL9R_yjLmo35wwepsKF4RakRPEw32rlw X-Proofpoint-ORIG-GUID: nL9R_yjLmo35wwepsKF4RakRPEw32rlw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-01_04,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300034 Dear all, Apologies — I mistakenly included an unintended attachment in my previous reply regarding the patch submission. Please disregard the attachment; it is not relevant to the discussion. Thank you for your understanding. Best regards, Yuanfang Zhang On 9/1/2025 4:30 PM, yuanfang zhang wrote: > On 9/1/2025 2:58 PM, Yuanfang Zhang wrote: >> This patch adds runtime power management support for platform-based >> CoreSight Interconnect TNOC (ITNOC) devices. It introduces suspend and >> resume callbacks to manage the APB clock (`pclk`) during device runtime >> transitions. >> >> Signed-off-by: Yuanfang Zhang >> --- >> drivers/hwtracing/coresight/coresight-tnoc.c | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tnoc.c b/drivers/hwtracing/coresight/coresight-tnoc.c >> index 5be882300d79bc0173aa6a19d7da1d48c4aaca9c..2c5370497076536bfa868f0d80db775ef242968b 100644 >> --- a/drivers/hwtracing/coresight/coresight-tnoc.c >> +++ b/drivers/hwtracing/coresight/coresight-tnoc.c >> @@ -301,6 +301,28 @@ static void itnoc_remove(struct platform_device *pdev) >> pm_runtime_disable(&pdev->dev); >> } >> >> +#ifdef CONFIG_PM >> +static int itnoc_runtime_suspend(struct device *dev) >> +{ >> + struct trace_noc_drvdata *drvdata = dev_get_drvdata(dev); >> + >> + clk_disable_unprepare(drvdata->pclk); >> + >> + return 0; >> +} >> + >> +static int itnoc_runtime_resume(struct device *dev) >> +{ >> + struct trace_noc_drvdata *drvdata = dev_get_drvdata(dev); >> + >> + return clk_prepare_enable(drvdata->pclk); >> +} >> +#endif >> + >> +static const struct dev_pm_ops itnoc_dev_pm_ops = { >> + SET_RUNTIME_PM_OPS(itnoc_runtime_suspend, itnoc_runtime_resume, NULL) >> +}; >> + >> static const struct of_device_id itnoc_of_match[] = { >> { .compatible = "qcom,coresight-itnoc" }, >> {} >> @@ -314,6 +336,7 @@ static struct platform_driver itnoc_driver = { >> .name = "coresight-itnoc", >> .of_match_table = itnoc_of_match, >> .suppress_bind_attrs = true, >> + .pm = &itnoc_dev_pm_ops, >> }, >> }; >> >> > > missed Reviewed-by: Leo Yan tag. > > thanks, > yuanfang.