* [PATCH] arm64: dts: add #cooling-cells to CPU nodes
@ 2018-01-10 21:06 Arnd Bergmann
[not found] ` <20180110210706.2331225-1-arnd-r2nGTMty4D4@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2018-01-10 21:06 UTC (permalink / raw)
To: Matthias Brugger
Cc: arm-DgEjT+Ai2ygdnm+yROfE0A, Arnd Bergmann, Rob Herring,
Mark Rutland, Catalin Marinas, Will Deacon, Chunfeng Yun,
Daniel Kurtz, Andrew-sh Cheng, Chaotian Jing,
dawei.chien-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
dtc complains about the lack of #coolin-cells properties for the
CPU nodes that are referred to as "cooling-device":
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@0:cooling-device[0])
arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@100 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@1:cooling-device[0])
Apparently this property must be '<2>' to match the binding.
Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
---
If this looks ok, I'd apply it directly to the fixes branch
for 4.15, as the warning is one that was introduced in this
release.
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index b477ad790071..9fbe4705ee88 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -155,6 +155,7 @@
reg = <0x000>;
enable-method = "psci";
cpu-idle-states = <&CPU_SLEEP_0>;
+ #cooling-cells = <2>;
clocks = <&infracfg CLK_INFRA_CA53SEL>,
<&apmixedsys CLK_APMIXED_MAINPLL>;
clock-names = "cpu", "intermediate";
@@ -179,6 +180,7 @@
reg = <0x100>;
enable-method = "psci";
cpu-idle-states = <&CPU_SLEEP_0>;
+ #cooling-cells = <2>;
clocks = <&infracfg CLK_INFRA_CA57SEL>,
<&apmixedsys CLK_APMIXED_MAINPLL>;
clock-names = "cpu", "intermediate";
--
2.9.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20180110210706.2331225-1-arnd-r2nGTMty4D4@public.gmane.org>]
* Re: [PATCH] arm64: dts: add #cooling-cells to CPU nodes [not found] ` <20180110210706.2331225-1-arnd-r2nGTMty4D4@public.gmane.org> @ 2018-01-11 0:38 ` Chunfeng Yun 2018-01-12 2:00 ` Olof Johansson 0 siblings, 1 reply; 3+ messages in thread From: Chunfeng Yun @ 2018-01-11 0:38 UTC (permalink / raw) To: Arnd Bergmann Cc: Matthias Brugger, arm-DgEjT+Ai2ygdnm+yROfE0A, Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Daniel Kurtz, Andrew-sh Cheng, Chaotian Jing, dawei.chien-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Wed, 2018-01-10 at 22:06 +0100, Arnd Bergmann wrote: > dtc complains about the lack of #coolin-cells properties for the > CPU nodes that are referred to as "cooling-device": > > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@0:cooling-device[0]) > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@100 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@1:cooling-device[0]) > > Apparently this property must be '<2>' to match the binding. > > Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> > --- > If this looks ok, I'd apply it directly to the fixes branch > for 4.15, as the warning is one that was introduced in this > release. > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index b477ad790071..9fbe4705ee88 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -155,6 +155,7 @@ > reg = <0x000>; > enable-method = "psci"; > cpu-idle-states = <&CPU_SLEEP_0>; > + #cooling-cells = <2>; > clocks = <&infracfg CLK_INFRA_CA53SEL>, > <&apmixedsys CLK_APMIXED_MAINPLL>; > clock-names = "cpu", "intermediate"; > @@ -179,6 +180,7 @@ > reg = <0x100>; > enable-method = "psci"; > cpu-idle-states = <&CPU_SLEEP_0>; > + #cooling-cells = <2>; > clocks = <&infracfg CLK_INFRA_CA57SEL>, > <&apmixedsys CLK_APMIXED_MAINPLL>; > clock-names = "cpu", "intermediate"; Tested-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: add #cooling-cells to CPU nodes 2018-01-11 0:38 ` Chunfeng Yun @ 2018-01-12 2:00 ` Olof Johansson 0 siblings, 0 replies; 3+ messages in thread From: Olof Johansson @ 2018-01-12 2:00 UTC (permalink / raw) To: Chunfeng Yun Cc: Mark Rutland, devicetree, arm, Arnd Bergmann, Catalin Marinas, Will Deacon, linux-kernel, Daniel Kurtz, dawei.chien@mediatek.com, Rob Herring, linux-mediatek, linux-arm-kernel, Matthias Brugger, Chaotian Jing, Andrew-sh Cheng On Thu, Jan 11, 2018 at 08:38:30AM +0800, Chunfeng Yun wrote: > On Wed, 2018-01-10 at 22:06 +0100, Arnd Bergmann wrote: > > dtc complains about the lack of #coolin-cells properties for the > > CPU nodes that are referred to as "cooling-device": > > > > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@0 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@0:cooling-device[0]) > > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: Warning (cooling_device_property): Missing property '#cooling-cells' in node /cpus/cpu@100 or bad phandle (referred from /thermal-zones/cpu_thermal/cooling-maps/map@1:cooling-device[0]) > > > > Apparently this property must be '<2>' to match the binding. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > > If this looks ok, I'd apply it directly to the fixes branch > > for 4.15, as the warning is one that was introduced in this > > release. Actually, it's in next/dt (or at least this patch doesn't apply as it is to fixes), so I've added it there. -Olof ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-12 2:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-10 21:06 [PATCH] arm64: dts: add #cooling-cells to CPU nodes Arnd Bergmann
[not found] ` <20180110210706.2331225-1-arnd-r2nGTMty4D4@public.gmane.org>
2018-01-11 0:38 ` Chunfeng Yun
2018-01-12 2:00 ` Olof Johansson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).