From: Ryder Lee <ryder.lee@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org,
Garlic Tseng <garlic.tseng@mediatek.com>
Subject: Re: [PATCH v2 2/5] clk: mediatek: modify MT7622 audsys to adapt MFD device
Date: Mon, 5 Feb 2018 12:07:35 +0800 [thread overview]
Message-ID: <1517803655.1173.12.camel@mtkswgap22> (raw)
In-Reply-To: <72058f8d-c83d-d0e6-dc07-83c9f5fc2710@gmail.com>
On Sat, 2018-02-03 at 15:26 +0100, Matthias Brugger wrote:
>
> On 01/31/2018 08:42 AM, Ryder Lee wrote:
> > As the new MFD parent is in place, switch probing method to adapt it.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > ---
> > drivers/clk/mediatek/clk-mt7622-aud.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c
> > index 13f752d..8c18536 100644
> > --- a/drivers/clk/mediatek/clk-mt7622-aud.c
> > +++ b/drivers/clk/mediatek/clk-mt7622-aud.c
> > @@ -142,11 +142,12 @@ static int clk_mt7622_audiosys_init(struct platform_device *pdev)
> > {
> > struct clk_onecell_data *clk_data;
> > struct device_node *node = pdev->dev.of_node;
> > + struct device_node *pnode = pdev->dev.parent->of_node;
> > int r;
> >
> > clk_data = mtk_alloc_clk_data(CLK_AUDIO_NR_CLK);
> >
> > - mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks),
> > + mtk_clk_register_gates(pnode, audio_clks, ARRAY_SIZE(audio_clks),
>
> We will need a fallback here for older device tree bindings.
>
> Regards,
> Matthias
Up to now, I didn't see both driver and bindings are used anywhere.
Should I still care about that?
Thanks.
next prev parent reply other threads:[~2018-02-05 4:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 7:42 [PATCH v2 0/5] add MFD support for MediaTek audio subsystem Ryder Lee
2018-01-31 7:42 ` [PATCH v2 1/5] clk: mediatek: update missing clock data for MT7622 audsys Ryder Lee
2018-02-05 6:08 ` Rob Herring
[not found] ` <cover.1515639336.git.ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-01-31 7:42 ` [PATCH v2 2/5] clk: mediatek: modify MT7622 audsys to adapt MFD device Ryder Lee
[not found] ` <d6669277f5232446b4798a6b724074b18d5c21aa.1515639336.git.ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-02-03 14:26 ` Matthias Brugger
2018-02-05 4:07 ` Ryder Lee [this message]
2018-02-07 15:18 ` Matthias Brugger
2018-02-08 5:57 ` Ryder Lee
2018-02-09 13:24 ` Matthias Brugger
2018-01-31 7:42 ` [PATCH v2 3/5] clk: mediatek: add audsys support for MT2701 Ryder Lee
2018-01-31 7:42 ` [PATCH v2 4/5] dt-bindings: clock: mediatek: update audsys documentation to adapt MFD device Ryder Lee
2018-02-05 6:08 ` Rob Herring
2018-02-05 9:11 ` Ryder Lee
2018-02-08 0:49 ` Rob Herring
2018-02-08 5:51 ` Ryder Lee
2018-01-31 7:42 ` [PATCH v2 5/5] arm: dts: mediatek: add audio-subsystem node for both MT2701 and MT7623 Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517803655.1173.12.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=garlic.tseng@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).