From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryder Lee Subject: Re: [PATCH v2 2/5] clk: mediatek: modify MT7622 audsys to adapt MFD device Date: Mon, 5 Feb 2018 12:07:35 +0800 Message-ID: <1517803655.1173.12.camel@mtkswgap22> References: <72058f8d-c83d-d0e6-dc07-83c9f5fc2710@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <72058f8d-c83d-d0e6-dc07-83c9f5fc2710@gmail.com> Sender: linux-clk-owner@vger.kernel.org To: Matthias Brugger Cc: Stephen Boyd , Rob Herring , Mark Brown , Lee Jones , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Garlic Tseng List-Id: devicetree@vger.kernel.org On Sat, 2018-02-03 at 15:26 +0100, Matthias Brugger wrote: > > On 01/31/2018 08:42 AM, Ryder Lee wrote: > > As the new MFD parent is in place, switch probing method to adapt it. > > > > Signed-off-by: Ryder Lee > > --- > > drivers/clk/mediatek/clk-mt7622-aud.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/clk/mediatek/clk-mt7622-aud.c b/drivers/clk/mediatek/clk-mt7622-aud.c > > index 13f752d..8c18536 100644 > > --- a/drivers/clk/mediatek/clk-mt7622-aud.c > > +++ b/drivers/clk/mediatek/clk-mt7622-aud.c > > @@ -142,11 +142,12 @@ static int clk_mt7622_audiosys_init(struct platform_device *pdev) > > { > > struct clk_onecell_data *clk_data; > > struct device_node *node = pdev->dev.of_node; > > + struct device_node *pnode = pdev->dev.parent->of_node; > > int r; > > > > clk_data = mtk_alloc_clk_data(CLK_AUDIO_NR_CLK); > > > > - mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks), > > + mtk_clk_register_gates(pnode, audio_clks, ARRAY_SIZE(audio_clks), > > We will need a fallback here for older device tree bindings. > > Regards, > Matthias Up to now, I didn't see both driver and bindings are used anywhere. Should I still care about that? Thanks.