From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Wang Subject: Re: [PATCH v2 06/16] arm64: dts: mt7622: add cpufreq related device nodes Date: Wed, 7 Feb 2018 14:16:18 +0800 Message-ID: <1517984178.9025.2.camel@mtkswgap22> References: <20180207033331.GK28462@vireshk-i7> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180207033331.GK28462@vireshk-i7> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Viresh Kumar Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 2018-02-07 at 09:03 +0530, Viresh Kumar wrote: > On 06-02-18, 17:52, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > > cpus { > > #address-cells = <2>; > > #size-cells = <0>; > > @@ -26,6 +70,10 @@ > > device_type = "cpu"; > > compatible = "arm,cortex-a53", "arm,armv8"; > > reg = <0x0 0x0>; > > + clocks = <&infracfg CLK_INFRA_MUX1_SEL>, > > + <&apmixedsys CLK_APMIXED_MAIN_CORE_EN>; > > + clock-names = "cpu", "intermediate"; > > + operating-points-v2 = <&cpu_opp_table>; > > enable-method = "psci"; > > clock-frequency = <1300000000>; > > }; > > @@ -34,6 +82,7 @@ > > device_type = "cpu"; > > compatible = "arm,cortex-a53", "arm,armv8"; > > reg = <0x0 0x1>; > > + operating-points-v2 = <&cpu_opp_table>; > > enable-method = "psci"; > > clock-frequency = <1300000000>; > > }; > > Sorry for not picking this earlier, but you should probably add the same clock > related properties for both cpu nodes here. Things will break if CPU1 is used by > the cpufreq core to bring the cpufreq policy online. > > This can happen if cpufreq driver is a module, CPU0 is hotplugged out and then > the cpufreq driver is inserted. > mt7622 cpu0 does not support hotplug. do I still need to add same clock related properties for both cpu nodes here? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html