From: Cosmin Samoila <cosmin.samoila@nxp.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wakasugi.jb@om.asahi-kasei.co.jp"
<wakasugi.jb@om.asahi-kasei.co.jp>,
dl-linux-imx <linux-imx@nxp.com>,
"mihai.serban@nxp.com" <mihai.serban@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"mihai.serban@gmail.com" <mihai.serban@gmail.com>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver
Date: Tue, 13 Feb 2018 09:22:24 +0000 [thread overview]
Message-ID: <1518513744.25655.8.camel@nxp.com> (raw)
In-Reply-To: <20180131170330.GB7763@sirena.org.uk>
Hi Mark,
> >
> > +static int ak4458_hw_params(struct snd_pcm_substream *substream,
> > + struct snd_pcm_hw_params *params,
> > + struct snd_soc_dai *dai)
> > +{
> > + struct snd_soc_codec *codec = dai->codec;
> > + struct ak4458_priv *ak4458 =
> > snd_soc_codec_get_drvdata(codec);
> > + u8 format;
> > + int pcm_width = max(params_physical_width(params), ak4458-
> > >slot_width);
> > +
> > +#ifdef AK4458_ACKS_USE_MANUAL_MODE
> > + u8 dfs1, dfs2;
> > +#endif
> What's this and why is it a compile time option?
This is used to set the codec in Manual Setting Mode, meaning that
the default sampling speed is set based on DFS0 and DFS1 bits. In
Auto Setting Mode, the MCLK frequency is detected automatically and
DFS bits are ignored.
This compile time option is used to know when to set the ACKS bit in
init_reg function that switches between modes.
At this moment we are only using Auto Mode and I can remove it if
you think is not necessary.
Thank you,
Cosmin
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2018-02-13 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 13:20 [PATCH] ASoC: codecs: Add support for AK4458 DAC driver Cosmin-Gabriel Samoila
2018-01-31 17:03 ` Mark Brown
[not found] ` <20180131170330.GB7763-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-09 10:22 ` Cosmin Samoila
2018-02-09 15:47 ` Mark Brown
2018-02-13 9:22 ` Cosmin Samoila [this message]
2018-02-13 11:55 ` Mark Brown
2018-02-05 6:08 ` Rob Herring
[not found] ` <1517404809-25250-1-git-send-email-cosmin.samoila-3arQi8VN3Tc@public.gmane.org>
2018-02-12 12:47 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518513744.25655.8.camel@nxp.com \
--to=cosmin.samoila@nxp.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.serban@gmail.com \
--cc=mihai.serban@nxp.com \
--cc=shengjiu.wang@nxp.com \
--cc=wakasugi.jb@om.asahi-kasei.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).