[RFC] ARM: dts: imx28-tx28: Pass the memory unit name

[RFC] ARM: dts: imx28-tx28: Pass the memory unit name

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

Pass the memory unit name in order to fix the following
dtc warning with W=1:

arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Hi,

Currently the only dtc warnings observed with W=1 are the ones:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

If this solution can be accepted I can clean all the other i.MX dts files.

Please advise.

 arch/arm/boot/dts/imx28-tx28.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index 8a4f5bc..bbdf004 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -65,8 +65,8 @@
 		usbotg = &usb0;
 	};
 
-	memory {
-		reg = <0 0>; /* will be filled in by U-Boot */
+	memory@40000000 {
+		reg = <0x40000000 0>; /* will be filled in by U-Boot */
 	};
 
 	onewire {
-- 
2.7.4

Re: [RFC] ARM: dts: imx28-tx28: Pass the memory unit name

[Lothar Waßmann]

Hi,

On Sat, 17 Feb 2018 13:41:43 -0200 Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Pass the memory unit name in order to fix the following
> dtc warning with W=1:
> 
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Hi,
> 
> Currently the only dtc warnings observed with W=1 are the ones:
> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
> 
> If this solution can be accepted I can clean all the other i.MX dts files.
> 
> Please advise.
> 
>  arch/arm/boot/dts/imx28-tx28.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index 8a4f5bc..bbdf004 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -65,8 +65,8 @@
>  		usbotg = &usb0;
>  	};
>  
> -	memory {
> -		reg = <0 0>; /* will be filled in by U-Boot */
> +	memory@40000000 {
> +		reg = <0x40000000 0>; /* will be filled in by U-Boot */
>  	};
>  
>  	onewire {
>
I have no objections to this change. U-Boot still finds the memory node
and puts the correct size into the 'reg' property.

Acked-by: Lothar Waßmann <LW@KARO-electronics.de>


Lothar Waßmann

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [RFC] ARM: dts: imx28-tx28: Pass the memory unit name

[Shawn Guo]

On Sat, Feb 17, 2018 at 01:41:43PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Pass the memory unit name in order to fix the following
> dtc warning with W=1:
> 
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.