From: Geert Uytterhoeven <geert+renesas@glider.be>
To: David Gibson <david@gibson.dropbear.id.au>, Jon Loeliger <jdl@jdl.com>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree-compiler@vger.kernel.org, devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH/RFC dtc 0/2] Drop unit addresses from overlay fragments
Date: Fri, 23 Feb 2018 09:35:15 +0100 [thread overview]
Message-ID: <1519374917-30171-1-git-send-email-geert+renesas@glider.be> (raw)
Hi all,
Using "fragment@N" as node name for overlay fragments violates unit
address rules:
<stdout>: Warning (unit_address_vs_reg): Node /fragment@0 has a unit name, but no reg property
This patch series (for dtc) fixes:
1. generation of node names when using overlay sugar syntax,
2. all documentation and tests.
If this is accepted, I'll send similar patches for Linux.
Note that I've been using "fragment-N" in hand-written DT overlays for
years, so this is known to work fine with Linux.
Thanks for your comments!
Geert Uytterhoeven (2):
overlay: Do not use @ in overlay fragment generation
Use "fragment-N" instead of "fragment@N"
Documentation/dt-object-internal.txt | 20 +++++++--------
livetree.c | 2 +-
tests/overlay_bad_fixup_bad_index.dts | 2 +-
tests/overlay_bad_fixup_base.dtsi | 2 +-
tests/overlay_bad_fixup_empty_index.dts | 2 +-
tests/overlay_bad_fixup_index_trailing.dts | 2 +-
tests/overlay_bad_fixup_path_empty_prop.dts | 2 +-
tests/overlay_bad_fixup_path_only.dts | 2 +-
tests/overlay_bad_fixup_path_only_sep.dts | 2 +-
tests/overlay_bad_fixup_path_prop.dts | 2 +-
tests/overlay_overlay.dts | 16 ++++++------
tests/overlay_overlay_manual_fixups.dts | 38 ++++++++++++++---------------
tests/overlay_overlay_no_fixups.dts | 16 ++++++------
tests/stacked_overlay_bar.dts | 2 +-
tests/stacked_overlay_baz.dts | 2 +-
15 files changed, 56 insertions(+), 56 deletions(-)
--
2.7.4
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2018-02-23 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 8:35 Geert Uytterhoeven [this message]
2018-02-23 8:35 ` [PATCH/RFC dtc 1/2] overlay: Do not use @ in overlay fragment generation Geert Uytterhoeven
2018-02-23 8:35 ` [PATCH/RFC dtc 2/2] Use "fragment-N" instead of "fragment@N" Geert Uytterhoeven
2018-03-05 6:40 ` [PATCH/RFC dtc 0/2] Drop unit addresses from overlay fragments David Gibson
2018-03-07 3:34 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519374917-30171-1-git-send-email-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jdl@jdl.com \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).