devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: David Gibson <david@gibson.dropbear.id.au>, Jon Loeliger <jdl@jdl.com>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree-compiler@vger.kernel.org, devicetree@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH/RFC dtc 1/2] overlay: Do not use @ in overlay fragment generation
Date: Fri, 23 Feb 2018 09:35:16 +0100	[thread overview]
Message-ID: <1519374917-30171-2-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1519374917-30171-1-git-send-email-geert+renesas@glider.be>

Fragments generated from overlay sugar syntax violate unit address
rules:

    <stdout>: Warning (unit_address_vs_reg): Node /fragment@0 has a unit name, but no reg property

Use "fragment-N" instead of "fragment@N" to fix this.

Fixes: 737b2df39cc8c566 ("overlay: Add syntactic sugar version of overlays")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 livetree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/livetree.c b/livetree.c
index 57b7db2ed1534873..a87a1262459c830e 100644
--- a/livetree.c
+++ b/livetree.c
@@ -229,7 +229,7 @@ struct node * add_orphan_node(struct node *dt, struct node *new_node, char *ref)
 
 	p = build_property("target", d);
 
-	xasprintf(&name, "fragment@%u",
+	xasprintf(&name, "fragment-%u",
 			next_orphan_fragment++);
 	name_node(new_node, "__overlay__");
 	node = build_node(p, new_node);
-- 
2.7.4


  reply	other threads:[~2018-02-23  8:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23  8:35 [PATCH/RFC dtc 0/2] Drop unit addresses from overlay fragments Geert Uytterhoeven
2018-02-23  8:35 ` Geert Uytterhoeven [this message]
2018-02-23  8:35 ` [PATCH/RFC dtc 2/2] Use "fragment-N" instead of "fragment@N" Geert Uytterhoeven
2018-03-05  6:40 ` [PATCH/RFC dtc 0/2] Drop unit addresses from overlay fragments David Gibson
2018-03-07  3:34   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519374917-30171-2-git-send-email-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=david@gibson.dropbear.id.au \
    --cc=devicetree-compiler@vger.kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=jdl@jdl.com \
    --cc=pantelis.antoniou@konsulko.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).