[PATCH] arm64: dts: ls1046a: drop incomplete memory node

[PATCH] arm64: dts: ls1046a: drop incomplete memory node

[Shawn Guo]

The memory node in fsl-ls1046a.dtsi has no 'reg' property, and causes
the dtc warning below.

Warning (unit_address_vs_reg): Node /memory@80000000 has a unit name, but no reg property

This is clearly an incomplete memory node.  Let's drop it.  Either
a complete memory should be added, or bootloader needs to fill the node
as a whole.

Cc: Mingkai Hu <Mingkai.Hu@nxp.com>
Cc: Shaohui Xie <Shaohui.Xie@nxp.com>
Cc: Li Yang <leoyang.li@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 606ea496f24e..cbf4b3e15c17 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -129,10 +129,6 @@
 		};
 	};
 
-	memory@80000000 {
-		device_type = "memory";
-	};
-
 	sysclk: sysclk {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
-- 
1.9.1

RE: [PATCH] arm64: dts: ls1046a: drop incomplete memory node

[Leo Li]

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Saturday, February 24, 2018 3:05 PM
> To: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org; Shawn Guo <shawnguo@kernel.org>;
> Mingkai Hu <mingkai.hu@nxp.com>; Shaohui Xie <Shaohui.Xie@nxp.com>;
> Leo Li <leoyang.li@nxp.com>
> Subject: [PATCH] arm64: dts: ls1046a: drop incomplete memory node
> 
> The memory node in fsl-ls1046a.dtsi has no 'reg' property, and causes the
> dtc warning below.
> 
> Warning (unit_address_vs_reg): Node /memory@80000000 has a unit name,
> but no reg property
> 
> This is clearly an incomplete memory node.  Let's drop it.  Either a complete
> memory should be added, or bootloader needs to fill the node as a whole.

Or we can put in a dummy reg property to be updated by bootloader like the mac-address property?

> 
> Cc: Mingkai Hu <Mingkai.Hu@nxp.com>
> Cc: Shaohui Xie <Shaohui.Xie@nxp.com>
> Cc: Li Yang <leoyang.li@nxp.com>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 606ea496f24e..cbf4b3e15c17 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -129,10 +129,6 @@
>  		};
>  	};
> 
> -	memory@80000000 {
> -		device_type = "memory";
> -	};
> -
>  	sysclk: sysclk {
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
> --
> 1.9.1

Re: [PATCH] arm64: dts: ls1046a: drop incomplete memory node

[Shawn Guo]

On Mon, Feb 26, 2018 at 01:33:34AM +0000, Leo Li wrote:
> 
> 
> > -----Original Message-----
> > From: Shawn Guo [mailto:shawnguo@kernel.org]
> > Sent: Saturday, February 24, 2018 3:05 PM
> > To: linux-arm-kernel@lists.infradead.org
> > Cc: devicetree@vger.kernel.org; Shawn Guo <shawnguo@kernel.org>;
> > Mingkai Hu <mingkai.hu@nxp.com>; Shaohui Xie <Shaohui.Xie@nxp.com>;
> > Leo Li <leoyang.li@nxp.com>
> > Subject: [PATCH] arm64: dts: ls1046a: drop incomplete memory node
> > 
> > The memory node in fsl-ls1046a.dtsi has no 'reg' property, and causes the
> > dtc warning below.
> > 
> > Warning (unit_address_vs_reg): Node /memory@80000000 has a unit name,
> > but no reg property
> > 
> > This is clearly an incomplete memory node.  Let's drop it.  Either a complete
> > memory should be added, or bootloader needs to fill the node as a whole.
> 
> Or we can put in a dummy reg property to be updated by bootloader like the mac-address property?

Yeah, I'm fine with either way, as long as we get rid of the warning.
I will post v2 shortly.

Shawn