From: Li Jun <jun.li@nxp.com>
To: gregkh@linuxfoundation.org, robh+dt@kernel.org,
heikki.krogerus@linux.intel.com, linux@roeck-us.net
Cc: a.hajda@samsung.com, mark.rutland@arm.com, jun.li@nxp.com,
yueyao@google.com, peter.chen@nxp.com, garsilva@embeddedor.com,
o_leveque@orange.fr, shufan_lee@richtek.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-imx@nxp.com
Subject: [PATCH v2 09/12] staging: typec: tcpci: Only touch target bit when enable vconn
Date: Mon, 26 Feb 2018 19:49:16 +0800 [thread overview]
Message-ID: <1519645759-12701-10-git-send-email-jun.li@nxp.com> (raw)
In-Reply-To: <1519645759-12701-1-git-send-email-jun.li@nxp.com>
We need regmap_update_bits to avoid touch any other bits when
enable or disable vconn.
Signed-off-by: Li Jun <jun.li@nxp.com>
---
drivers/staging/typec/tcpci.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 7145771..27d53c6 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c
@@ -213,14 +213,10 @@ static int tcpci_set_polarity(struct tcpc_dev *tcpc,
static int tcpci_set_vconn(struct tcpc_dev *tcpc, bool enable)
{
struct tcpci *tcpci = tcpc_to_tcpci(tcpc);
- int ret;
- ret = regmap_write(tcpci->regmap, TCPC_POWER_CTRL,
- enable ? TCPC_POWER_CTRL_VCONN_ENABLE : 0);
- if (ret < 0)
- return ret;
-
- return 0;
+ return regmap_update_bits(tcpci->regmap, TCPC_POWER_CTRL,
+ TCPC_POWER_CTRL_VCONN_ENABLE,
+ enable ? TCPC_POWER_CTRL_VCONN_ENABLE : 0);
}
static int tcpci_set_roles(struct tcpc_dev *tcpc, bool attached,
--
2.7.4
next prev parent reply other threads:[~2018-02-26 12:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 11:49 [PATCH v2 00/12] staging: typec: tcpci: move out of staging Li Jun
2018-02-26 11:49 ` [PATCH v2 01/12] usb: typec: add API to get port type and preferred role Li Jun
2018-02-26 13:19 ` Heikki Krogerus
2018-03-05 7:54 ` Jun Li
2018-02-26 11:49 ` [PATCH v2 02/12] usb: typec: add API to get sink and source config Li Jun
2018-02-26 13:32 ` Heikki Krogerus
2018-03-05 8:40 ` Jun Li
2018-02-26 11:49 ` [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt Li Jun
2018-02-26 14:06 ` Heikki Krogerus
2018-02-26 14:30 ` Jun Li
2018-02-27 11:03 ` Heikki Krogerus
2018-03-05 8:53 ` Jun Li
2018-03-05 9:53 ` Heikki Krogerus
2018-03-05 10:35 ` Jun Li
2018-03-05 11:30 ` Heikki Krogerus
2018-03-05 12:38 ` Jun Li
2018-02-26 11:49 ` [PATCH v2 04/12] staging: typec: tcpci: register port before request irq Li Jun
2018-02-26 11:49 ` [PATCH v2 05/12] staging: typec: tcpci: enable vbus detection Li Jun
2018-02-26 11:49 ` [PATCH v2 06/12] typec: tcpm: add starting value for drp toggling Li Jun
2018-02-26 11:49 ` [PATCH v2 07/12] staging: typec: tcpci: correct " Li Jun
2018-02-26 11:49 ` [PATCH v2 08/12] staging: typec: tcpci: keep the uncontact cc line open Li Jun
2018-02-26 11:49 ` Li Jun [this message]
2018-02-26 11:49 ` [PATCH v2 10/12] dt-bindings: connector: add properties for typec power delivery Li Jun
2018-02-27 8:41 ` Andrzej Hajda
2018-03-02 22:38 ` Rob Herring
2018-03-05 7:52 ` Jun Li
2018-03-05 12:25 ` Jun Li
2018-03-05 7:00 ` Jun Li
2018-03-05 9:59 ` Andrzej Hajda
2018-03-06 9:38 ` Jun Li
2018-03-06 11:54 ` Andrzej Hajda
2018-03-06 12:02 ` Heikki Krogerus
2018-03-08 1:41 ` Jun Li
2018-03-09 7:34 ` Heikki Krogerus
2018-03-02 22:29 ` Rob Herring
2018-03-05 7:07 ` Jun Li
2018-02-26 11:49 ` [PATCH v2 11/12] dt-bindings: usb: add documentation for typec port controller(TCPCI) Li Jun
2018-03-02 22:56 ` Rob Herring
2018-02-26 11:49 ` [PATCH v2 12/12] staging: typec: tcpci: move tcpci driver out of staging Li Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519645759-12701-10-git-send-email-jun.li@nxp.com \
--to=jun.li@nxp.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=o_leveque@orange.fr \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
--cc=yueyao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).