[PATCH 0/4] dt-bindings: arm: Improve Renesas Board Documentation

[PATCH 0/4] dt-bindings: arm: Improve Renesas Board Documentation

[Geert Uytterhoeven]

	Hi Simon, Magnus,

This patch series improves the DT binding documentation for Renesas
boards.

Thanks!

Geert Uytterhoeven (4):
  dt-bindings: arm: Document SoC compatible value for Armadillo-800 EVA
  dt-bindings: arm: Document Renesas V3MSK and Wheat board part numbers
  dt-bindings: arm: Document Renesas R-Car M3-N-based Salvator-X board
  dt-bindings: arm: Document Renesas R-Car M3-N-based Salvator-XS board

 Documentation/devicetree/bindings/arm/shmobile.txt | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

-- 
2.7.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/4] dt-bindings: arm: Document SoC compatible value for Armadillo-800 EVA

[Geert Uytterhoeven]

The compatible property of the root node in a DTS for Atmark Techno
Armadillo-800 EVA should include the compatible value for the R-Mobile
A1 SoC, too.

Fixes: d2c2a0776899ba2d ("ARM: shmobile: Add platform device tree bindings documentation")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/arm/shmobile.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index 63edc11e83ef287f..ded2cd3b5f4df0c8 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -56,7 +56,7 @@ Boards:
   - APE6-EVM
     compatible = "renesas,ape6evm", "renesas,r8a73a4"
   - Atmark Techno Armadillo-800 EVA
-    compatible = "renesas,armadillo800eva"
+    compatible = "renesas,armadillo800eva", "renesas,r8a7740"
   - Blanche (RTP0RC7792SEB00010S)
     compatible = "renesas,blanche", "renesas,r8a7792"
   - BOCK-W
-- 
2.7.4

Re: [PATCH 1/4] dt-bindings: arm: Document SoC compatible value for Armadillo-800 EVA

[Simon Horman]

On Mon, Feb 26, 2018 at 07:03:42PM +0100, Geert Uytterhoeven wrote:
> The compatible property of the root node in a DTS for Atmark Techno
> Armadillo-800 EVA should include the compatible value for the R-Mobile
> A1 SoC, too.
> 
> Fixes: d2c2a0776899ba2d ("ARM: shmobile: Add platform device tree bindings documentation")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied.

[PATCH 2/4] dt-bindings: arm: Document Renesas V3MSK and Wheat board part numbers

[Geert Uytterhoeven]

The DT binding documentation for the Renesas V3MSK and Wheat boards
lacked board part numbers.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/arm/shmobile.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index ded2cd3b5f4df0c8..82908a9447e4b051 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -120,9 +120,9 @@ Boards:
     compatible = "renesas,sk-rzg1m", "renesas,r8a7743"
   - Stout (ADAS Starterkit, Y-R-CAR-ADAS-SKH2-BOARD)
     compatible = "renesas,stout", "renesas,r8a7790"
-  - V3MSK
+  - V3MSK (Y-ASK-RCAR-V3M-WS10)
     compatible = "renesas,v3msk", "renesas,r8a77970"
-  - Wheat
+  - Wheat (RTP0RC7792ASKB0010JE)
     compatible = "renesas,wheat", "renesas,r8a7792"
 
 
-- 
2.7.4

Re: [PATCH 2/4] dt-bindings: arm: Document Renesas V3MSK and Wheat board part numbers

[Simon Horman]

On Mon, Feb 26, 2018 at 07:03:43PM +0100, Geert Uytterhoeven wrote:
> The DT binding documentation for the Renesas V3MSK and Wheat boards
> lacked board part numbers.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/arm/shmobile.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
> index ded2cd3b5f4df0c8..82908a9447e4b051 100644
> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> @@ -120,9 +120,9 @@ Boards:
>      compatible = "renesas,sk-rzg1m", "renesas,r8a7743"
>    - Stout (ADAS Starterkit, Y-R-CAR-ADAS-SKH2-BOARD)
>      compatible = "renesas,stout", "renesas,r8a7790"
> -  - V3MSK
> +  - V3MSK (Y-ASK-RCAR-V3M-WS10)
>      compatible = "renesas,v3msk", "renesas,r8a77970"

Google also tells me there is WS20, but I guess WS10 what is
currently supported upstream.

> -  - Wheat
> +  - Wheat (RTP0RC7792ASKB0010JE)
>      compatible = "renesas,wheat", "renesas,r8a7792"

I'm unable to confirm the above. Can anyone help?

Re: [PATCH 2/4] dt-bindings: arm: Document Renesas V3MSK and Wheat board part numbers

[Sergei Shtylyov]

Hello!

On 02/27/2018 11:17 AM, Simon Horman wrote:

>> The DT binding documentation for the Renesas V3MSK and Wheat boards
>> lacked board part numbers.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>>  Documentation/devicetree/bindings/arm/shmobile.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
>> index ded2cd3b5f4df0c8..82908a9447e4b051 100644
>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
>> @@ -120,9 +120,9 @@ Boards:
>>      compatible = "renesas,sk-rzg1m", "renesas,r8a7743"
>>    - Stout (ADAS Starterkit, Y-R-CAR-ADAS-SKH2-BOARD)
>>      compatible = "renesas,stout", "renesas,r8a7790"
>> -  - V3MSK
>> +  - V3MSK (Y-ASK-RCAR-V3M-WS10)

   ACK.

>>      compatible = "renesas,v3msk", "renesas,r8a77970"
> 
> Google also tells me there is WS20, but I guess WS10 what is
> currently supported upstream.

   At least that's what I have on my desk. :-)

>> -  - Wheat
>> +  - Wheat (RTP0RC7792ASKB0010JE)
>>      compatible = "renesas,wheat", "renesas,r8a7792"
> 
> I'm unable to confirm the above. Can anyone help?

   Not me -- my documents don't mention this. :-(

MBR, Sergei

Re: [PATCH 2/4] dt-bindings: arm: Document Renesas V3MSK and Wheat board part numbers

[Simon Horman]

On Tue, Feb 27, 2018 at 01:47:09PM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 02/27/2018 11:17 AM, Simon Horman wrote:

...

> >> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
> >> index ded2cd3b5f4df0c8..82908a9447e4b051 100644
> >> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> >> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> >> @@ -120,9 +120,9 @@ Boards:
> >>      compatible = "renesas,sk-rzg1m", "renesas,r8a7743"
> >>    - Stout (ADAS Starterkit, Y-R-CAR-ADAS-SKH2-BOARD)
> >>      compatible = "renesas,stout", "renesas,r8a7790"
> >> -  - V3MSK
> >> +  - V3MSK (Y-ASK-RCAR-V3M-WS10)
> 
>    ACK.
> 
> >>      compatible = "renesas,v3msk", "renesas,r8a77970"
> > 
> > Google also tells me there is WS20, but I guess WS10 what is
> > currently supported upstream.
> 
>    At least that's what I have on my desk. :-)
> 
> >> -  - Wheat
> >> +  - Wheat (RTP0RC7792ASKB0010JE)
> >>      compatible = "renesas,wheat", "renesas,r8a7792"
> > 
> > I'm unable to confirm the above. Can anyone help?
> 
>    Not me -- my documents don't mention this. :-(

On Tue, Feb 27, 2018 at 10:14:32PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Feb 27, 2018 at 9:17 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Feb 26, 2018 at 07:03:43PM +0100, Geert Uytterhoeven wrote:

...

> >> -  - Wheat
> >> +  - Wheat (RTP0RC7792ASKB0010JE)
> >>      compatible = "renesas,wheat", "renesas,r8a7792"
> >
> > I'm unable to confirm the above. Can anyone help?
> 
> https://elinux.org/R-Car/Boards/Wheat
> 
> Looks like I misinterpreted the pictures, and
> RTP0RC7792ASKB0000JE is the correct part number for Wheat.

Thanks. I've applied the following.


From: Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH] dt-bindings: arm: Document Renesas V3MSK and Wheat board part
 numbers

The DT binding documentation for the Renesas V3MSK and Wheat boards
lacked board part numbers.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
[simon: corrected Wheat part number]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 Documentation/devicetree/bindings/arm/shmobile.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index a99359e63b0a..66edc1406bb8 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -120,9 +120,9 @@ Boards:
     compatible = "renesas,sk-rzg1m", "renesas,r8a7743"
   - Stout (ADAS Starterkit, Y-R-CAR-ADAS-SKH2-BOARD)
     compatible = "renesas,stout", "renesas,r8a7790"
-  - V3MSK
+  - V3MSK (Y-ASK-RCAR-V3M-WS10)
     compatible = "renesas,v3msk", "renesas,r8a77970"
-  - Wheat
+  - Wheat (RTP0RC7792ASKB0000JE)
     compatible = "renesas,wheat", "renesas,r8a7792"
 
 
-- 
2.11.0

Re: [PATCH 2/4] dt-bindings: arm: Document Renesas V3MSK and Wheat board part numbers

[Sergei Shtylyov]

On 2/28/2018 9:49 AM, Simon Horman wrote:

[...]

>> On Tue, Feb 27, 2018 at 9:17 AM, Simon Horman <horms@verge.net.au> wrote:
>>> On Mon, Feb 26, 2018 at 07:03:43PM +0100, Geert Uytterhoeven wrote:
> 
> ...
> 
>>>> -  - Wheat
>>>> +  - Wheat (RTP0RC7792ASKB0010JE)
>>>>       compatible = "renesas,wheat", "renesas,r8a7792"
>>>
>>> I'm unable to confirm the above. Can anyone help?
>>
>> https://elinux.org/R-Car/Boards/Wheat
>>
>> Looks like I misinterpreted the pictures, and
>> RTP0RC7792ASKB0000JE is the correct part number for Wheat.
> 
> Thanks. I've applied the following.
> 
> 
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Subject: [PATCH] dt-bindings: arm: Document Renesas V3MSK and Wheat board part
>   numbers
> 
> The DT binding documentation for the Renesas V3MSK and Wheat boards
> lacked board part numbers.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> [simon: corrected Wheat part number]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>   Documentation/devicetree/bindings/arm/shmobile.txt | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
> index a99359e63b0a..66edc1406bb8 100644
> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> @@ -120,9 +120,9 @@ Boards:
>       compatible = "renesas,sk-rzg1m", "renesas,r8a7743"
>     - Stout (ADAS Starterkit, Y-R-CAR-ADAS-SKH2-BOARD)
>       compatible = "renesas,stout", "renesas,r8a7790"
> -  - V3MSK
> +  - V3MSK (Y-ASK-RCAR-V3M-WS10)

    https://elinux.org/R-Car/Boards/V3MSK (now that I'm reminded of this site) 
says the V3MSK's model # is RTP0RC77970SEB0010S.

>       compatible = "renesas,v3msk", "renesas,r8a77970"
> -  - Wheat
> +  - Wheat (RTP0RC7792ASKB0000JE)
>       compatible = "renesas,wheat", "renesas,r8a7792"

MBR, Sergei

Re: [PATCH 2/4] dt-bindings: arm: Document Renesas V3MSK and Wheat board part numbers

[Geert Uytterhoeven]

Hi Sergei,

On Wed, Feb 28, 2018 at 8:38 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 2/28/2018 9:49 AM, Simon Horman wrote:
>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
>> @@ -120,9 +120,9 @@ Boards:
>>       compatible = "renesas,sk-rzg1m", "renesas,r8a7743"
>>     - Stout (ADAS Starterkit, Y-R-CAR-ADAS-SKH2-BOARD)
>>       compatible = "renesas,stout", "renesas,r8a7790"
>> -  - V3MSK
>> +  - V3MSK (Y-ASK-RCAR-V3M-WS10)
>
>    https://elinux.org/R-Car/Boards/V3MSK (now that I'm reminded of this
> site) says the V3MSK's model # is RTP0RC77970SEB0010S.

Nope, that's Eagle :-(
Check the picture on https://elinux.org/R-Car/Boards/Eagle

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/4] dt-bindings: arm: Document Renesas V3MSK and Wheat board part numbers

[Geert Uytterhoeven]

Hi Simon,

On Tue, Feb 27, 2018 at 9:17 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Feb 26, 2018 at 07:03:43PM +0100, Geert Uytterhoeven wrote:
>> The DT binding documentation for the Renesas V3MSK and Wheat boards
>> lacked board part numbers.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>>  Documentation/devicetree/bindings/arm/shmobile.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
>> index ded2cd3b5f4df0c8..82908a9447e4b051 100644
>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
>> @@ -120,9 +120,9 @@ Boards:
>>      compatible = "renesas,sk-rzg1m", "renesas,r8a7743"
>>    - Stout (ADAS Starterkit, Y-R-CAR-ADAS-SKH2-BOARD)
>>      compatible = "renesas,stout", "renesas,r8a7790"
>> -  - V3MSK
>> +  - V3MSK (Y-ASK-RCAR-V3M-WS10)
>>      compatible = "renesas,v3msk", "renesas,r8a77970"
>
> Google also tells me there is WS20, but I guess WS10 what is
> currently supported upstream.
>
>> -  - Wheat
>> +  - Wheat (RTP0RC7792ASKB0010JE)
>>      compatible = "renesas,wheat", "renesas,r8a7792"
>
> I'm unable to confirm the above. Can anyone help?

https://elinux.org/R-Car/Boards/Wheat

Looks like I misinterpreted the pictures, and
RTP0RC7792ASKB0000JE is the correct part number for Wheat.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 3/4] dt-bindings: arm: Document Renesas R-Car M3-N-based Salvator-X board

[Geert Uytterhoeven]

The Renesas Salvator-X development board can be equipped with an R-Car
H3, M3-W, or M3-N SiP, which are pin-compatible.

Document board part number and compatible values for the version with
R-Car M3-N.

The board part number was extracted from a big patch by Takeshi Kihara
in the BSP.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index 82908a9447e4b051..51e4428856be4557 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -108,6 +108,8 @@ Boards:
     compatible = "renesas,salvator-x", "renesas,r8a7795"
   - Salvator-X (RTP0RC7796SIPB0011S)
     compatible = "renesas,salvator-x", "renesas,r8a7796"
+  - Salvator-X (RTP0RC7796SIPB0011S (M3N))
+    compatible = "renesas,salvator-x", "renesas,r8a77965"
   - Salvator-XS (Salvator-X 2nd version, RTP0RC7795SIPB0012S)
     compatible = "renesas,salvator-xs", "renesas,r8a7795"
   - Salvator-XS (Salvator-X 2nd version, RTP0RC7796SIPB0012S)
-- 
2.7.4

Re: [PATCH 3/4] dt-bindings: arm: Document Renesas R-Car M3-N-based Salvator-X board

[Simon Horman]

On Mon, Feb 26, 2018 at 07:03:44PM +0100, Geert Uytterhoeven wrote:
> The Renesas Salvator-X development board can be equipped with an R-Car
> H3, M3-W, or M3-N SiP, which are pin-compatible.
> 
> Document board part number and compatible values for the version with
> R-Car M3-N.
> 
> The board part number was extracted from a big patch by Takeshi Kihara
> in the BSP.

That I have verified.

> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
> index 82908a9447e4b051..51e4428856be4557 100644
> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> @@ -108,6 +108,8 @@ Boards:
>      compatible = "renesas,salvator-x", "renesas,r8a7795"
>    - Salvator-X (RTP0RC7796SIPB0011S)

Here we have: Name (Part No)

>      compatible = "renesas,salvator-x", "renesas,r8a7796"
> +  - Salvator-X (RTP0RC7796SIPB0011S (M3N))

Here we have: Name (Part No (SoC))

> +    compatible = "renesas,salvator-x", "renesas,r8a77965"
>    - Salvator-XS (Salvator-X 2nd version, RTP0RC7795SIPB0012S)

And here we have: Name (Version, Part No)

>      compatible = "renesas,salvator-xs", "renesas,r8a7795"
>    - Salvator-XS (Salvator-X 2nd version, RTP0RC7796SIPB0012S)

Can we think about making this more consistent?

Re: [PATCH 3/4] dt-bindings: arm: Document Renesas R-Car M3-N-based Salvator-X board

[Geert Uytterhoeven]

Hi Simon,

On Tue, Feb 27, 2018 at 9:22 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Feb 26, 2018 at 07:03:44PM +0100, Geert Uytterhoeven wrote:
>> The Renesas Salvator-X development board can be equipped with an R-Car
>> H3, M3-W, or M3-N SiP, which are pin-compatible.
>>
>> Document board part number and compatible values for the version with
>> R-Car M3-N.
>>
>> The board part number was extracted from a big patch by Takeshi Kihara
>> in the BSP.

>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
>> @@ -108,6 +108,8 @@ Boards:
>>      compatible = "renesas,salvator-x", "renesas,r8a7795"
>>    - Salvator-X (RTP0RC7796SIPB0011S)
>
> Here we have: Name (Part No)

That's the standard (highest number of occurrences) way.

>>      compatible = "renesas,salvator-x", "renesas,r8a7796"
>> +  - Salvator-X (RTP0RC7796SIPB0011S (M3N))
>
> Here we have: Name (Part No (SoC))

This one is special: it's basically an M3-N prototype board made by taking
a Salvator-X/M3-W board, and replacing the M3-W SiP by an M3-N SiP.
Hence the board part number is the same.

>> +    compatible = "renesas,salvator-x", "renesas,r8a77965"
>>    - Salvator-XS (Salvator-X 2nd version, RTP0RC7795SIPB0012S)
>
> And here we have: Name (Version, Part No)

AFAIU, "Salvator-XS" really means "Salvator-X 2nd version".
So it's not "Version", but "Alternative Board Name".
There's a similar thing with the ULCB boards:

  - H3ULCB (R-Car Starter Kit Premier, RTP0RC7795SKBX0010SA00 (H3 ES1.1))
    H3ULCB (R-Car Starter Kit Premier, RTP0RC77951SKBX010SA00 (H3 ES2.0))
  - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))

>>      compatible = "renesas,salvator-xs", "renesas,r8a7795"
>>    - Salvator-XS (Salvator-X 2nd version, RTP0RC7796SIPB0012S)
>
> Can we think about making this more consistent?

I'm afraid not. Naming seems to become only more complex over time...
Unless you have great hands and great ideas ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 3/4] dt-bindings: arm: Document Renesas R-Car M3-N-based Salvator-X board

[Simon Horman]

On Tue, Feb 27, 2018 at 10:25:42PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Feb 27, 2018 at 9:22 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Feb 26, 2018 at 07:03:44PM +0100, Geert Uytterhoeven wrote:
> >> The Renesas Salvator-X development board can be equipped with an R-Car
> >> H3, M3-W, or M3-N SiP, which are pin-compatible.
> >>
> >> Document board part number and compatible values for the version with
> >> R-Car M3-N.
> >>
> >> The board part number was extracted from a big patch by Takeshi Kihara
> >> in the BSP.
> 
> >> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> >> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> >> @@ -108,6 +108,8 @@ Boards:
> >>      compatible = "renesas,salvator-x", "renesas,r8a7795"
> >>    - Salvator-X (RTP0RC7796SIPB0011S)
> >
> > Here we have: Name (Part No)
> 
> That's the standard (highest number of occurrences) way.
> 
> >>      compatible = "renesas,salvator-x", "renesas,r8a7796"
> >> +  - Salvator-X (RTP0RC7796SIPB0011S (M3N))
> >
> > Here we have: Name (Part No (SoC))
> 
> This one is special: it's basically an M3-N prototype board made by taking
> a Salvator-X/M3-W board, and replacing the M3-W SiP by an M3-N SiP.
> Hence the board part number is the same.
> 
> >> +    compatible = "renesas,salvator-x", "renesas,r8a77965"
> >>    - Salvator-XS (Salvator-X 2nd version, RTP0RC7795SIPB0012S)
> >
> > And here we have: Name (Version, Part No)
> 
> AFAIU, "Salvator-XS" really means "Salvator-X 2nd version".
> So it's not "Version", but "Alternative Board Name".
> There's a similar thing with the ULCB boards:
> 
>   - H3ULCB (R-Car Starter Kit Premier, RTP0RC7795SKBX0010SA00 (H3 ES1.1))
>     H3ULCB (R-Car Starter Kit Premier, RTP0RC77951SKBX010SA00 (H3 ES2.0))
>   - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0))
> 
> >>      compatible = "renesas,salvator-xs", "renesas,r8a7795"
> >>    - Salvator-XS (Salvator-X 2nd version, RTP0RC7796SIPB0012S)
> >
> > Can we think about making this more consistent?
> 
> I'm afraid not. Naming seems to become only more complex over time...
> Unless you have great hands and great ideas ;-)

Not so many good ideas this morning.

I've applied this as is. We can revisit if the need arises.

[PATCH 4/4] dt-bindings: arm: Document Renesas R-Car M3-N-based Salvator-XS board

[Geert Uytterhoeven]

The Renesas Salvator-XS development board can be equipped with an R-Car
H3, M3-W, or M3-N SiP, which are pin-compatible.

Document board part number and compatible values for the version with
R-Car M3-N.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index 51e4428856be4557..303f04e639431837 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -114,6 +114,8 @@ Boards:
     compatible = "renesas,salvator-xs", "renesas,r8a7795"
   - Salvator-XS (Salvator-X 2nd version, RTP0RC7796SIPB0012S)
     compatible = "renesas,salvator-xs", "renesas,r8a7796"
+  - Salvator-XS (Salvator-X 2nd version, RTP0RC77965SIPB012S)
+    compatible = "renesas,salvator-xs", "renesas,r8a77965"
   - SILK (RTP0RC7794LCB00011S)
     compatible = "renesas,silk", "renesas,r8a7794"
   - SK-RZG1E (YR8A77450S000BE)
-- 
2.7.4

Re: [PATCH 4/4] dt-bindings: arm: Document Renesas R-Car M3-N-based Salvator-XS board

[Simon Horman]

On Mon, Feb 26, 2018 at 07:03:45PM +0100, Geert Uytterhoeven wrote:
> The Renesas Salvator-XS development board can be equipped with an R-Car
> H3, M3-W, or M3-N SiP, which are pin-compatible.
> 
> Document board part number and compatible values for the version with
> R-Car M3-N.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
> index 51e4428856be4557..303f04e639431837 100644
> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> @@ -114,6 +114,8 @@ Boards:
>      compatible = "renesas,salvator-xs", "renesas,r8a7795"
>    - Salvator-XS (Salvator-X 2nd version, RTP0RC7796SIPB0012S)
>      compatible = "renesas,salvator-xs", "renesas,r8a7796"
> +  - Salvator-XS (Salvator-X 2nd version, RTP0RC77965SIPB012S)
> +    compatible = "renesas,salvator-xs", "renesas,r8a77965"

I am unsure how to verify this part number, can anyone help?
Also, the syntax seems inconsistent with that of patch 3/4.

>    - SILK (RTP0RC7794LCB00011S)
>      compatible = "renesas,silk", "renesas,r8a7794"
>    - SK-RZG1E (YR8A77450S000BE)
> -- 
> 2.7.4
> 

RE: [PATCH 4/4] dt-bindings: arm: Document Renesas R-Car M3-N-based Salvator-XS board

[Chris Paterson]

Hello Simon,

> From: devicetree-owner@vger.kernel.org [mailto:devicetree-
> owner@vger.kernel.org] On Behalf Of Simon Horman
> Sent: 27 February 2018 08:25
> 
> On Mon, Feb 26, 2018 at 07:03:45PM +0100, Geert Uytterhoeven wrote:
> > The Renesas Salvator-XS development board can be equipped with an
> > R-Car H3, M3-W, or M3-N SiP, which are pin-compatible.
> >
> > Document board part number and compatible values for the version with
> > R-Car M3-N.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt
> > b/Documentation/devicetree/bindings/arm/shmobile.txt
> > index 51e4428856be4557..303f04e639431837 100644
> > --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> > +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> > @@ -114,6 +114,8 @@ Boards:
> >      compatible = "renesas,salvator-xs", "renesas,r8a7795"
> >    - Salvator-XS (Salvator-X 2nd version, RTP0RC7796SIPB0012S)
> >      compatible = "renesas,salvator-xs", "renesas,r8a7796"
> > +  - Salvator-XS (Salvator-X 2nd version, RTP0RC77965SIPB012S)
> > +    compatible = "renesas,salvator-xs", "renesas,r8a77965"
> 
> I am unsure how to verify this part number, can anyone help?

This matches the label on the board.

Kind regards, Chris


> Also, the syntax seems inconsistent with that of patch 3/4.
> 
> >    - SILK (RTP0RC7794LCB00011S)
> >      compatible = "renesas,silk", "renesas,r8a7794"
> >    - SK-RZG1E (YR8A77450S000BE)
> > --
> > 2.7.4
> >
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in the
> body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] dt-bindings: arm: Document Renesas R-Car M3-N-based Salvator-XS board

[Simon Horman]

On Tue, Feb 27, 2018 at 08:41:13AM +0000, Chris Paterson wrote:
> Hello Simon,
> 
> > From: devicetree-owner@vger.kernel.org [mailto:devicetree-
> > owner@vger.kernel.org] On Behalf Of Simon Horman
> > Sent: 27 February 2018 08:25
> > 
> > On Mon, Feb 26, 2018 at 07:03:45PM +0100, Geert Uytterhoeven wrote:
> > > The Renesas Salvator-XS development board can be equipped with an
> > > R-Car H3, M3-W, or M3-N SiP, which are pin-compatible.
> > >
> > > Document board part number and compatible values for the version with
> > > R-Car M3-N.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > >  Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt
> > > b/Documentation/devicetree/bindings/arm/shmobile.txt
> > > index 51e4428856be4557..303f04e639431837 100644
> > > --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> > > +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> > > @@ -114,6 +114,8 @@ Boards:
> > >      compatible = "renesas,salvator-xs", "renesas,r8a7795"
> > >    - Salvator-XS (Salvator-X 2nd version, RTP0RC7796SIPB0012S)
> > >      compatible = "renesas,salvator-xs", "renesas,r8a7796"
> > > +  - Salvator-XS (Salvator-X 2nd version, RTP0RC77965SIPB012S)
> > > +    compatible = "renesas,salvator-xs", "renesas,r8a77965"
> > 
> > I am unsure how to verify this part number, can anyone help?
> 
> This matches the label on the board.

Thanks, applied.