* [PATCH] ARM: dts: imx6dl-icore-rqs: Fix invalid PHY address assignment for ethernet
@ 2018-02-27 15:59 shyam saini
2018-02-28 6:35 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: shyam saini @ 2018-02-27 15:59 UTC (permalink / raw)
To: shawnguo
Cc: devicetree, Shyam Saini, robh+dt, jagan, kernel, fabio.estevam,
michael, linux-arm-kernel
From: Shyam Saini <shyam@amarulasolutions.com>
Add "reg" property for ethernet to fix this issue.
Errors in boot logs:
mdio_bus 2188000.ethernet-1:
/soc/aips-bus@02100000/ethernet@02188000/mdio/ethernet-phy
has invalid PHY address
mdio_bus 2188000.ethernet-1: scan phy ethernet-phy at address 0
mdio_bus 2188000.ethernet-1: scan phy ethernet-phy at address 1
mdio_bus 2188000.ethernet-1: scan phy ethernet-phy at address 2
mdio_bus 2188000.ethernet-1: scan phy ethernet-phy at address 3
Reported-by: Shyam Saini <shyam@amarulasolutions.com>
Suggested-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Shyam Saini <shyam@amarulasolutions.com>
---
arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
index 49daa2b7892d..acc3b11fba2a 100644
--- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
@@ -200,7 +200,11 @@
status = "okay";
mdio {
- eth_phy: ethernet-phy {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy: ethernet-phy@0 {
+ reg = <0x0>;
rxc-skew-ps = <1140>;
txc-skew-ps = <1140>;
txen-skew-ps = <600>;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: imx6dl-icore-rqs: Fix invalid PHY address assignment for ethernet
2018-02-27 15:59 [PATCH] ARM: dts: imx6dl-icore-rqs: Fix invalid PHY address assignment for ethernet shyam saini
@ 2018-02-28 6:35 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2018-02-28 6:35 UTC (permalink / raw)
To: shyam saini
Cc: devicetree, Shyam Saini, robh+dt, jagan, kernel, fabio.estevam,
michael, linux-arm-kernel
On Tue, Feb 27, 2018 at 09:29:03PM +0530, shyam saini wrote:
> From: Shyam Saini <shyam@amarulasolutions.com>
>
> Add "reg" property for ethernet to fix this issue.
>
> Errors in boot logs:
> mdio_bus 2188000.ethernet-1:
> /soc/aips-bus@02100000/ethernet@02188000/mdio/ethernet-phy
> has invalid PHY address
>
> mdio_bus 2188000.ethernet-1: scan phy ethernet-phy at address 0
> mdio_bus 2188000.ethernet-1: scan phy ethernet-phy at address 1
> mdio_bus 2188000.ethernet-1: scan phy ethernet-phy at address 2
> mdio_bus 2188000.ethernet-1: scan phy ethernet-phy at address 3
>
> Reported-by: Shyam Saini <shyam@amarulasolutions.com>
> Suggested-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Shyam Saini <shyam@amarulasolutions.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-28 6:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-27 15:59 [PATCH] ARM: dts: imx6dl-icore-rqs: Fix invalid PHY address assignment for ethernet shyam saini
2018-02-28 6:35 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).