Re: [PATCH v2 3/4] pinctrl: add mt2712 pinctrl driver

[Sean Wang <sean.wang@mediatek.com>]

Hi, Zhiyong

all seems better than v1, but some nitpicking is addressed as below 

	Sean

On Mon, 2018-02-26 at 16:34 +0800, Zhiyong Tao wrote:
> The commit includes mt2712 pinctrl driver.
> 
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> ---
>  drivers/pinctrl/mediatek/Kconfig              |    7 +
>  drivers/pinctrl/mediatek/Makefile             |    1 +
>  drivers/pinctrl/mediatek/pinctrl-mt2712.c     |  639 ++++++++
>  drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h | 1973 +++++++++++++++++++++++++
>  4 files changed, 2620 insertions(+)
>  create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt2712.c
>  create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h
> 
> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> index 3e59874..b24bc76 100644
> --- a/drivers/pinctrl/mediatek/Kconfig
> +++ b/drivers/pinctrl/mediatek/Kconfig
> @@ -32,6 +32,13 @@ config PINCTRL_MT8127
>  	select PINCTRL_MTK
>  
>  # For ARMv8 SoCs
> +config PINCTRL_MT2712
> +	bool "Mediatek MT2712 pin control"


should be MediaTek for normal

> +	depends on OF
> +	depends on ARM64 || COMPILE_TEST
> +	default ARM64 && ARCH_MEDIATEK
> +	select PINCTRL_MTK
> +
>  config PINCTRL_MT7622
>  	bool "MediaTek MT7622 pin control"
>  	depends on OF
> diff --git a/drivers/pinctrl/mediatek/Makefile b/drivers/pinctrl/mediatek/Makefile
> index ed7d2b2..7959e77 100644
> --- a/drivers/pinctrl/mediatek/Makefile
> +++ b/drivers/pinctrl/mediatek/Makefile
> @@ -4,6 +4,7 @@ obj-$(CONFIG_PINCTRL_MTK)	+= pinctrl-mtk-common.o
>  
>  # SoC Drivers
>  obj-$(CONFIG_PINCTRL_MT2701)	+= pinctrl-mt2701.o
> +obj-$(CONFIG_PINCTRL_MT2712)	+= pinctrl-mt2712.o
>  obj-$(CONFIG_PINCTRL_MT8135)	+= pinctrl-mt8135.o
>  obj-$(CONFIG_PINCTRL_MT8127)	+= pinctrl-mt8127.o
>  obj-$(CONFIG_PINCTRL_MT7622)	+= pinctrl-mt7622.o
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt2712.c b/drivers/pinctrl/mediatek/pinctrl-mt2712.c
> new file mode 100644
> index 0000000..b6ae71b
> --- /dev/null
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt2712.c
> @@ -0,0 +1,639 @@
> +/*
> + * Copyright (c) 2014-2015 MediaTek Inc.
> + * Author: Hongzhou.Yang <hongzhou.yang@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +

suggest to consider more on using SPDX identifiers and
using right data for both fields Copyright and Author

> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> +#include <linux/pinctrl/pinctrl.h>
> +#include <linux/regmap.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> +#include <dt-bindings/pinctrl/mt65xx.h>
> +
> +#include "pinctrl-mtk-common.h"
> +#include "pinctrl-mtk-mt2712.h"
> +

<...>

> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h
> new file mode 100644
> index 0000000..71f4190
> --- /dev/null
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h
> @@ -0,0 +1,1973 @@
> +/*
> + * Copyright (C) 2015 MediaTek Inc.
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */

Ditto 

> +#ifndef PINCTRL_MTK_MT2712_H
> +#define PINCTRL_MTK_MT2712_H
> +

<...>

> +
> +#endif /* __PINCTRL_MTK_MT2712_H */