From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gdMKiOF9" Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1522410CE for ; Thu, 30 Nov 2023 01:52:55 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40b30308c67so5899025e9.0 for ; Thu, 30 Nov 2023 01:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701337973; x=1701942773; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ZWwZC/V0wDXbj7+U19+s2XYbHOD77Anr4368lm9EqGo=; b=gdMKiOF90oV5EJriqTzsgxOH7xnnBwxwp09O3sGs+6hLXGg1A93tI93RswImuVweEU UUjOWSrFnSaDKgWhlZoYLcM6vZxg3uEJ5CaahasW8So5REiOJUKiWE25omHyvtChrXzQ UQoqPPIn8dMgLfDNIm3fSCpqiwYQYjmwIqPxn5b9vR1fWZWcBmPkmmGwJ/HQ3jinAW7x 0ZAN4HDgGhDYnWl8Td5IgyHlR+PZUzLo20LfCzBN6WSFAznmisIRBK4tnk+5JVXtcqca WL+bNqV9Z3kUDGLaRWwM6BGLci+BR8k+bOSxuxu0N6a9jUUbRGLu6X2WMlFtKDvnpNV0 oRJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701337973; x=1701942773; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZWwZC/V0wDXbj7+U19+s2XYbHOD77Anr4368lm9EqGo=; b=r4e/tvujSIyeJabykCOk5z7w09SZLr2++5ymgYUj4AhDiYskMookWioDgjc1tqA6Ob sIbyQk0nvB2zmb0CYDFpSuE9HETgszVIIc7oXnN+ynhTirc+v8FxjTCq0Fz/ki279hnv 6Mbgg4/lsGq/x5eH7jOC1Ryfq8XlF57ckknwPEBl2hMtr0wMj7UrY65iAso4tVyXB4n2 ABKXCrcs/SMDSsbfBkYW4Xq/L50krt5f4PPmlJfVgv+zEtWo6wCXGwwVzs4zvXrC5hc5 WOsnoDRLmRZSLtXVISkwzw7INlYAXTuxGKfFWo4YbnLh+QSHmFR6mjqW8Aw+aiF4qCfc U3oA== X-Gm-Message-State: AOJu0YzQF3Y2Y/Hk23RcE42CIJuGR15DHTfhB4TwoSkiX6bi7TUKPDSU +Sao/C/AXkMJ1iKHeCjgGwPPfQ== X-Google-Smtp-Source: AGHT+IGTrAg/hwtnFBOTX6GiHM/FZmceDuyWR5BDRUvcKgMuHNpNkw29tTNc3TZ/F4WBbh95Bq14Ow== X-Received: by 2002:a05:600c:4447:b0:40b:3728:badb with SMTP id v7-20020a05600c444700b0040b3728badbmr14766919wmn.33.1701337973529; Thu, 30 Nov 2023 01:52:53 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:41c9:3acd:a6e2:5242? ([2a01:e0a:982:cbb0:41c9:3acd:a6e2:5242]) by smtp.gmail.com with ESMTPSA id p36-20020a05600c1da400b0040b478da760sm1358964wms.48.2023.11.30.01.52.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Nov 2023 01:52:53 -0800 (PST) Message-ID: <151b8a7b-062e-464e-8d8e-2dc9e1ff9dfd@linaro.org> Date: Thu, 30 Nov 2023 10:52:52 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm8450: correct TX Soundwire clock Content-Language: en-US, fr To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231129140537.161720-1-krzysztof.kozlowski@linaro.org> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20231129140537.161720-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/11/2023 15:05, Krzysztof Kozlowski wrote: > The TX Soundwire controller should take clock from TX macro codec, not > VA macro codec clock, otherwise the clock stays disabled. This looks > like a copy-paste issue, because the SC8280xp code uses here correctly > clock from TX macro. The VA macro clock is already consumed by TX macro > codec, thus it won't be disabled by this change. > > Fixes: 14341e76dbc7 ("arm64: dts: qcom: sm8450: add Soundwire and LPASS") > Reported-by: Neil Armstrong > Signed-off-by: Krzysztof Kozlowski > > --- > > Considering that in Downstream, the TX Soundwire is part of VA macro, > there is no clear reference code explaining this. Let's just go with > SC8280xp approach because it seems reasonable, but don't ask me "why". > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index a305f8c03f9e..28207c7423f0 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -2314,7 +2314,7 @@ swr2: soundwire@33b0000 { > ; > interrupt-names = "core", "wakeup"; > > - clocks = <&vamacro>; > + clocks = <&txmacro>; > clock-names = "iface"; > label = "TX"; > Reviewed-by: Neil Armstrong