From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE509CA0EC3 for ; Tue, 12 Sep 2023 11:01:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231196AbjILLBl (ORCPT ); Tue, 12 Sep 2023 07:01:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234116AbjILLBN (ORCPT ); Tue, 12 Sep 2023 07:01:13 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B923D10DE for ; Tue, 12 Sep 2023 04:01:08 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-52683b68c2fso7160256a12.0 for ; Tue, 12 Sep 2023 04:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1694516467; x=1695121267; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gBOOTYnIbc7jXGk6LLtBsEP6Hing17bwVORuVZHF9dw=; b=BsCbKNsaHIKCI3UDtRCG1EjV6JYtUL6G7mk4P3SjbvqP553bIVjucSFHeRVVPGizqv JjEDX6qlFYY6skYeDxsQmkd8tumGmrpMzCyWBl5I7fnBYJpDqB5f7B8MlhzBW8l9hLYS PvzuMhPoCvQwuz/CdOdIPbya56YJTvwOA/G8Ko8zeqNOGtWb6IWM+783sxgJ0sOiQhst YTjOA68Ys89Z9CWAhtTYtrThc4xkAqy7U78d3NY8DfH5s6C5kjJz7PzqHIlAUieRh5M4 WhHQn6pqYPcC1TiuPsKtQGcofBHzHGnqUIO9UaTRczSI7iWPrXGCySFAGHWn8AxH0kTX IBDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694516467; x=1695121267; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gBOOTYnIbc7jXGk6LLtBsEP6Hing17bwVORuVZHF9dw=; b=UCTlRaqcab5qnAbtQzhK3s85XK+zPjBxp2ZlLpe2a4QE8apSIvQeBU6QAID2aLAOW3 uXJWlX+qa2ix0MhCtdhV4SUO3O+hG0M5NzpAMtJiFVYYS8U0VcxRUpZDihSHdPfYN5gx jHAneLSqD/j7MlzoDpzZzVi5uk085HMf9oGhiXNjwFQztlJMy9aDWQdzPgEuq3d8B4nY guxYk/oQ+hod0L1G3zimXum3+PrHUNJtyGz9rrGksU/tsz4eWc4SdF8Baz4KaKI7VcIe C2mo+aMfE3XJNPbwTgBGllE7Vwht3ETAX+l5mOfaB8ICGQIif8POvG4qo7vSww+DP2TK OiTA== X-Gm-Message-State: AOJu0Ywhh0TEULQZns4dIMlvMJUinCz2Jf2xHGULnwR9IfLmQ6LL6dxL fhRKAaY13I1x+oFf6TVE4Lp6tQ== X-Google-Smtp-Source: AGHT+IF/AigYTNC1xfg71ULrrI6VsQI63f6+heLFLtnVSJ/ib4KvxtVvVDrFyHmCrhN5Lz3g9cf+RA== X-Received: by 2002:aa7:c74c:0:b0:528:90d7:a1f with SMTP id c12-20020aa7c74c000000b0052890d70a1fmr10961153eds.10.1694516467067; Tue, 12 Sep 2023 04:01:07 -0700 (PDT) Received: from [192.168.32.2] ([82.78.167.145]) by smtp.gmail.com with ESMTPSA id be6-20020a0564021a2600b005224d960e66sm5724607edb.96.2023.09.12.04.01.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Sep 2023 04:01:06 -0700 (PDT) Message-ID: <151c12f5-dc5b-3a25-f644-bd65775ae787@tuxon.dev> Date: Tue, 12 Sep 2023 14:01:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 2/2] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29_curiosity board Content-Language: en-US To: Nicolas Ferre , Mihai.Sain@microchip.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, andre.przywara@arm.com, Andrei.Simion@microchip.com, Jerry.Ray@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Cristian.Birsan@microchip.com References: <20230801111151.6546-1-mihai.sain@microchip.com> <20230801111151.6546-2-mihai.sain@microchip.com> <14d628cf-a40c-11e6-7743-e3ba3bd8aa2d@tuxon.dev> <9ce18601-02d8-686e-ebe0-04c5dc29f6c9@tuxon.dev> <18943157-a1fb-0fda-e3d4-e0478d18a849@microchip.com> From: claudiu beznea In-Reply-To: <18943157-a1fb-0fda-e3d4-e0478d18a849@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, Nicolas, Mihai, On 11.09.2023 19:01, Nicolas Ferre wrote: > Hi Mihai, Claudiu, > > First of all, thanks a lot for your help on this board DT, that's great! > > On 03/08/2023 at 11:09, claudiu beznea wrote: >> Hi, Mihai, >> >> On 02.08.2023 15:19,Mihai.Sain@microchip.com  wrote: >>>> +&macb0 { >>>> +     pinctrl-names = "default"; >>>> +     pinctrl-0 = <&pinctrl_macb0_default &pinctrl_macb0_phy_irq>; >>>> +     #address-cells = <1>; >>>> +     #size-cells = <0>; >>>> +     phy-mode = "rmii"; >>>> +     status = "disabled"; >>> Should any phy/mdio container be placed here? Also, any reason this node >>> is disabled? >>> The board has no phy. >>> We will add external phy boards to macb interface and they will be >>> present in dt-overlay. >>> >> Then remove the macb0 node from here and keep it in overlay. > > What about choosing a phy and making it enabled by default. Because I doubt > people will use this board without a phy under Linux, honestly. > Overlays would remove this "by default" node and add the replacing phy if > hardware plugged-in is different. The only thing about it (FMPOV) is that there might be people expecting the default bindings to work with every PHY. > > By doing this we avoid having difficult situations where the most used phy > with this board is disabled or non existant and that we absolutely need an > overlay for such a basic thing as having Ethernet working out-of-the-box... I undestand your POV but DTS should describe the hardware. At least, is there any PHY shipped with the board to be considered the default one? SAMA5D3 EDS uses the same approach: it defines individual overlays for each supported ethernet PHYs. Thank you, Claudiu Beznea > > Just my $0.02, but it might simplify our life in the long run... > > Best regards, >   Nicolas