[PATCH] ARM: dts: BCM5301X: add missing LEDs for Buffalo WZR-900DHP

[PATCH] ARM: dts: BCM5301X: add missing LEDs for Buffalo WZR-900DHP

[musashino.open]

From: INAGAKI Hiroshi <musashino.open@gmail.com>

Buffalo WZR-900DHP has 8 LEDs, but there is not LED definitions in the
dts and cannot configure these LEDs.
I Added missing LED definitions for WZR-900DHP.

Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
---
 arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts | 73 +++++++++++++++++++++++
 1 file changed, 73 insertions(+)

diff --git a/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts b/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts
index 8bef642..fa8f917 100644
--- a/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts
+++ b/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts
@@ -35,6 +35,79 @@
 		       0x88000000 0x08000000>;
 	};
 
+	spi {
+		compatible = "spi-gpio";
+		num-chipselects = <1>;
+		gpio-sck = <&chipcommon 7 0>;
+		gpio-mosi = <&chipcommon 4 0>;
+		cs-gpios = <&chipcommon 6 0>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		hc595: gpio_spi@0 {
+			compatible = "fairchild,74hc595";
+			reg = <0>;
+			registers-number = <1>;
+			spi-max-frequency = <100000>;
+
+			gpio-controller;
+			#gpio-cells = <2>;
+
+		};
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		usb {
+			label = "bcm53xx:green:usb";
+			gpios = <&hc595 0 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-off";
+		};
+
+		power0 {
+			label = "bcm53xx:green:power";
+			gpios = <&hc595 1 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-on";
+		};
+
+		power1 {
+			label = "bcm53xx:red:power";
+			gpios = <&hc595 2 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-off";
+		};
+
+		router0 {
+			label = "bcm53xx:green:router";
+			gpios = <&hc595 3 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-on";
+		};
+
+		router1 {
+			label = "bcm53xx:amber:router";
+			gpios = <&hc595 4 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-off";
+		};
+
+		wan {
+			label = "bcm53xx:green:wan";
+			gpios = <&hc595 5 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-on";
+		};
+
+		wireless0 {
+			label = "bcm53xx:green:wireless";
+			gpios = <&hc595 6 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-off";
+		};
+
+		wireless1 {
+			label = "bcm53xx:amber:wireless";
+			gpios = <&hc595 7 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-off";
+		};
+	};
+
 	gpio-keys {
 		compatible = "gpio-keys";
 		#address-cells = <1>;
-- 
2.7.4

Re: [PATCH] ARM: dts: BCM5301X: add missing LEDs for Buffalo WZR-900DHP

[Rafał Miłecki]

On 5 March 2018 at 15:36,  <musashino.open@gmail.com> wrote:
> From: INAGAKI Hiroshi <musashino.open@gmail.com>
>
> Buffalo WZR-900DHP has 8 LEDs, but there is not LED definitions in the
> dts and cannot configure these LEDs.
> I Added missing LED definitions for WZR-900DHP.
>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>

Looks almost good, thanks for sending this patch to Florian.

One comment: please drop all linux,default-trigger = "default-off";
lines. I did the same mistake long time ago, see my fixing commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0b660259e927177dc0c6eb3b1c39f23c6a011c5f

When you fix that, please generate a V2 of your patch, you can do it
with something like:
git format-patch --subject-prefix="PATCH V2" -1
and send again the same way.

Thanks!

Re: [PATCH] ARM: dts: BCM5301X: add missing LEDs for Buffalo WZR-900DHP

[稲垣大志]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

Thank you for review.

I see, the trigger of "default-off" is unnecessary... I will fix it and
send again.

It was my first time to send patches, but your detailed advice helped me a
lot.

Thank you!

2018-03-07 17:51 GMT+09:00 Rafał Miłecki <zajec5@gmail.com>:

> On 5 March 2018 at 15:36,  <musashino.open@gmail.com> wrote:
> > From: INAGAKI Hiroshi <musashino.open@gmail.com>
> >
> > Buffalo WZR-900DHP has 8 LEDs, but there is not LED definitions in the
> > dts and cannot configure these LEDs.
> > I Added missing LED definitions for WZR-900DHP.
> >
> > Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
>
> Looks almost good, thanks for sending this patch to Florian.
>
> One comment: please drop all linux,default-trigger = "default-off";
> lines. I did the same mistake long time ago, see my fixing commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/
> linux.git/commit/?id=0b660259e927177dc0c6eb3b1c39f23c6a011c5f
>
> When you fix that, please generate a V2 of your patch, you can do it
> with something like:
> git format-patch --subject-prefix="PATCH V2" -1
> and send again the same way.
>
> Thanks!
>

[-- Attachment #2: Type: text/html, Size: 2130 bytes --]